[gap-decorations] Introduce rule-visibility-items: auto [chromium/src : main]
0 views
Skip to first unread message
Javier Contreras (Gerrit)
Feb 10, 2026, 2:36:01 PM (3 days ago) Feb 10
to Alison Maher, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Alison Maher
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Alison Maher
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alison Maher (Gerrit)
Feb 11, 2026, 1:20:11 PM (2 days ago) Feb 11
to Javier Contreras, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Javier Contreras
Alison Maher voted and added 4 comments![]( "Open in Gerrit")
Votes added by Alison Maher
| Code-Review | +1 |
4 comments
Commit Message
Line 16, Patchset 5 (Latest):
Discussion on whether this is the right approach can be foundAlison Maher . unresolved
nit: "found at"
Line 18, Patchset 5 (Latest):
subject to change, another potential solution would be to make `between`Alison Maher . unresolved
nit: ". Another"
Line 23, Patchset 5 (Latest):
There is no behavior change.Alison Maher . unresolved
nit: might be worth noting that this will have an impact though once we add support for `rule-visibility-items` in multicol in a follow up change
File third_party/blink/renderer/core/css/css_gap_decoration_property_utils.h
Line 75, Patchset 5 (Latest):
Alison Maher . unresolved
nit: Likely worth adding a brief comment similar to `ResolveRuleBreakValue`
Related details
Attention is currently required from:
- Javier Contreras
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Javier Contreras (Gerrit)
Feb 11, 2026, 4:35:23 PM (2 days ago) Feb 11
to Alison Maher, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Javier Contreras added 4 comments![]( "Open in Gerrit")
Commit Message
Line 16, Patchset 5:
Discussion on whether this is the right approach can be foundAlison Maher . resolved
Javier Contrerasnit: "found at"
Done
Line 18, Patchset 5:
subject to change, another potential solution would be to make `between`Alison Maher . resolved
Javier Contrerasnit: ". Another"
Done
nit: might be worth noting that this will have an impact though once we add support for `rule-visibility-items` in multicol in a follow up change
Javier Contreras
Done
File third_party/blink/renderer/core/css/css_gap_decoration_property_utils.h
nit: Likely worth adding a brief comment similar to `ResolveRuleBreakValue`
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Javier Contreras (Gerrit)
Feb 11, 2026, 4:35:25 PM (2 days ago) Feb 11
to Alison Maher, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Javier Contreras voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Feb 11, 2026, 4:44:11 PM (2 days ago) Feb 11
to Javier Contreras, Alison Maher, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57726.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 11, 2026, 6:27:15 PM (2 days ago) Feb 11
to Javier Contreras, Blink W3C Test Autoroller, Alison Maher, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/css/css_gap_decoration_property_utils.h
Insertions: 3, Deletions: 0.
@@ -73,6 +73,9 @@
GridTrackSizingDirection direction,
GapGeometry::ContainerType container_type);
+ // Resolves the `rule-visibility-items` value for a given direction and
+ // container. For multicol containers, `auto` resolves to `between` while for
+ // `grid`, `auto` resolves to `all`.
static RuleVisibilityItems ResolveRuleVisibilityItemsValue(
const ComputedStyle& style,
GapGeometry::ContainerType container_type,
```
Change information
Commit message:
[gap-decorations] Introduce rule-visibility-items: auto
This CL introduces an `auto` keyword for `rule-visibility-items`
properties and makes it the new default. The `auto` value resolves to
`all` for grid containers, and `between` for multicol containers.
This is needed due to backwards compat for the way current `column-rule`
behaves (without gap decorations).
Discussion on whether this is the right approach can be found at
https://github.com/w3c/csswg-drafts/issues/13477 and thus its still
subject to change. Another potential solution would be to make `between`
the default for grid. If that's the case we can simply revert this CL,
but we need either change implemented such that `rule-visibility-items`
can be implemented for multicol.
There is no behavior change, but enables us to implement
`rule-visibility-items` for multicol container in a follow up CL.
Bug: 357648037
Change-Id: Ica813752a907fa283cecaffd64ed5e07395666a4
Reviewed-by: Alison Maher <alm...@microsoft.com>
Commit-Queue: Javier Contreras <javi...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1583569}
Files:
- M third_party/blink/renderer/core/css/css_gap_decoration_property_utils.cc
- M third_party/blink/renderer/core/css/css_gap_decoration_property_utils.h
- M third_party/blink/renderer/core/css/css_properties.json5
- M third_party/blink/renderer/core/css/css_value_keywords.json5
- M third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc
- M third_party/blink/renderer/core/css/properties/shorthands/shorthands_custom.cc
- M third_party/blink/renderer/core/paint/gap_decorations_painter.cc
- M third_party/blink/web_tests/external/wpt/css/css-gaps/parsing/rule-visibility-items-computed.html
- M third_party/blink/web_tests/external/wpt/css/css-gaps/parsing/rule-visibility-items-invalid.html
- M third_party/blink/web_tests/external/wpt/css/css-gaps/parsing/rule-visibility-items-shorthand.html
- M third_party/blink/web_tests/external/wpt/css/css-gaps/parsing/rule-visibility-items-valid.html
- M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
- M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
- M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
Change size: M
Delta: 14 files changed, 62 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alison Maher
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Feb 11, 2026, 7:37:12 PM (2 days ago) Feb 11
to Chromium LUCI CQ, Javier Contreras, Alison Maher, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57726
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages