[DO NOT SUBMIT] ::nth-word() prototype [chromium/src : main]
Kevin Babbitt (Gerrit)
Kevin Babbitt added 3 comments![]( "Open in Gerrit")
Hi almaher@ - not looking for a full review on this; it's an AI coded prototype and needs a bit more iteration. But I wanted to get a high-level check on the approach for fragmenting by word in element.cc - could you please take a look at that and let me know if you see any issues with the general direction?
// ::nth-word() uses two distinct pseudo_argument encodings:This encoding seems a little clunky to me. The reason for it is to reuse the existing mechanism for named view transitions to store multiple ::nth-word() pseudos per element, but I'm not particularly fond of the number -> string -> number round-tripping and might need to iterate on this more.
// First-rule-wins tiebreaker: if a later An+B rule also matches a
// given word, we skip it. Cascade ordering across multiple
// ::nth-word() rules targeting the same word is a separate open
// question.
for (const auto& key_pair : nth_word_data.Styles()) {First rule wins is probably wrong; multiple applicable ::nth-word() pseudos applying to the same word should cascade as normal with last-one-wins semantics.
Related details
- Alison Maher
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |