[webkit-box] Ensure that display:-webkit-box blockifies its children. [chromium/src : main]
2 views
Skip to first unread message
Ian Kilpatrick (Gerrit)
May 11, 2026, 7:03:09 PM (3 days ago) May 11
to Morten Stenshorne, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Morten Stenshorne
Ian Kilpatrick added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Ian Kilpatrick . resolved
There was a one line code coverage difference that was bothering me. Turns out to have been a real issue!
This get scary once you realize that a table part may create a top level "inline" table not within an anonymous block.
Related details
Attention is currently required from:
- Morten Stenshorne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Morten Stenshorne (Gerrit)
May 12, 2026, 3:46:50 AM (3 days ago) May 12
to Ian Kilpatrick, Christian Biesinger, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org, mac-r...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick
Morten Stenshorne voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
May 12, 2026, 9:46:31 AM (3 days ago) May 12
to Morten Stenshorne, Christian Biesinger, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org, mac-r...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Ian Kilpatrick voted![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 12, 2026, 9:51:40 AM (3 days ago) May 12
to Ian Kilpatrick, Morten Stenshorne, Christian Biesinger, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ios-r...@chromium.org, mac-r...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[webkit-box] Ensure that display:-webkit-box blockifies its children.
There should be minimal behaviour differences between display:flex and
display:-webkit-box.
Previously we didn't blockify our children for -webkit-box. This meant
that we could have "inline-level" anonymous tables sitting within the
tree.
This patch blockifies all children similar to flex. Adds a WPT compat
test for this.
This doesn't affect -webkit-line-clamp boxes as their computed value for
display is coerced to "flow-root"
This allows us to make LayoutBlock::AddChildBeforeDescendant have the
exact same structure as LayoutTable, LayoutTableSection, LayoutTableRow
AddChildBeforeDescendant.
(new_child->IsInline() may be able to be converted to
new_child->IsText() at a later stage).
Change-Id: I2e2a141f9477602a60b463998080e10a196dcde0
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
Reviewed-by: Morten Stenshorne <mste...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1629284}
Files:
- M third_party/blink/renderer/core/layout/layout_block.cc
- M third_party/blink/renderer/core/layout/layout_box_model_object.cc
- M third_party/blink/renderer/core/style/computed_style.h
- A third_party/blink/web_tests/external/wpt/compat/webkit-box-blockify.html
- D third_party/blink/web_tests/fast/deprecated-flexbox/022.html
- M third_party/blink/web_tests/fast/deprecated-flexbox/intrinsic-min-width-applies-with-fixed-width.html
- D third_party/blink/web_tests/platform/ios/fast/deprecated-flexbox/022-expected.png
- D third_party/blink/web_tests/platform/linux/fast/deprecated-flexbox/022-expected.png
- D third_party/blink/web_tests/platform/mac/fast/deprecated-flexbox/022-expected.png
- D third_party/blink/web_tests/platform/win/fast/deprecated-flexbox/022-expected.png
Change size: M
Delta: 10 files changed, 46 insertions(+), 74 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Morten Stenshorne, +1 by Ian Kilpatrick
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
May 12, 2026, 12:47:55 PM (3 days ago) May 12
to Chromium LUCI CQ, Ian Kilpatrick, Morten Stenshorne, Christian Biesinger, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ios-r...@chromium.org, mac-r...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/59821
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages