[fedcm] Allow native IdPs to return a result from the Continuation API [chromium/src : main]

0 views
Skip to first unread message

Christian Biesinger (Gerrit)

unread,
Jul 24, 2026, 1:41:12 PM (4 days ago) Jul 24
to Sam Goto, Code Review Nudger, Dirk Schulze, Josh Karlin, Rijubrata Bhaumik, Jiewei Qian, Moe Adel, Zewen Li, Zhe Su, Hiroki Nakagawa, Peter Beverloo, Neil Coronado, Kevin McNee, Jerome Jiang, Hans Wennborg, Linyu He, srirama chandra sekhar, Lei Zhang, Per Åhgren, Raphael Kubo da Costa, Menard, Alexis, Michael Moss, Hongchan Choi, Peter Collingbourne, Javier Fernandez, Ale Bzk, Enterprise Policy Reviews, Charles Hager, Hu, Ningxin, Mark Schillaci, Kevin Babbitt, Fredrik Söderquist, Reid Kleckner, James Maclean, Olga Gerchikov, Andrew Rayskiy, Sinan Sahin, Ryan Sultanem, Nate Chapin, Stephen Chenney, Heron Yang, Yao Xiao, Sam Zackrisson, Nikhil Nayunigari, Mangesh Ghiware, Zijie He, Thorsten Kober, (Julie)Jeongeun Kim, Chromium Metrics Reviews, Shu Yang, Anurag Simgeker, Kentaro Hara, Ilya Biryukov, Mirko Bonadei, Daniel Cheng, Khushal Sagar, Nico Weber, Simon Hangl, android-bu...@system.gserviceaccount.com, AyeAye Python Dispatcher, SLSA Policy Verification Service, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, andysjl...@chromium.org, agriev...@chromium.org, chungshe...@google.com, horo+...@chromium.org, martijn...@martijnc.be, cros-enterpris...@chromium.org, devtools...@chromium.org, dtseng...@chromium.org, cblume...@chromium.org, zol...@webkit.org, glazuno...@chromium.org, dullweb...@chromium.org, rsleev...@chromium.org, jonmann+wa...@chromium.org, media-wi...@chromium.org, gcasto+w...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, max+watc...@igalia.com, dmurph+wa...@chromium.org, jophba...@chromium.org, petewi...@chromium.org, extension...@chromium.org, permissio...@chromium.org, kenjibah...@chromium.org, roblia...@chromium.org, chromiumme...@microsoft.com, hashimo...@chromium.org, blink-revie...@chromium.org, philli...@chromium.org, mpdento...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, yhanada+...@chromium.org, zelin+watch-we...@chromium.org, blink-revie...@chromium.org, ashleynewson+watch...@chromium.org, fserb...@chromium.org, pdr+svgw...@chromium.org, davidj...@chromium.org, blink-re...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, gangwu...@chromium.org, cros-setti...@google.com, mcasas+med...@chromium.org, storage...@chromium.org, mfoltz+wa...@chromium.org, kouhe...@chromium.org, weiluanw...@google.com, lize...@chromium.org, blink-re...@chromium.org, core-web-vita...@chromium.org, francisjp...@google.com, webapks-...@chromium.org, niharm...@google.com, halliwe...@chromium.org, bling-alchemy-eng+...@google.com, ejcaruso+wa...@chromium.org, blink-...@chromium.org, yusufo...@chromium.org, csharris...@chromium.org, tommyw+w...@chromium.org, arc-review...@google.com, iwells...@chromium.org, ajayramamurthy+w...@google.com, gavinp...@chromium.org, cros-print...@google.com, jackshira+w...@google.com, jackshira+...@google.com, hirokisa...@chromium.org, chromeos-gfx-...@google.com, stevenjb+wa...@chromium.org, dibyapal+wa...@chromium.org, tburkar...@chromium.org, lucasrada...@google.com, dewitt...@chromium.org, japhet+...@chromium.org, asumane...@google.com, jeffreycohen+watc...@chromium.org, olka+...@chromium.org, ukai+...@chromium.org, blink-rev...@chromium.org, twelling...@chromium.org, wfh+...@chromium.org, yuezhang...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, dennyh...@google.com, blink-reviews-p...@chromium.org, erickun...@chromium.org, mtomas...@chromium.org, estali...@chromium.org, edgesto...@microsoft.com, schedule...@chromium.org, fmalit...@chromium.org, pushi+wa...@google.com, zackha...@chromium.org, lizeb+watch...@chromium.org, asvitki...@chromium.org, blink-rev...@chromium.org, eic+...@google.com, wnwen...@chromium.org, net-r...@chromium.org, ydago...@chromium.org, eme-r...@chromium.org, crmulli...@chromium.org, dtseng+c...@chromium.org, khmel...@chromium.org, jiajunz+wa...@google.com, ramyagopa...@google.com, ffred...@chromium.org, hidehik...@chromium.org, alandin...@chromium.org, kyungjunle...@google.com, ckitaga...@chromium.org, meilian...@chromium.org, dkrahn...@chromium.org, odejesu...@chromium.org, yhanada+...@chromium.org, chrome-intelligence-te...@google.com, lwinston+watc...@google.com, toshikikikuch...@chromium.org, marinacio...@chromium.org, droger+w...@chromium.org, tgupta...@chromium.org, blink-revi...@chromium.org, fuchsia...@chromium.org, polard...@google.com, ntp-dev...@chromium.org, osaul+aut...@google.com, hansberry+wat...@chromium.org, tranbaod...@chromium.org, shgar+aut...@google.com, derinel+wat...@google.com, chromotin...@chromium.org, stanfie...@google.com, security-...@chromium.org, titoua...@chromium.org, blink-revie...@chromium.org, prerenderi...@chromium.org, srahim...@chromium.org, katie...@chromium.org, performance-m...@chromium.org, chlily...@chromium.org, ios-web-view...@google.com, loading-rev...@chromium.org, dmurph+watc...@chromium.org, hsuregan+wa...@chromium.org, alexmo...@chromium.org, crisrael+...@google.com, spang...@chromium.org, jdeblas...@chromium.org, network-ser...@chromium.org, print-rev...@chromium.org, knollr+wat...@chromium.org, chrome-b...@google.com, yhanad...@chromium.org, ender...@chromium.org, armalhotra+a...@google.com, gavin...@chromium.org, ortuno...@chromium.org, chfreme...@chromium.org, croissant-...@chromium.org, eric.c...@apple.com, donnd...@chromium.org, jbroma...@chromium.org, penghuan...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, jonmann+w...@chromium.org, ios-r...@chromium.org, mdjone...@chromium.org, gogeral...@chromium.org, penghu...@chromium.org, shuche...@chromium.org, feature-v...@chromium.org, loading...@chromium.org, tluk+...@chromium.org, jackshira+wat...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, harringt...@chromium.org, chadduffin+w...@chromium.org, dtapuska+ch...@chromium.org, moqati-team+chr...@google.com, mek+w...@chromium.org, yongshun+...@google.com, nona+...@chromium.org, michaelchec...@google.com, tmartino+tran...@chromium.org, jonmann+watc...@chromium.org, vinnypersky+...@google.com, bnc+...@chromium.org, mercer...@google.com, bmcquad...@chromium.org, peter+watch...@chromium.org, apavlo...@chromium.org, vasilii+watchlis...@chromium.org, dmurph+watchi...@chromium.org, sky+...@chromium.org, headless...@chromium.org, cros-ed...@google.com, trewin...@google.com, oshima...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, filesapp...@chromium.org, crostin...@chromium.org, jshin...@chromium.org, chromeos-kio...@google.com, lens-chrome...@google.com, chromium-...@engflow.com, pkotwic...@chromium.org, mfoltz+wa...@chromium.org, jackshira+wat...@google.com, kuragin+web-ap...@chromium.org, mattsimm...@chromium.org, siashah+au...@chromium.org, dfried...@chromium.org, khorimoto+w...@chromium.org, bartek...@chromium.org, crost...@chromium.org, chrome-tab-group-en...@google.com, inca-eng...@google.com, chrome-gr...@chromium.org, phshah...@chromium.org, chromeos-ca...@google.com, glider...@chromium.org, blink-rev...@chromium.org, lizeb...@chromium.org, ios-actor...@google.com, webauthn...@chromium.org, lingqi...@chromium.org, tracing...@chromium.org, jz...@chromium.org, ayman...@chromium.org, wychen...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, mac-r...@chromium.org, siyua+aut...@chromium.org, mattreyno...@chromium.org, anastas...@google.com, mar...@chromium.org, arthursonzog...@chromium.org, media-cro...@chromium.org, steimel+...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, yuzo+...@chromium.org, dtapuska+...@chromium.org, shannc...@chromium.org, ajayramamurt...@google.com, thegreenf...@chromium.org, vakh+safe_br...@chromium.org, enne...@chromium.org, eugeni...@chromium.org, sloboda...@chromium.org, core-timi...@chromium.org, grt+...@chromium.org, jatapiaro+wat...@google.com, xinghui...@chromium.org, blink-rev...@chromium.org, rginda...@chromium.org, shimazu+se...@chromium.org, dmurph+wat...@chromium.org, nicolas...@chromium.org, aixba+wat...@chromium.org, mfoltz+wa...@chromium.org, drott+bl...@chromium.org, cros-essential...@chromium.org, speed-metrics...@chromium.org, keithle...@chromium.org, tbarzi...@chromium.org, kinuko+...@chromium.org, telemetr...@chromium.org, nwoked...@chromium.org, kinuko...@chromium.org, emircan+watch...@chromium.org, fgal...@chromium.org, christia...@chromium.org, dcheng+c...@chromium.org, antoniosarto...@chromium.org, dtraino...@chromium.org, jorgel...@chromium.org, hanxi...@chromium.org, loyso...@chromium.org, creis...@chromium.org, mkwst+w...@chromium.org, ozone-...@chromium.org, webap...@microsoft.com, byronle...@chromium.org, mgiuca...@chromium.org, ananyasee...@google.com, cros-report...@google.com, nickdiego+wa...@igalia.com, marq+...@chromium.org, aashna...@google.com, android-web...@chromium.org, rmcelra...@chromium.org, speed-metr...@chromium.org, pdf-r...@chromium.org, ios-rev...@chromium.org, joeantonetti+wa...@google.com, blink-work...@chromium.org, navigation...@chromium.org, abigailbk...@google.com, omnibox-...@chromium.org, blink-re...@chromium.org, rrsilva+wat...@google.com, peilinwa...@google.com, menghua...@google.com, chromium-a...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org
Attention needed from Sam Goto

Christian Biesinger added 2 comments

File chrome/browser/ui/webid/identity_dialog_controller.cc
Line 444, Patchset 5 (Latest): content::IntentResolver::NotifyResolve(rp_web_contents_->GetPrimaryPage(),
Christian Biesinger . unresolved

so, I get that we can't use IdentityRegistry for this, since we don't have a "child" webview.

but this new class (and re-looking up the pending web request!) seems like pointless overhead. usually this class communicates with the request through callbacks, why not add a callback for this?

alternatively, maybe the callbacks should be converted to a delegate interface that Request implements, to make it easier to add new callbacks

File content/browser/webid/intent_resolver.cc
Line 11, Patchset 5 (Latest):namespace content {
Christian Biesinger . unresolved

IMO this should be in content::webid, especially since the name is super generic

Open in Gerrit

Related details

Attention is currently required from:
  • Sam Goto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id58616935f2c67939f6a039f1d0c0675f326d7ed
Gerrit-Change-Number: 7926589
Gerrit-PatchSet: 5
Gerrit-Owner: Sam Goto <go...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-Reviewer: Sam Goto <go...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Ale Bzk <ales...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Anurag Simgeker <anurags...@google.com>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: Charles Hager <clh...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Heron Yang <hero...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: Ilya Biryukov <ibir...@google.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Josh Karlin <jka...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Khushal Sagar <khusha...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Linyu He <lin...@google.com>
Gerrit-CC: Mangesh Ghiware <mghi...@google.com>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Moss <mm...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-CC: Moe Adel <ad...@google.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Neil Coronado <ne...@google.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Nico Weber <tha...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Per Åhgren <pe...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Peter Collingbourne <p...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Reid Kleckner <r...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Ryan Sultanem <rs...@google.com>
Gerrit-CC: Sam Zackrisson <sa...@chromium.org>
Gerrit-CC: Shu Yang <shu...@google.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Sinan Sahin <sinan...@google.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Thorsten Kober <thor...@google.com>
Gerrit-CC: Yao Xiao <yao...@chromium.org>
Gerrit-CC: Zewen Li <zew...@google.com>
Gerrit-CC: Zhe Su <su...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Sam Goto <go...@chromium.org>
Gerrit-Comment-Date: Fri, 24 Jul 2026 17:40:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Takuto Ikuta (Gerrit)

unread,
Jul 27, 2026, 9:01:28 PM (24 hours ago) Jul 27
to Sam Goto, chrome-b...@google.com, Code Review Nudger, Dirk Schulze, Josh Karlin, Rijubrata Bhaumik, Jiewei Qian, Moe Adel, Zewen Li, Zhe Su, Hiroki Nakagawa, Peter Beverloo, Neil Coronado, Kevin McNee, Jerome Jiang, Hans Wennborg, Linyu He, srirama chandra sekhar, Lei Zhang, Per Åhgren, Raphael Kubo da Costa, Menard, Alexis, Michael Moss, Hongchan Choi, Peter Collingbourne, Javier Fernandez, Ale Bzk, Enterprise Policy Reviews, Charles Hager, Hu, Ningxin, Mark Schillaci, Kevin Babbitt, Fredrik Söderquist, Reid Kleckner, James Maclean, Olga Gerchikov, Andrew Rayskiy, Sinan Sahin, Ryan Sultanem, Nate Chapin, Stephen Chenney, Heron Yang, Yao Xiao, Sam Zackrisson, Nikhil Nayunigari, Mangesh Ghiware, Zijie He, Thorsten Kober, (Julie)Jeongeun Kim, Chromium Metrics Reviews, Shu Yang, Anurag Simgeker, Kentaro Hara, Ilya Biryukov, Mirko Bonadei, Daniel Cheng, Khushal Sagar, Nico Weber, Simon Hangl, android-bu...@system.gserviceaccount.com, AyeAye Python Dispatcher, SLSA Policy Verification Service, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, andysjl...@chromium.org, agriev...@chromium.org, chungshe...@google.com, horo+...@chromium.org, martijn...@martijnc.be, cros-enterpris...@chromium.org, devtools...@chromium.org, dtseng...@chromium.org, cblume...@chromium.org, zol...@webkit.org, glazuno...@chromium.org, dullweb...@chromium.org, rsleev...@chromium.org, jonmann+wa...@chromium.org, media-wi...@chromium.org, gcasto+w...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, max+watc...@igalia.com, dmurph+wa...@chromium.org, jophba...@chromium.org, petewi...@chromium.org, extension...@chromium.org, permissio...@chromium.org, kenjibah...@chromium.org, roblia...@chromium.org, chromiumme...@microsoft.com, hashimo...@chromium.org, blink-revie...@chromium.org, philli...@chromium.org, mpdento...@chromium.org, blink-revi...@chromium.org, devtools-re...@chromium.org, yhanada+...@chromium.org, zelin+watch-we...@chromium.org, blink-revie...@chromium.org, ashleynewson+watch...@chromium.org, fserb...@chromium.org, pdr+svgw...@chromium.org, davidj...@chromium.org, blink-re...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, gangwu...@chromium.org, cros-setti...@google.com, mcasas+med...@chromium.org, storage...@chromium.org, mfoltz+wa...@chromium.org, kouhe...@chromium.org, weiluanw...@google.com, lize...@chromium.org, blink-re...@chromium.org, core-web-vita...@chromium.org, francisjp...@google.com, webapks-...@chromium.org, niharm...@google.com, halliwe...@chromium.org, bling-alchemy-eng+...@google.com, ejcaruso+wa...@chromium.org, blink-...@chromium.org, yusufo...@chromium.org, csharris...@chromium.org, tommyw+w...@chromium.org, arc-review...@google.com, iwells...@chromium.org, ajayramamurthy+w...@google.com, gavinp...@chromium.org, cros-print...@google.com, jackshira+w...@google.com, jackshira+...@google.com, hirokisa...@chromium.org, chromeos-gfx-...@google.com, stevenjb+wa...@chromium.org, dibyapal+wa...@chromium.org, tburkar...@chromium.org, lucasrada...@google.com, dewitt...@chromium.org, japhet+...@chromium.org, asumane...@google.com, jeffreycohen+watc...@chromium.org, olka+...@chromium.org, ukai+...@chromium.org, blink-rev...@chromium.org, twelling...@chromium.org, wfh+...@chromium.org, yuezhang...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, dennyh...@google.com, blink-reviews-p...@chromium.org, erickun...@chromium.org, mtomas...@chromium.org, estali...@chromium.org, edgesto...@microsoft.com, schedule...@chromium.org, fmalit...@chromium.org, pushi+wa...@google.com, zackha...@chromium.org, lizeb+watch...@chromium.org, asvitki...@chromium.org, blink-rev...@chromium.org, eic+...@google.com, wnwen...@chromium.org, net-r...@chromium.org, ydago...@chromium.org, eme-r...@chromium.org, crmulli...@chromium.org, dtseng+c...@chromium.org, khmel...@chromium.org, jiajunz+wa...@google.com, ramyagopa...@google.com, ffred...@chromium.org, hidehik...@chromium.org, alandin...@chromium.org, kyungjunle...@google.com, ckitaga...@chromium.org, meilian...@chromium.org, dkrahn...@chromium.org, odejesu...@chromium.org, yhanada+...@chromium.org, chrome-intelligence-te...@google.com, lwinston+watc...@google.com, toshikikikuch...@chromium.org, marinacio...@chromium.org, droger+w...@chromium.org, tgupta...@chromium.org, blink-revi...@chromium.org, fuchsia...@chromium.org, polard...@google.com, ntp-dev...@chromium.org, osaul+aut...@google.com, hansberry+wat...@chromium.org, tranbaod...@chromium.org, shgar+aut...@google.com, derinel+wat...@google.com, chromotin...@chromium.org, stanfie...@google.com, security-...@chromium.org, titoua...@chromium.org, blink-revie...@chromium.org, prerenderi...@chromium.org, srahim...@chromium.org, katie...@chromium.org, performance-m...@chromium.org, chlily...@chromium.org, ios-web-view...@google.com, loading-rev...@chromium.org, dmurph+watc...@chromium.org, hsuregan+wa...@chromium.org, alexmo...@chromium.org, crisrael+...@google.com, spang...@chromium.org, jdeblas...@chromium.org, network-ser...@chromium.org, print-rev...@chromium.org, knollr+wat...@chromium.org, yhanad...@chromium.org, ender...@chromium.org, armalhotra+a...@google.com, gavin...@chromium.org, ortuno...@chromium.org, chfreme...@chromium.org, croissant-...@chromium.org, eric.c...@apple.com, donnd...@chromium.org, jbroma...@chromium.org, penghuan...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, jonmann+w...@chromium.org, ios-r...@chromium.org, mdjone...@chromium.org, gogeral...@chromium.org, penghu...@chromium.org, shuche...@chromium.org, feature-v...@chromium.org, loading...@chromium.org, tluk+...@chromium.org, jackshira+wat...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, harringt...@chromium.org, chadduffin+w...@chromium.org, dtapuska+ch...@chromium.org, moqati-team+chr...@google.com, mek+w...@chromium.org, yongshun+...@google.com, nona+...@chromium.org, michaelchec...@google.com, tmartino+tran...@chromium.org, jonmann+watc...@chromium.org, vinnypersky+...@google.com, bnc+...@chromium.org, mercer...@google.com, bmcquad...@chromium.org, peter+watch...@chromium.org, apavlo...@chromium.org, vasilii+watchlis...@chromium.org, dmurph+watchi...@chromium.org, sky+...@chromium.org, headless...@chromium.org, cros-ed...@google.com, trewin...@google.com, oshima...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, filesapp...@chromium.org, crostin...@chromium.org, jshin...@chromium.org, chromeos-kio...@google.com, lens-chrome...@google.com, chromium-...@engflow.com, pkotwic...@chromium.org, mfoltz+wa...@chromium.org, jackshira+wat...@google.com, kuragin+web-ap...@chromium.org, mattsimm...@chromium.org, siashah+au...@chromium.org, dfried...@chromium.org, khorimoto+w...@chromium.org, bartek...@chromium.org, crost...@chromium.org, chrome-tab-group-en...@google.com, inca-eng...@google.com, chrome-gr...@chromium.org, phshah...@chromium.org, chromeos-ca...@google.com, glider...@chromium.org, blink-rev...@chromium.org, lizeb...@chromium.org, ios-actor...@google.com, webauthn...@chromium.org, lingqi...@chromium.org, tracing...@chromium.org, jz...@chromium.org, ayman...@chromium.org, wychen...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, mac-r...@chromium.org, siyua+aut...@chromium.org, mattreyno...@chromium.org, anastas...@google.com, mar...@chromium.org, arthursonzog...@chromium.org, media-cro...@chromium.org, steimel+...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, yuzo+...@chromium.org, dtapuska+...@chromium.org, shannc...@chromium.org, ajayramamurt...@google.com, thegreenf...@chromium.org, vakh+safe_br...@chromium.org, enne...@chromium.org, eugeni...@chromium.org, sloboda...@chromium.org, core-timi...@chromium.org, grt+...@chromium.org, jatapiaro+wat...@google.com, xinghui...@chromium.org, blink-rev...@chromium.org, rginda...@chromium.org, shimazu+se...@chromium.org, dmurph+wat...@chromium.org, nicolas...@chromium.org, aixba+wat...@chromium.org, mfoltz+wa...@chromium.org, drott+bl...@chromium.org, cros-essential...@chromium.org, speed-metrics...@chromium.org, keithle...@chromium.org, tbarzi...@chromium.org, kinuko+...@chromium.org, telemetr...@chromium.org, nwoked...@chromium.org, kinuko...@chromium.org, emircan+watch...@chromium.org, fgal...@chromium.org, christia...@chromium.org, dcheng+c...@chromium.org, antoniosarto...@chromium.org, dtraino...@chromium.org, jorgel...@chromium.org, hanxi...@chromium.org, loyso...@chromium.org, creis...@chromium.org, mkwst+w...@chromium.org, ozone-...@chromium.org, webap...@microsoft.com, byronle...@chromium.org, mgiuca...@chromium.org, ananyasee...@google.com, cros-report...@google.com, nickdiego+wa...@igalia.com, marq+...@chromium.org, aashna...@google.com, android-web...@chromium.org, rmcelra...@chromium.org, speed-metr...@chromium.org, pdf-r...@chromium.org, ios-rev...@chromium.org, joeantonetti+wa...@google.com, blink-work...@chromium.org, navigation...@chromium.org, abigailbk...@google.com, omnibox-...@chromium.org, blink-re...@chromium.org, rrsilva+wat...@google.com, peilinwa...@google.com, menghua...@google.com, chromium-a...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org, Takuto Ikuta
Attention needed from Sam Goto

Takuto Ikuta removed chrome-b...@google.com from this change

Deleted Reviewers:
Open in Gerrit

Related details

Attention is currently required from:
  • Sam Goto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages