[Masonry] Update feature flag name to CSSGridLanesLayout [chromium/src : main]

0 views
Skip to first unread message

Celeste Pan (Gerrit)

unread,
Dec 2, 2025, 4:26:47 PM (7 days ago) Dec 2
to Alison Maher, Kurt Catti-Schmidt, Yanling Wang, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, AyeAye, jmedle...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, asvitki...@chromium.org, kinuko...@chromium.org
Attention needed from Alison Maher and Kurt Catti-Schmidt

Celeste Pan voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alison Maher
  • Kurt Catti-Schmidt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I53b3d2660bddbebbefdd0ffec3b9a3e8bbaf1d6d
Gerrit-Change-Number: 7214031
Gerrit-PatchSet: 4
Gerrit-Owner: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Celeste Pan <celes...@microsoft.com>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Yanling Wang <yanli...@microsoft.com>
Gerrit-Attention: Alison Maher <alm...@microsoft.com>
Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Comment-Date: Tue, 02 Dec 2025 21:26:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kurt Catti-Schmidt (Gerrit)

unread,
Dec 2, 2025, 4:42:48 PM (7 days ago) Dec 2
to Alison Maher, Celeste Pan, Yanling Wang, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, AyeAye, jmedle...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, asvitki...@chromium.org, kinuko...@chromium.org
Attention needed from Alison Maher

Kurt Catti-Schmidt voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alison Maher
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I53b3d2660bddbebbefdd0ffec3b9a3e8bbaf1d6d
Gerrit-Change-Number: 7214031
Gerrit-PatchSet: 4
Gerrit-Owner: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Celeste Pan <celes...@microsoft.com>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Yanling Wang <yanli...@microsoft.com>
Gerrit-Attention: Alison Maher <alm...@microsoft.com>
Gerrit-Comment-Date: Tue, 02 Dec 2025 21:42:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alison Maher (Gerrit)

unread,
Dec 2, 2025, 4:43:50 PM (7 days ago) Dec 2
to Ian Kilpatrick, Kurt Catti-Schmidt, Celeste Pan, Yanling Wang, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, AyeAye, jmedle...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, asvitki...@chromium.org, kinuko...@chromium.org
Attention needed from Ian Kilpatrick

Alison Maher added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Alison Maher . resolved

+Ian for virtual test suites

Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I53b3d2660bddbebbefdd0ffec3b9a3e8bbaf1d6d
Gerrit-Change-Number: 7214031
Gerrit-PatchSet: 4
Gerrit-Owner: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Celeste Pan <celes...@microsoft.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Yanling Wang <yanli...@microsoft.com>
Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Dec 2025 21:43:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Kilpatrick (Gerrit)

unread,
Dec 2, 2025, 4:46:27 PM (7 days ago) Dec 2
to Alison Maher, Kurt Catti-Schmidt, Celeste Pan, Yanling Wang, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, AyeAye, jmedle...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, asvitki...@chromium.org, kinuko...@chromium.org
Attention needed from Alison Maher

Ian Kilpatrick voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alison Maher
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I53b3d2660bddbebbefdd0ffec3b9a3e8bbaf1d6d
Gerrit-Change-Number: 7214031
Gerrit-PatchSet: 4
Gerrit-Owner: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Celeste Pan <celes...@microsoft.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Yanling Wang <yanli...@microsoft.com>
Gerrit-Attention: Alison Maher <alm...@microsoft.com>
Gerrit-Comment-Date: Tue, 02 Dec 2025 21:46:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alison Maher (Gerrit)

unread,
Dec 2, 2025, 4:47:09 PM (7 days ago) Dec 2
to Ian Kilpatrick, Kurt Catti-Schmidt, Celeste Pan, Yanling Wang, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, AyeAye, jmedle...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, asvitki...@chromium.org, kinuko...@chromium.org

Alison Maher voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I53b3d2660bddbebbefdd0ffec3b9a3e8bbaf1d6d
Gerrit-Change-Number: 7214031
Gerrit-PatchSet: 4
Gerrit-Owner: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Celeste Pan <celes...@microsoft.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Yanling Wang <yanli...@microsoft.com>
Gerrit-Comment-Date: Tue, 02 Dec 2025 21:47:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 2, 2025, 5:11:22 PM (7 days ago) Dec 2
to Alison Maher, Ian Kilpatrick, Kurt Catti-Schmidt, Celeste Pan, Yanling Wang, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, AyeAye, jmedle...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, asvitki...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[Masonry] Update feature flag name to CSSGridLanesLayout

Update the feature flag name to match the new display type naming.
Bug: 343257585
Change-Id: I53b3d2660bddbebbefdd0ffec3b9a3e8bbaf1d6d
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Reviewed-by: Celeste Pan <celes...@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <ksc...@microsoft.com>
Commit-Queue: Alison Maher <alm...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1553090}
Files:
  • M chrome/browser/about_flags.cc
  • M chrome/browser/flag_descriptions.h
  • M third_party/blink/renderer/core/css/css_properties.json5
  • M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
  • M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
  • M third_party/blink/renderer/core/style/computed_style_extra_fields.json5
  • M third_party/blink/renderer/platform/runtime_enabled_features.json5
  • M third_party/blink/web_tests/VirtualTestSuites
  • M third_party/blink/web_tests/virtual/disable-css-masonry-layout/README.md
  • M tools/metrics/histograms/enums.xml
Change size: M
Delta: 10 files changed, 29 insertions(+), 26 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Ian Kilpatrick, +1 by Celeste Pan, +1 by Kurt Catti-Schmidt
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I53b3d2660bddbebbefdd0ffec3b9a3e8bbaf1d6d
Gerrit-Change-Number: 7214031
Gerrit-PatchSet: 5
Gerrit-Owner: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Celeste Pan <celes...@microsoft.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages