Kevin Babbitt (Gerrit)

unread,

Feb 5, 2026, 4:47:34 PM (8 days ago) Feb 5

to Javier Contreras, chromium...@chromium.org, Menard, Alexis, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-re...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org

Attention needed from Javier Contreras

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Javier Contreras

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Javier Contreras (Gerrit)

unread,

Feb 5, 2026, 4:54:56 PM (8 days ago) Feb 5

to Kevin Babbitt, chromium...@chromium.org, Menard, Alexis, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-re...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org

Attention needed from Kevin Babbitt

Javier Contreras added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Javier Contreras . resolved

So many times I actually was confused as to why `rule-overlap` did nothing only to realize it was `gap-rule-overlap` so this ia much needed lol, thanks!

Open in Gerrit

Related details

Attention is currently required from:

Kevin Babbitt

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Javier Contreras (Gerrit)

unread,

Feb 5, 2026, 4:54:57 PM (8 days ago) Feb 5

to Kevin Babbitt, chromium...@chromium.org, Menard, Alexis, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-re...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org

Attention needed from Kevin Babbitt

Javier Contreras voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Kevin Babbitt

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kevin Babbitt (Gerrit)

unread,

Feb 5, 2026, 5:10:29 PM (8 days ago) Feb 5

to Fredrik Söderquist, Javier Contreras, chromium...@chromium.org, Menard, Alexis, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-re...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org

Attention needed from Fredrik Söderquist

Kevin Babbitt added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Kevin Babbitt . resolved

+fs@ for third_party/blink/renderer/core/paint/box_fragment_painter.cc

Open in Gerrit

Related details

Attention is currently required from:

Fredrik Söderquist

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fredrik Söderquist (Gerrit)

unread,

Feb 6, 2026, 7:24:07 AM (7 days ago) Feb 6

to Kevin Babbitt, Javier Contreras, chromium...@chromium.org, Menard, Alexis, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-re...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org

Attention needed from Kevin Babbitt

Fredrik Söderquist voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Kevin Babbitt

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Blink W3C Test Autoroller (Gerrit)

unread,

Feb 6, 2026, 12:16:32 PM (7 days ago) Feb 6

to Kevin Babbitt, Fredrik Söderquist, Javier Contreras, chromium...@chromium.org, Menard, Alexis, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-re...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org

Attention needed from Kevin Babbitt

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57620.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention is currently required from:

Kevin Babbitt

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Kevin Babbitt (Gerrit)

unread,

Feb 6, 2026, 12:35:54 PM (7 days ago) Feb 6

to Blink W3C Test Autoroller, Fredrik Söderquist, Javier Contreras, chromium...@chromium.org, Menard, Alexis, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-re...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org

Kevin Babbitt voted and added 1 comment

Votes added by Kevin Babbitt

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Kevin Babbitt . resolved

Thanks for the reviews!

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Feb 6, 2026, 1:35:47 PM (7 days ago) Feb 6

to Kevin Babbitt, Blink W3C Test Autoroller, Fredrik Söderquist, Javier Contreras, chromium...@chromium.org, Menard, Alexis, Chromium Metrics Reviews, AyeAye, blink-...@chromium.org, blink-re...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
Insertions: 5, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: tools/metrics/histograms/metadata/blink/enums.xml
Insertions: 5, Deletions: 1.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

Rename gap-rule-overlap to rule-overlap

Per CSSWG resolution: https://github.com/w3c/csswg-drafts/issues/12540

Bug: 357648037

Change-Id: I47a615951b82c10b7c1b22d58bfbec6e14eac3c5

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7547470

Reviewed-by: Javier Contreras <javi...@microsoft.com>

Reviewed-by: Fredrik Söderquist <f...@opera.com>

Commit-Queue: Kevin Babbitt <kbab...@microsoft.com>

Cr-Commit-Position: refs/heads/main@{#1580966}

Files:

M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
M third_party/blink/renderer/core/css/css_properties.json5
M third_party/blink/renderer/core/css/css_property_equality.cc
M third_party/blink/renderer/core/css/css_value_keywords.json5
M third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc
M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
M third_party/blink/renderer/core/paint/box_fragment_painter.cc
M third_party/blink/web_tests/external/wpt/css/css-gaps/flex/flex-gap-decorations-012.html
M third_party/blink/web_tests/external/wpt/css/css-gaps/flex/flex-gap-decorations-015.html
M third_party/blink/web_tests/external/wpt/css/css-gaps/flex/flex-gap-decorations-016.html
M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/grid-gap-decorations-023.html
M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/subgrid/subgrid-gap-decorations-017.html
M third_party/blink/web_tests/external/wpt/css/css-gaps/multicol/multicol-gap-decorations-009.html
M third_party/blink/web_tests/external/wpt/css/css-gaps/multicol/multicol-gap-decorations-022.html
M third_party/blink/web_tests/external/wpt/css/css-gaps/multicol/multicol-gap-decorations-023.html
M third_party/blink/web_tests/external/wpt/css/css-gaps/parsing/rule-overlap-computed.html
M third_party/blink/web_tests/external/wpt/css/css-gaps/parsing/rule-overlap-invalid.html
M third_party/blink/web_tests/external/wpt/css/css-gaps/parsing/rule-overlap-valid.html
M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
M tools/metrics/histograms/metadata/blink/enums.xml

Change size: M

Delta: 24 files changed, 44 insertions(+), 42 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Javier Contreras, +1 by Fredrik Söderquist

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Blink W3C Test Autoroller (Gerrit)

unread,

Feb 6, 2026, 2:24:55 PM (7 days ago) Feb 6

to Chromium LUCI CQ, Kevin Babbitt, Fredrik Söderquist, Javier Contreras, chromium...@chromium.org, Menard, Alexis, Chromium Metrics Reviews, AyeAye, blink-...@chromium.org, blink-re...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57620

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Rename gap-rule-overlap to rule-overlap [chromium/src : main]

Kevin Babbitt (Gerrit)

New activity on the change

Related details

Javier Contreras (Gerrit)

Javier Contreras added 1 comment

Related details

Javier Contreras (Gerrit)

Javier Contreras voted Code-Review+1

Related details

Kevin Babbitt (Gerrit)

Kevin Babbitt added 1 comment

Related details

Fredrik Söderquist (Gerrit)

Fredrik Söderquist voted Code-Review+1

Related details

Blink W3C Test Autoroller (Gerrit)

Message from Blink W3C Test Autoroller

Related details

Kevin Babbitt (Gerrit)

Kevin Babbitt voted and added 1 comment

Votes added by Kevin Babbitt

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information

Blink W3C Test Autoroller (Gerrit)

Message from Blink W3C Test Autoroller

Related details