Rename interest-*-delay to interest-delay-* [chromium/src : main]

0 views
Skip to first unread message

Mason Freed (Gerrit)

unread,
Sep 15, 2025, 7:24:15 PMSep 15
to Anders Hartvoll Ruud, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Anders Hartvoll Ruud

Mason Freed voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Anders Hartvoll Ruud
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic0787564f70787918ba23f0f6e2ef9bfc535be23
Gerrit-Change-Number: 6936722
Gerrit-PatchSet: 2
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Sep 2025 23:24:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Anders Hartvoll Ruud (Gerrit)

unread,
Sep 16, 2025, 3:34:04 AMSep 16
to Mason Freed, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Mason Freed

Anders Hartvoll Ruud voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic0787564f70787918ba23f0f6e2ef9bfc535be23
    Gerrit-Change-Number: 6936722
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Sep 2025 07:33:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Mason Freed (Gerrit)

    unread,
    Sep 16, 2025, 12:05:03 PMSep 16
    to Anders Hartvoll Ruud, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Mason Freed voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic0787564f70787918ba23f0f6e2ef9bfc535be23
    Gerrit-Change-Number: 6936722
    Gerrit-PatchSet: 4
    Gerrit-Owner: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Comment-Date: Tue, 16 Sep 2025 16:04:52 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Blink W3C Test Autoroller (Gerrit)

    unread,
    Sep 16, 2025, 1:38:05 PMSep 16
    to Mason Freed, Anders Hartvoll Ruud, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Message from Blink W3C Test Autoroller

    Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/54878.

    When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

    WPT Export docs:
    https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic0787564f70787918ba23f0f6e2ef9bfc535be23
    Gerrit-Change-Number: 6936722
    Gerrit-PatchSet: 4
    Gerrit-Owner: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Comment-Date: Tue, 16 Sep 2025 17:37:59 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 16, 2025, 2:10:58 PMSep 16
    to Mason Freed, Blink W3C Test Autoroller, Anders Hartvoll Ruud, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    2 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: third_party/blink/web_tests/external/wpt/html/semantics/interestfor/interestfor-css-shorthands.tentative.html
    Insertions: 8, Deletions: 8.

    The diff is too large to show. Please review the diff.
    ```

    Change information

    Commit message:
    Rename interest-*-delay to interest-delay-*

    The final resolution [1] and spec [2] call for different names
    than the Chromium prototype has been using:

    - `interest-show-delay` --> `interest-delay-start`
    - `interest-hide-delay` --> `interest-delay-end`

    [1] https://github.com/w3c/csswg-drafts/issues/9236#issuecomment-2940736593
    [2] https://drafts.csswg.org/css-ui-4/#interest
    Bug: 326681249
    Change-Id: Ic0787564f70787918ba23f0f6e2ef9bfc535be23
    Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
    Commit-Queue: Mason Freed <mas...@chromium.org>
    Auto-Submit: Mason Freed <mas...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1516165}
    Files:
    • M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
    • M third_party/blink/renderer/core/animation/css_time_interpolation_type.cc
    • M third_party/blink/renderer/core/animation/interpolation_types_map.cc
    • M third_party/blink/renderer/core/css/css_properties.json5
    • M third_party/blink/renderer/core/css/css_property_equality.cc
    • M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
    • M third_party/blink/renderer/core/dom/element.cc
    • M third_party/blink/renderer/core/dom/element.h
    • M third_party/blink/web_tests/external/wpt/html/semantics/interestfor/interestfor-basic-delays.tentative.html
    • M third_party/blink/web_tests/external/wpt/html/semantics/interestfor/interestfor-css-properties.tentative.html
    • M third_party/blink/web_tests/external/wpt/html/semantics/interestfor/interestfor-css-shorthands.tentative.html
    • R third_party/blink/web_tests/external/wpt/html/semantics/interestfor/interestfor-delay-end.tentative.html
    • R third_party/blink/web_tests/external/wpt/html/semantics/interestfor/interestfor-delay-start.tentative.html
    • M third_party/blink/web_tests/external/wpt/html/semantics/interestfor/interestfor-keyboard-behavior.tentative.html
    • M third_party/blink/web_tests/external/wpt/html/semantics/interestfor/resources/invoker-utils.js
    • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
    • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
    • M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
    • M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
    • M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
    • M tools/metrics/histograms/metadata/blink/enums.xml
    Change size: M
    Delta: 21 files changed, 77 insertions(+), 77 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Anders Hartvoll Ruud
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic0787564f70787918ba23f0f6e2ef9bfc535be23
    Gerrit-Change-Number: 6936722
    Gerrit-PatchSet: 5
    Gerrit-Owner: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    open
    diffy
    satisfied_requirement

    Blink W3C Test Autoroller (Gerrit)

    unread,
    Sep 16, 2025, 3:37:37 PMSep 16
    to Chromium LUCI CQ, Mason Freed, Anders Hartvoll Ruud, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Message from Blink W3C Test Autoroller

    The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/54878

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic0787564f70787918ba23f0f6e2ef9bfc535be23
    Gerrit-Change-Number: 6936722
    Gerrit-PatchSet: 5
    Gerrit-Owner: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Comment-Date: Tue, 16 Sep 2025 19:37:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages