Apply StringBuilder::AppendRange() more [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Sep 21, 2025, 9:49:29 PM (10 days ago) Sep 21
to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, Stephen Chenney, Alexis Menard, Yoav Weiss (@Shopify), Dirk Schulze, AyeAye, blink-re...@chromium.org, blink-rev...@chromium.org, kouhe...@chromium.org, fserb...@chromium.org, drott+bl...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, gavinp+p...@chromium.org, apavlo...@chromium.org, mfoltz+wa...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, yhiran...@chromium.org, blink-reviews-p...@chromium.org, ricea...@chromium.org, aleventh...@chromium.org, kinuko...@chromium.org
Attention needed from Fredrik Söderquist and Kent Tamura

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Kent Tamura . resolved

fs@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaa8cdf897688011f84654f921d560f7d9b90a47d
Gerrit-Change-Number: 6965264
Gerrit-PatchSet: 3
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Sep 2025 01:48:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Sep 22, 2025, 4:38:13 AM (10 days ago) Sep 22
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, Stephen Chenney, Alexis Menard, Yoav Weiss (@Shopify), Dirk Schulze, AyeAye, blink-re...@chromium.org, blink-rev...@chromium.org, kouhe...@chromium.org, fserb...@chromium.org, drott+bl...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, gavinp+p...@chromium.org, apavlo...@chromium.org, mfoltz+wa...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, yhiran...@chromium.org, blink-reviews-p...@chromium.org, ricea...@chromium.org, aleventh...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iaa8cdf897688011f84654f921d560f7d9b90a47d
    Gerrit-Change-Number: 6965264
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Mon, 22 Sep 2025 08:37:58 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 22, 2025, 4:48:01 AM (10 days ago) Sep 22
    to Kent Tamura, Fredrik Söderquist, chromium...@chromium.org, prerendering-reviews, Stephen Chenney, Alexis Menard, Yoav Weiss (@Shopify), Dirk Schulze, AyeAye, blink-re...@chromium.org, blink-rev...@chromium.org, kouhe...@chromium.org, fserb...@chromium.org, drott+bl...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, gavinp+p...@chromium.org, apavlo...@chromium.org, mfoltz+wa...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, yhiran...@chromium.org, blink-reviews-p...@chromium.org, ricea...@chromium.org, aleventh...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Apply StringBuilder::AppendRange() more

    This CL has no behavior changes.
    Change-Id: Iaa8cdf897688011f84654f921d560f7d9b90a47d
    Reviewed-by: Fredrik Söderquist <f...@opera.com>
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1518564}
    Files:
    • M third_party/blink/renderer/core/css/css_syntax_definition.cc
    • M third_party/blink/renderer/core/dom/space_split_string.cc
    • M third_party/blink/renderer/core/dom/space_split_string.h
    • M third_party/blink/renderer/core/editing/commands/undo_stack.cc
    • M third_party/blink/renderer/core/editing/commands/undo_stack.h
    • M third_party/blink/renderer/core/editing/commands/undo_step.cc
    • M third_party/blink/renderer/core/html/forms/email_input_type.cc
    • M third_party/blink/renderer/core/speculation_rules/speculation_rule_set.cc
    • M third_party/blink/renderer/core/style/grid_track_list.cc
    • M third_party/blink/renderer/core/svg/svg_transform.cc
    • M third_party/blink/renderer/core/url_pattern/url_pattern.cc
    • M third_party/blink/renderer/modules/content_extraction/document_chunker.cc
    • M third_party/blink/renderer/modules/plugins/dom_mime_type.cc
    • M third_party/blink/renderer/modules/webcodecs/audio_encoder.cc
    • M third_party/blink/renderer/modules/websockets/websocket_common.cc
    • M third_party/blink/renderer/platform/graphics/compositing_reasons.cc
    • M third_party/blink/renderer/platform/text/date_time_format_test.cc
    Change size: M
    Delta: 17 files changed, 54 insertions(+), 115 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Fredrik Söderquist
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iaa8cdf897688011f84654f921d560f7d9b90a47d
    Gerrit-Change-Number: 6965264
    Gerrit-PatchSet: 4
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages