Avoid including style_rule.h where not needed. [chromium/src : main]

0 views
Skip to first unread message

Morten Stenshorne (Gerrit)

unread,
Dec 2, 2025, 4:23:08 AM (8 days ago) Dec 2
to Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org
Attention needed from Rune Lillesveen

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idf5944a35d5f47f3d208cb8df6a2e2443c4199be
Gerrit-Change-Number: 7210453
Gerrit-PatchSet: 4
Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Dec 2025 09:22:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rune Lillesveen (Gerrit)

unread,
Dec 2, 2025, 5:41:31 AM (8 days ago) Dec 2
to Morten Stenshorne, Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org
Attention needed from Morten Stenshorne

Rune Lillesveen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Morten Stenshorne
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idf5944a35d5f47f3d208cb8df6a2e2443c4199be
    Gerrit-Change-Number: 7210453
    Gerrit-PatchSet: 4
    Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Comment-Date: Tue, 02 Dec 2025 10:41:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Morten Stenshorne (Gerrit)

    unread,
    Dec 2, 2025, 1:34:26 PM (7 days ago) Dec 2
    to Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org

    Morten Stenshorne voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idf5944a35d5f47f3d208cb8df6a2e2443c4199be
    Gerrit-Change-Number: 7210453
    Gerrit-PatchSet: 7
    Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Comment-Date: Tue, 02 Dec 2025 18:34:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Munira Tursunova (Gerrit)

    unread,
    Dec 2, 2025, 2:30:44 PM (7 days ago) Dec 2
    to Morten Stenshorne, Chromium LUCI CQ, Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org
    Attention needed from Morten Stenshorne and Rune Lillesveen

    Munira Tursunova voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Morten Stenshorne
    • Rune Lillesveen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idf5944a35d5f47f3d208cb8df6a2e2443c4199be
    Gerrit-Change-Number: 7210453
    Gerrit-PatchSet: 8
    Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Munira Tursunova <moo...@google.com>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Comment-Date: Tue, 02 Dec 2025 19:30:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Morten Stenshorne (Gerrit)

    unread,
    Dec 2, 2025, 2:31:25 PM (7 days ago) Dec 2
    to Munira Tursunova, Chromium LUCI CQ, Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org
    Attention needed from Rune Lillesveen

    Morten Stenshorne voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Rune Lillesveen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idf5944a35d5f47f3d208cb8df6a2e2443c4199be
    Gerrit-Change-Number: 7210453
    Gerrit-PatchSet: 8
    Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Munira Tursunova <moo...@google.com>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Comment-Date: Tue, 02 Dec 2025 19:31:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 2, 2025, 3:24:49 PM (7 days ago) Dec 2
    to Morten Stenshorne, Fredrik Söderquist, Stephen Chenney, Dirk Schulze, AyeAye, Munira Tursunova, Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Avoid including style_rule.h where not needed.

    This task wasn't as successful as I had hoped, since it turned out that
    this header is included by the generated file computed_style_base.h

    Compile size details:
    Delta: -177.64 MiB (-186267537)
    Delta %: -0.04%
    Change-Id: Idf5944a35d5f47f3d208cb8df6a2e2443c4199be
    Commit-Queue: Morten Stenshorne <mste...@chromium.org>
    Reviewed-by: Munira Tursunova <moo...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1553025}
    Files:
    • M third_party/blink/renderer/core/animation/css/css_animation_update.cc
    • M third_party/blink/renderer/core/animation/css/css_animation_update.h
    • M third_party/blink/renderer/core/animation/css/css_animations.cc
    • M third_party/blink/renderer/core/animation/css/css_animations.h
    • M third_party/blink/renderer/core/css/build.gni
    • M third_party/blink/renderer/core/css/cascade_layer_map.cc
    • M third_party/blink/renderer/core/css/cascade_layer_map.h
    • M third_party/blink/renderer/core/css/cascade_layered.h
    • M third_party/blink/renderer/core/css/css_apply_mixin_rule.h
    • M third_party/blink/renderer/core/css/css_condition_rule.cc
    • M third_party/blink/renderer/core/css/css_condition_rule.h
    • M third_party/blink/renderer/core/css/css_contents_mixin_rule.h
    • M third_party/blink/renderer/core/css/css_custom_media_rule.h
    • M third_party/blink/renderer/core/css/css_font_face.cc
    • M third_party/blink/renderer/core/css/css_font_feature_values_rule.h
    • M third_party/blink/renderer/core/css/css_font_selector.cc
    • M third_party/blink/renderer/core/css/css_function_rule.h
    • M third_party/blink/renderer/core/css/css_global_rule_set.cc
    • M third_party/blink/renderer/core/css/css_grouping_rule.cc
    • M third_party/blink/renderer/core/css/css_grouping_rule.h
    • M third_party/blink/renderer/core/css/css_keyframe_rule.cc
    • M third_party/blink/renderer/core/css/css_math_expression_node.h
    • M third_party/blink/renderer/core/css/css_selector_watch.cc
    • M third_party/blink/renderer/core/css/css_selector_watch.h
    • M third_party/blink/renderer/core/css/css_supports_rule.h
    • M third_party/blink/renderer/core/css/css_test_helpers.h
    • M third_party/blink/renderer/core/css/font_face.h
    • M third_party/blink/renderer/core/css/font_face_cache.cc
    • M third_party/blink/renderer/core/css/font_face_cache.h
    • M third_party/blink/renderer/core/css/font_face_set_document.h
    • M third_party/blink/renderer/core/css/font_face_set_worker.h
    • M third_party/blink/renderer/core/css/mixin_map.h
    • A third_party/blink/renderer/core/css/mixin_parameter_bindings.h
    • M third_party/blink/renderer/core/css/page_rule_collector.cc
    • M third_party/blink/renderer/core/css/page_rule_collector.h
    • M third_party/blink/renderer/core/css/parser/css_lazy_parsing_state.cc
    • M third_party/blink/renderer/core/css/parser/css_lazy_parsing_state.h
    • M third_party/blink/renderer/core/css/parser/css_parser.cc
    • M third_party/blink/renderer/core/css/parser/css_parser.h
    • M third_party/blink/renderer/core/css/parser/css_parser_impl.cc
    • M third_party/blink/renderer/core/css/parser/css_parser_impl.h
    • M third_party/blink/renderer/core/css/parser/css_parser_observer.h
    • M third_party/blink/renderer/core/css/parser/css_variable_parser.cc
    • M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
    • M third_party/blink/renderer/core/css/properties/css_parsing_utils.h
    • M third_party/blink/renderer/core/css/resolver/cascade_resolver.h
    • M third_party/blink/renderer/core/css/resolver/match_result.h
    • M third_party/blink/renderer/core/css/resolver/scoped_style_resolver.h
    • M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
    • M third_party/blink/renderer/core/css/resolver/style_builder_converter.h
    • M third_party/blink/renderer/core/css/resolver/style_cascade.h
    • M third_party/blink/renderer/core/css/resolver/style_resolver.h
    • M third_party/blink/renderer/core/css/rule_set.cc
    • M third_party/blink/renderer/core/css/rule_set.h
    • M third_party/blink/renderer/core/css/style_engine.cc
    • M third_party/blink/renderer/core/css/style_engine.h
    • M third_party/blink/renderer/core/css/style_rule.h
    • M third_party/blink/renderer/core/css/style_rule_css_style_declaration.cc
    • M third_party/blink/renderer/core/css/style_sheet_collection.h
    • M third_party/blink/renderer/core/css/style_sheet_contents.h
    • A third_party/blink/renderer/core/css/valid_property_filter.h
    • M third_party/blink/renderer/core/inspector/inspector_animation_agent.h
    • M third_party/blink/renderer/core/inspector/inspector_css_agent.h
    • M third_party/blink/renderer/core/inspector/inspector_style_sheet.cc
    • M third_party/blink/renderer/core/inspector/inspector_style_sheet.h
    • M third_party/blink/renderer/core/inspector/invalidation_set_to_selector_map.cc
    • M third_party/blink/renderer/core/inspector/invalidation_set_to_selector_map.h
    • M third_party/blink/renderer/core/style/style_view_transition_group.h
    • M third_party/blink/renderer/core/style/style_view_transition_name.h
    • M third_party/blink/renderer/core/svg/svg_length.cc
    Change size: L
    Delta: 70 files changed, 282 insertions(+), 169 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Munira Tursunova
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idf5944a35d5f47f3d208cb8df6a2e2443c4199be
    Gerrit-Change-Number: 7210453
    Gerrit-PatchSet: 9
    Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Munira Tursunova <moo...@google.com>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Fredrik Söderquist <f...@opera.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages