Remove touch-action:handwriting use counters and temporary code [chromium/src : main]

0 views
Skip to first unread message

Gaston Rodriguez (Gerrit)

unread,
Aug 14, 2025, 4:08:25 PMAug 14
to Olga Gerchikov, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, dtapuska+...@chromium.org, kinuko...@chromium.org
Attention needed from Olga Gerchikov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Olga Gerchikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I45a7527b96f1ebd7c0b5e113e5c335086350564a
Gerrit-Change-Number: 6851576
Gerrit-PatchSet: 3
Gerrit-Owner: Gaston Rodriguez <gas...@microsoft.com>
Gerrit-Reviewer: Gaston Rodriguez <gas...@microsoft.com>
Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Comment-Date: Thu, 14 Aug 2025 20:08:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Olga Gerchikov (Gerrit)

unread,
Aug 14, 2025, 5:22:56 PMAug 14
to Gaston Rodriguez, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, dtapuska+...@chromium.org, kinuko...@chromium.org
Attention needed from Gaston Rodriguez

Olga Gerchikov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Gaston Rodriguez
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I45a7527b96f1ebd7c0b5e113e5c335086350564a
    Gerrit-Change-Number: 6851576
    Gerrit-PatchSet: 3
    Gerrit-Owner: Gaston Rodriguez <gas...@microsoft.com>
    Gerrit-Reviewer: Gaston Rodriguez <gas...@microsoft.com>
    Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Gaston Rodriguez <gas...@microsoft.com>
    Gerrit-Comment-Date: Thu, 14 Aug 2025 21:22:48 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gaston Rodriguez (Gerrit)

    unread,
    Aug 14, 2025, 7:18:39 PMAug 14
    to Robert Flack, Olga Gerchikov, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, dtapuska+...@chromium.org, kinuko...@chromium.org
    Attention needed from Robert Flack

    Gaston Rodriguez added 1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Gaston Rodriguez . resolved

    Hi Robert, would you mind reviewing this CL? You were the reviewer for the original changes this CL is removing. Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Robert Flack
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I45a7527b96f1ebd7c0b5e113e5c335086350564a
    Gerrit-Change-Number: 6851576
    Gerrit-PatchSet: 3
    Gerrit-Owner: Gaston Rodriguez <gas...@microsoft.com>
    Gerrit-Reviewer: Gaston Rodriguez <gas...@microsoft.com>
    Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Robert Flack <fla...@chromium.org>
    Gerrit-Comment-Date: Thu, 14 Aug 2025 23:18:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Robert Flack (Gerrit)

    unread,
    Aug 18, 2025, 2:59:27 PMAug 18
    to Gaston Rodriguez, Olga Gerchikov, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, dtapuska+...@chromium.org, kinuko...@chromium.org
    Attention needed from Gaston Rodriguez

    Robert Flack voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Gaston Rodriguez
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I45a7527b96f1ebd7c0b5e113e5c335086350564a
    Gerrit-Change-Number: 6851576
    Gerrit-PatchSet: 3
    Gerrit-Owner: Gaston Rodriguez <gas...@microsoft.com>
    Gerrit-Reviewer: Gaston Rodriguez <gas...@microsoft.com>
    Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Gaston Rodriguez <gas...@microsoft.com>
    Gerrit-Comment-Date: Mon, 18 Aug 2025 18:59:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Gaston Rodriguez (Gerrit)

    unread,
    Aug 20, 2025, 12:56:29 PMAug 20
    to Robert Flack, Olga Gerchikov, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, dtapuska+...@chromium.org, kinuko...@chromium.org

    Gaston Rodriguez voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I45a7527b96f1ebd7c0b5e113e5c335086350564a
    Gerrit-Change-Number: 6851576
    Gerrit-PatchSet: 3
    Gerrit-Owner: Gaston Rodriguez <gas...@microsoft.com>
    Gerrit-Reviewer: Gaston Rodriguez <gas...@microsoft.com>
    Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Comment-Date: Wed, 20 Aug 2025 16:56:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Aug 20, 2025, 2:13:01 PMAug 20
    to Gaston Rodriguez, Robert Flack, Olga Gerchikov, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, dtapuska+...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove touch-action:handwriting use counters and temporary code

    This CL reverts CL:6005047 and CL:6240458

    The touch-action:handwriting keyword will not be shipped, and this CL
    cleans up the temporary code that was added during discovery to better
    understand the consequences of shipping the feature as was proposed.
    Bug: 382525574
    Change-Id: I45a7527b96f1ebd7c0b5e113e5c335086350564a
    Reviewed-by: Robert Flack <fla...@chromium.org>
    Commit-Queue: Gaston Rodriguez <gas...@microsoft.com>
    Reviewed-by: Olga Gerchikov <gerc...@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#1504094}
    Files:
    • M cc/input/touch_action.h
    • M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
    • M third_party/blink/renderer/core/css/css_properties.json5
    • M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
    • M third_party/blink/renderer/core/css/resolver/style_adjuster.cc
    • M third_party/blink/renderer/core/css/resolver/style_adjuster_test.cc
    • M third_party/blink/renderer/core/input/touch_action_test.cc
    • M third_party/blink/renderer/core/style/computed_style_extra_fields.json5
    • M tools/metrics/histograms/metadata/blink/enums.xml
    Change size: L
    Delta: 9 files changed, 24 insertions(+), 252 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Robert Flack, +1 by Olga Gerchikov
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I45a7527b96f1ebd7c0b5e113e5c335086350564a
    Gerrit-Change-Number: 6851576
    Gerrit-PatchSet: 4
    Gerrit-Owner: Gaston Rodriguez <gas...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Gaston Rodriguez <gas...@microsoft.com>
    Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages