[css-typed-om] Replace Element.styleMap with Element.attributeStyleMap [chromium/src : master]
Hwanseung Lee (Gerrit)
@Shend, haraken
PTAL, thanks.
To view, visit change 765553. To unsubscribe, or for help writing mail filters, visit settings.
Hwanseung Lee (Gerrit)
Hwanseung Lee uploaded patch set #5 to this change.
[css-typed-om] Replace Element.styleMap with Element.attributeStyleMap
Replace Element.styleMap with Element.attributeStyleMap.
Element.sytleMap is still behind runtime feature of CSSTypedOM.
so it does not need to notify at blink-dev groups.
https://drafts.css-houdini.org/css-typed-om-1/#inline-stylepropertymap
Bug:774933
Change-Id: I25c3dd401702505981b77fe38aa4798ea8ea9bd6
---
M third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/declared-styleMap-accepts-inherit.html
M third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/styleMap-update-function-expected.txt
M third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/styleMap-update-function.html
M third_party/WebKit/LayoutTests/typedcssom/cssURLImageValue.html
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_append.html
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_delete.html
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getAll.html
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getProperties.html
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iteration.html
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iterationWithModification.html
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_setGet.html
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/numbers.html
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/background-image.html
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/property-suite.js
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/transform.html
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-perspective.html
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/unparsedValue.html
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/unsupported-properties.html
M third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssKeywordValue.html
M third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssPositionValue.html
M third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssUnitValue.html
M third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssUrlImageValue.html
M third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/computed.html
M third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/get.html
M third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/getAll.html
M third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/getProperties.html
M third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/has.html
M third_party/WebKit/LayoutTests/typedcssom/the-stylepropertymap/iterable.html
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
M third_party/WebKit/Source/core/dom/Element.cpp
M third_party/WebKit/Source/core/dom/Element.h
M third_party/WebKit/Source/core/dom/Element.idl
33 files changed, 152 insertions(+), 157 deletions(-)
To view, visit change 765553. To unsubscribe, or for help writing mail filters, visit settings.
Blink WPT Bot (Gerrit)
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/w3c/web-platform-tests/pull/8161.
If this CL lands and Travis CI upstream is green, we will auto-merge the PR.
Note: Please check the Travis CI status (at the bottom of the PR) before landing this CL and only land this CL if the status is green. Otherwise a human needs to step in and resolve it manually. (This may be automated in the future, see https://crbug.com/711447)
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#Automatic-export-process
Darren Shen (Gerrit)
Awesome, LGTM
Patch set 5:Code-Review +1
Kentaro Hara (Gerrit)
Hwanseung Lee (Gerrit)
Patch set 5:Commit-Queue +2
Hwanseung Lee (Gerrit)
Hwanseung Lee uploaded patch set #6 to this change.
To view, visit change 765553. To unsubscribe, or for help writing mail filters, visit settings.
Hwanseung Lee (Gerrit)
Patch set 6:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying the patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Edit commit message" https://chromium-review.googlesource.com/c/765553/6
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/765553/6
Bot data: {"action": "start", "triggered_at": "2017-11-13T06:27:27.0Z", "cq_cfg_revision": "53169efc778284a99b3c4c6637cbeab1b9e8da7d", "revision": "fc1ab9f470a99d0ac2eede2358df9dea13aca929"}
Blink WPT Bot (Gerrit)
Successfully updated WPT GitHub pull request with new revision "Edit commit message": https://github.com/w3c/web-platform-tests/pull/8161
Commit Bot (Gerrit)
Try jobs failed on following builders:
chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/589499)
Hwanseung Lee (Gerrit)
present presumit was not working well... :(
i think presumit will be okay after other patch merged(https://chromium-review.googlesource.com/c/chromium/src/+/765215)
Hwanseung Lee (Gerrit)
Patch set 6:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying the patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Edit commit message" https://chromium-review.googlesource.com/c/765553/6
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/765553/6
Bot data: {"action": "start", "triggered_at": "2017-11-13T07:01:15.0Z", "cq_cfg_revision": "53169efc778284a99b3c4c6637cbeab1b9e8da7d", "revision": "fc1ab9f470a99d0ac2eede2358df9dea13aca929"}
Commit Bot (Gerrit)
Commit Bot merged this change.
[css-typed-om] Replace Element.styleMap with Element.attributeStyleMap
Replace Element.styleMap with Element.attributeStyleMap.
Element.sytleMap is still behind runtime feature of CSSTypedOM.
so it does not need to notify at blink-dev groups.
https://drafts.css-houdini.org/css-typed-om-1/#inline-stylepropertymap
Bug: 774933
Change-Id: I25c3dd401702505981b77fe38aa4798ea8ea9bd6
Reviewed-on: https://chromium-review.googlesource.com/765553
Commit-Queue: Hwanseung Lee <hs121...@samsung.com>
Reviewed-by: Darren Shen <sh...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515894}
Blink WPT Bot (Gerrit)
The WPT PR for this CL has been merged upstream! https://github.com/w3c/web-platform-tests/pull/8161