Avoid operator+ for strings in renderer/core/s*/ [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Nov 26, 2025, 12:34:45 AM (14 days ago) Nov 26
to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Dirk Schulze, prerendering-reviews, Stephen Chenney, Yoav Weiss (@Shopify), blink-rev...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, gavinp+p...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, ricea...@chromium.org
Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kent Tamura . resolved

fs@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3d4f82b3b088094b23286f72e802d84b6d172cad
Gerrit-Change-Number: 7206626
Gerrit-PatchSet: 1
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Wed, 26 Nov 2025 05:34:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Nov 26, 2025, 4:39:00 AM (14 days ago) Nov 26
to Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Dirk Schulze, prerendering-reviews, Stephen Chenney, Yoav Weiss (@Shopify), blink-rev...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, gavinp+p...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, ricea...@chromium.org
Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3d4f82b3b088094b23286f72e802d84b6d172cad
    Gerrit-Change-Number: 7206626
    Gerrit-PatchSet: 1
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Wed, 26 Nov 2025 09:38:55 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Nov 26, 2025, 4:42:04 AM (14 days ago) Nov 26
    to Kent Tamura, Fredrik Söderquist, AyeAye, chromium...@chromium.org, Dirk Schulze, prerendering-reviews, Stephen Chenney, Yoav Weiss (@Shopify), blink-rev...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, gavinp+p...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, ricea...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Avoid operator+ for strings in renderer/core/s*/

    StrCat() is smaller and faster than operator+.
    This CL has no behavior changes.
    Bug: 419595599
    Change-Id: I3d4f82b3b088094b23286f72e802d84b6d172cad
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Reviewed-by: Fredrik Söderquist <f...@opera.com>
    Cr-Commit-Position: refs/heads/main@{#1550346}
    Files:
    • M third_party/blink/renderer/core/speculation_rules/document_speculation_rules.cc
    • M third_party/blink/renderer/core/speculation_rules/speculation_rule_set.cc
    • M third_party/blink/renderer/core/speculation_rules/speculation_rules_header.cc
    • M third_party/blink/renderer/core/streams/miscellaneous_operations.cc
    • M third_party/blink/renderer/core/style/computed_grid_template_areas.cc
    • M third_party/blink/renderer/core/style/gap_data_list.h
    • M third_party/blink/renderer/core/svg/svg_document_resource_tracker.cc
    • M third_party/blink/renderer/core/svg/svg_element.cc
    Change size: M
    Delta: 8 files changed, 87 insertions(+), 84 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Fredrik Söderquist
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3d4f82b3b088094b23286f72e802d84b6d172cad
    Gerrit-Change-Number: 7206626
    Gerrit-PatchSet: 2
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages