[line-clamp] Add syntax for clamping by both lines and height [chromium/src : main]

[Ian Kilpatrick (Gerrit)]

Attention needed from Andreu Botella

Ian Kilpatrick added 1 comment

File third_party/blink/renderer/core/css/css_properties.json5

Line 7361, Patchset 2 (Latest): type_name: "int",

Ian Kilpatrick . unresolved

It might be better to represent this as std::optional<int> rather than have the additional field.

Open in Gerrit

Related details

Attention is currently required from:

• Andreu Botella

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5d639d36cc70f94148e33028b1faabb54cfd2393

Gerrit-Change-Number: 7798160

Gerrit-PatchSet: 2

Gerrit-Owner: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andreu Botella <abot...@igalia.com>

Gerrit-Comment-Date: Tue, 28 Apr 2026 16:17:06 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Andreu Botella (Gerrit)]

Attention needed from Ian Kilpatrick

Andreu Botella added 1 comment

File third_party/blink/renderer/core/css/css_properties.json5

Line 7361, Patchset 2 (Latest): type_name: "int",

Ian Kilpatrick . unresolved

It might be better to represent this as std::optional<int> rather than have the additional field.

Andreu Botella

`std:optional<int>` can't represent clamping by both lines and height (e.g. `max-lines: 3 auto`).

Open in Gerrit

Related details

Attention is currently required from:

• Ian Kilpatrick

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5d639d36cc70f94148e33028b1faabb54cfd2393

Gerrit-Change-Number: 7798160

Gerrit-PatchSet: 2

Gerrit-Owner: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Comment-Date: Tue, 28 Apr 2026 17:59:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ian Kilpatrick <ikilp...@chromium.org>

[Ian Kilpatrick (Gerrit)]

Attention needed from Andreu Botella

Ian Kilpatrick added 1 comment

File third_party/blink/renderer/core/css/css_properties.json5

Line 7361, Patchset 2: type_name: "int",

Ian Kilpatrick . unresolved

It might be better to represent this as std::optional<int> rather than have the additional field.

Andreu Botella

`std:optional<int>` can't represent clamping by both lines and height (e.g. `max-lines: 3 auto`).

Ian Kilpatrick

Ah I see - so for something which likely isn't going to be set that much i'd marginally prefer something like:
third_party/blink/renderer/core/style/text_overflow_data.h

(then don't have to write all the inheritance logic etc)

Open in Gerrit

Related details

Attention is currently required from:

• Andreu Botella

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5d639d36cc70f94148e33028b1faabb54cfd2393

Gerrit-Change-Number: 7798160

Gerrit-PatchSet: 3

Gerrit-Owner: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andreu Botella <abot...@igalia.com>

Gerrit-Comment-Date: Fri, 01 May 2026 23:18:19 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Andreu Botella <abot...@igalia.com>

Comment-In-Reply-To: Ian Kilpatrick <ikilp...@chromium.org>

[Andreu Botella (Gerrit)]

Attention needed from Ian Kilpatrick

Andreu Botella added 1 comment

File third_party/blink/renderer/core/css/css_properties.json5

Line 7361, Patchset 2: type_name: "int",

Ian Kilpatrick . resolved

It might be better to represent this as std::optional<int> rather than have the additional field.

Andreu Botella

`std:optional<int>` can't represent clamping by both lines and height (e.g. `max-lines: 3 auto`).

Ian Kilpatrick

Ah I see - so for something which likely isn't going to be set that much i'd marginally prefer something like:
third_party/blink/renderer/core/style/text_overflow_data.h

(then don't have to write all the inheritance logic etc)

Andreu Botella

Done.

Open in Gerrit

Related details

Attention is currently required from:

• Ian Kilpatrick

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5d639d36cc70f94148e33028b1faabb54cfd2393

Gerrit-Change-Number: 7798160

Gerrit-PatchSet: 4

Gerrit-Owner: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Comment-Date: Wed, 06 May 2026 15:07:16 +0000

[Ian Kilpatrick (Gerrit)]

Attention needed from Andreu Botella

Ian Kilpatrick added 2 comments

File third_party/blink/renderer/core/style/max_lines_data.h

Line 48, Patchset 4 (Latest): int data_;

Ian Kilpatrick . unresolved

So I would rather make this explicit.

e.g. either
```
unsigned lines_ : kLineBits;
unsigned has_auto_ : 1;
```

with this variant you'll need to do `ClampTo<unsigned>(num, 0, 1 << kLineBits)`

or (perhaps preferred)

```
uint16_t lines_;
bool has_auto_;
```

Line 25, Patchset 4 (Latest): explicit MaxLinesData(int lines, bool has_auto = false) {

Ian Kilpatrick . unresolved

```suggestion
  MaxLinesData(int lines, bool has_auto) {
```

the optional arg variant doesn't appear to be used.

Open in Gerrit

Related details

Attention is currently required from:

• Andreu Botella

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5d639d36cc70f94148e33028b1faabb54cfd2393

Gerrit-Change-Number: 7798160

Gerrit-PatchSet: 4

Gerrit-Owner: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andreu Botella <abot...@igalia.com>

Gerrit-Comment-Date: Wed, 06 May 2026 16:31:48 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Andreu Botella (Gerrit)]

Attention needed from Ian Kilpatrick

Andreu Botella added 1 comment

File third_party/blink/renderer/core/style/max_lines_data.h

Line 48, Patchset 4: int data_;

Ian Kilpatrick . resolved

So I would rather make this explicit.

e.g. either
```
unsigned lines_ : kLineBits;
unsigned has_auto_ : 1;
```

with this variant you'll need to do `ClampTo<unsigned>(num, 0, 1 << kLineBits)`

or (perhaps preferred)

```
uint16_t lines_;
bool has_auto_;
```

Andreu Botella

Done

Open in Gerrit

Related details

Attention is currently required from:

• Ian Kilpatrick

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5d639d36cc70f94148e33028b1faabb54cfd2393

Gerrit-Change-Number: 7798160

Gerrit-PatchSet: 5

Gerrit-Owner: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Comment-Date: Wed, 06 May 2026 21:36:04 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ian Kilpatrick <ikilp...@chromium.org>

[Ian Kilpatrick (Gerrit)]

Attention needed from Andreu Botella

Ian Kilpatrick voted and added 3 comments

Votes added by Ian Kilpatrick

Code-Review

+1

3 comments

File third_party/blink/renderer/core/css/properties/shorthands/shorthands_custom.cc

Line 5231, Patchset 5 (Latest): num_lines = css_parsing_utils::ConsumePositiveInteger(stream, context,

Ian Kilpatrick . unresolved

likely want:
```
css_parsing_utils::ConsumeIntegerOrNumberCalc(
      stream, context, local_context,
      CSSPrimitiveValue::ValueRange::kPositiveInteger);
```
      
so that `line-clamp: round(up, calc(7/2))` works.

File third_party/blink/renderer/core/css/resolver/style_builder_converter.cc

Line 4284, Patchset 5 (Latest): ClampTo<uint16_t>(ConvertInteger(state, *num_lines_value)), has_auto);

Ian Kilpatrick . unresolved

`To<CSSPrimitiveValue>(num_lines_value).ConvertTo<uint16_t>(state.CssToLengthConversionData())`

File third_party/blink/renderer/core/style/max_lines_data.h

Line 25, Patchset 4: explicit MaxLinesData(int lines, bool has_auto = false) {

Ian Kilpatrick . resolved

```suggestion
  MaxLinesData(int lines, bool has_auto) {
```

the optional arg variant doesn't appear to be used.

Ian Kilpatrick

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

• Andreu Botella

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5d639d36cc70f94148e33028b1faabb54cfd2393

Gerrit-Change-Number: 7798160

Gerrit-PatchSet: 5

Gerrit-Owner: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andreu Botella <abot...@igalia.com>

Gerrit-Comment-Date: Wed, 06 May 2026 21:57:21 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Ian Kilpatrick <ikilp...@chromium.org>

[Andreu Botella (Gerrit)]

Attention needed from Ian Kilpatrick

Andreu Botella added 2 comments

File third_party/blink/renderer/core/css/properties/shorthands/shorthands_custom.cc

Line 5231, Patchset 5: num_lines = css_parsing_utils::ConsumePositiveInteger(stream, context,

Ian Kilpatrick . unresolved

likely want:
```
css_parsing_utils::ConsumeIntegerOrNumberCalc(
      stream, context, local_context,
      CSSPrimitiveValue::ValueRange::kPositiveInteger);
```
      
so that `line-clamp: round(up, calc(7/2))` works.

Andreu Botella

`ConsumePositiveInteger` does support math functions.

File third_party/blink/renderer/core/css/resolver/style_builder_converter.cc

Line 4284, Patchset 5: ClampTo<uint16_t>(ConvertInteger(state, *num_lines_value)), has_auto);

Ian Kilpatrick . resolved

`To<CSSPrimitiveValue>(num_lines_value).ConvertTo<uint16_t>(state.CssToLengthConversionData())`

Andreu Botella

Done

Open in Gerrit

Related details

Attention is currently required from:

• Ian Kilpatrick

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5d639d36cc70f94148e33028b1faabb54cfd2393

Gerrit-Change-Number: 7798160

Gerrit-PatchSet: 6

Gerrit-Owner: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Comment-Date: Thu, 07 May 2026 14:01:17 +0000

[Ian Kilpatrick (Gerrit)]

Attention needed from Andreu Botella

Ian Kilpatrick voted and added 1 comment

Votes added by Ian Kilpatrick

Code-Review

+1

1 comment

File third_party/blink/renderer/core/css/properties/shorthands/shorthands_custom.cc

Line 5231, Patchset 5: num_lines = css_parsing_utils::ConsumePositiveInteger(stream, context,

Ian Kilpatrick . resolved

likely want:
```
css_parsing_utils::ConsumeIntegerOrNumberCalc(
      stream, context, local_context,
      CSSPrimitiveValue::ValueRange::kPositiveInteger);
```
      
so that `line-clamp: round(up, calc(7/2))` works.

Andreu Botella

`ConsumePositiveInteger` does support math functions.

Ian Kilpatrick

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

• Andreu Botella

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5d639d36cc70f94148e33028b1faabb54cfd2393

Gerrit-Change-Number: 7798160

Gerrit-PatchSet: 6

Gerrit-Owner: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andreu Botella <abot...@igalia.com>

Gerrit-Comment-Date: Thu, 07 May 2026 17:51:17 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Blink W3C Test Autoroller (Gerrit)]

Attention needed from Andreu Botella

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/59735.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention is currently required from:

• Andreu Botella

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5d639d36cc70f94148e33028b1faabb54cfd2393

Gerrit-Change-Number: 7798160

Gerrit-PatchSet: 6

Gerrit-Owner: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andreu Botella <abot...@igalia.com>

Gerrit-Comment-Date: Thu, 07 May 2026 18:07:56 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Andreu Botella (Gerrit)]

Andreu Botella voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5d639d36cc70f94148e33028b1faabb54cfd2393

Gerrit-Change-Number: 7798160

Gerrit-PatchSet: 6

Gerrit-Owner: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Thu, 07 May 2026 18:09:01 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Andreu Botella (Gerrit)]

Andreu Botella added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Andreu Botella . resolved

I haven't been able to reproduce this failure, but it seems to be consistent, so I'll take a look.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5d639d36cc70f94148e33028b1faabb54cfd2393

Gerrit-Change-Number: 7798160

Gerrit-PatchSet: 6

Gerrit-Owner: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Andreu Botella <abot...@igalia.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Thu, 07 May 2026 19:25:08 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No