Track line-height units properly for container queries [chromium/src : main]

0 views
Skip to first unread message

Rune Lillesveen (Gerrit)

unread,
Jun 26, 2026, 12:56:01 PMJun 26
to Rune Lillesveen, Anders Hartvoll Ruud, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Kenneth Rohde Christiansen, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Anders Hartvoll Ruud

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Anders Hartvoll Ruud
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1b7bccb15a10faf1679e126844d0a544347322b5
Gerrit-Change-Number: 8011494
Gerrit-PatchSet: 1
Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Jun 2026 16:55:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Anders Hartvoll Ruud (Gerrit)

unread,
Jul 1, 2026, 4:11:32 AMJul 1
to Rune Lillesveen, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Kenneth Rohde Christiansen, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Rune Lillesveen

Anders Hartvoll Ruud added 2 comments

File third_party/blink/renderer/core/css/container_query_evaluator.cc
Line 357, Patchset 1: if ((unit_flags_ & MediaQueryExpValue::UnitFlags::kRootRelative) == 0) {
Anders Hartvoll Ruud . unresolved

I think we need to look at the _incoming_ flags?

```suggestion
  if ((result.unit_flags & MediaQueryExpValue::UnitFlags::kRootRelative) != 0) {
```
Line 361, Patchset 1: if ((unit_flags_ & MediaQueryExpValue::UnitFlags::kLineHeightRelative) == 0) {
Anders Hartvoll Ruud . unresolved

Here too.

Open in Gerrit

Related details

Attention is currently required from:
  • Rune Lillesveen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1b7bccb15a10faf1679e126844d0a544347322b5
    Gerrit-Change-Number: 8011494
    Gerrit-PatchSet: 2
    Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Comment-Date: Wed, 01 Jul 2026 08:11:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rune Lillesveen (Gerrit)

    unread,
    Jul 20, 2026, 9:47:17 AM (8 days ago) Jul 20
    to Rune Lillesveen, Anders Hartvoll Ruud, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Kenneth Rohde Christiansen, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
    Attention needed from Anders Hartvoll Ruud

    Rune Lillesveen voted and added 2 comments

    Votes added by Rune Lillesveen

    Commit-Queue+0

    2 comments

    File third_party/blink/renderer/core/css/container_query_evaluator.cc
    Line 357, Patchset 1: if ((unit_flags_ & MediaQueryExpValue::UnitFlags::kRootRelative) == 0) {
    Anders Hartvoll Ruud . resolved

    I think we need to look at the _incoming_ flags?

    ```suggestion
      if ((result.unit_flags & MediaQueryExpValue::UnitFlags::kRootRelative) != 0) {
    ```
    Rune Lillesveen

    Done

    Line 361, Patchset 1: if ((unit_flags_ & MediaQueryExpValue::UnitFlags::kLineHeightRelative) == 0) {
    Anders Hartvoll Ruud . resolved

    Here too.

    Rune Lillesveen

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Anders Hartvoll Ruud
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1b7bccb15a10faf1679e126844d0a544347322b5
      Gerrit-Change-Number: 8011494
      Gerrit-PatchSet: 3
      Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
      Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Comment-Date: Mon, 20 Jul 2026 13:47:00 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Anders Hartvoll Ruud <and...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Morten Stenshorne (Gerrit)

      unread,
      Jul 21, 2026, 4:45:25 AM (8 days ago) Jul 21
      to Rune Lillesveen, Anders Hartvoll Ruud, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Kenneth Rohde Christiansen, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
      Attention needed from Anders Hartvoll Ruud and Rune Lillesveen

      Morten Stenshorne voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Anders Hartvoll Ruud
      • Rune Lillesveen
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I1b7bccb15a10faf1679e126844d0a544347322b5
        Gerrit-Change-Number: 8011494
        Gerrit-PatchSet: 4
        Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
        Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
        Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
        Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
        Gerrit-CC: Menard, Alexis <alexis...@intel.com>
        Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
        Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
        Gerrit-Comment-Date: Tue, 21 Jul 2026 08:45:08 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Jul 21, 2026, 4:55:13 AM (8 days ago) Jul 21
        to Rune Lillesveen, Morten Stenshorne, Anders Hartvoll Ruud, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Kenneth Rohde Christiansen, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        Track line-height units properly for container queries

        This fixes rlh unit invalidation issues for style() container queries

        Bug: 524390004
        Change-Id: I1b7bccb15a10faf1679e126844d0a544347322b5
        Commit-Queue: Rune Lillesveen <fut...@chromium.org>
        Reviewed-by: Morten Stenshorne <mste...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1665286}
        Files:
        • M third_party/blink/renderer/core/css/container_query_evaluator.cc
        • M third_party/blink/renderer/core/css/media_query_evaluator.cc
        • M third_party/blink/renderer/core/css/media_query_exp.cc
        • M third_party/blink/renderer/core/css/media_query_exp.h
        • M third_party/blink/renderer/core/css/media_query_exp_test.cc
        • M third_party/blink/renderer/core/css/resolver/match_result.h
        • M third_party/blink/renderer/core/css/resolver/style_resolver.cc
        • M third_party/blink/renderer/core/style/computed_style.h
        • M third_party/blink/renderer/core/style/computed_style_extra_fields.json5
        • M third_party/blink/web_tests/external/wpt/css/css-conditional/container-queries/style-range-dynamic-expected.txt
        Change size: M
        Delta: 10 files changed, 57 insertions(+), 41 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Morten Stenshorne
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I1b7bccb15a10faf1679e126844d0a544347322b5
        Gerrit-Change-Number: 8011494
        Gerrit-PatchSet: 5
        Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
        Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages