Add text-decoration-inset style support in Blink [chromium/src : main]

[Fredrik Söderquist (Gerrit)]

Attention needed from Helmut Januschka

Fredrik Söderquist added 5 comments

File third_party/blink/renderer/core/css/css_computed_style_declaration.cc

Line 412, Patchset 9 (Latest): if (element_ != element_->GetDocument().documentElement() &&
!FlatTreeTraversal::ParentElement(*element_)) {
return 0;
}

Fredrik Söderquist . unresolved

This doesn't look like it belongs in this CL

File third_party/blink/renderer/core/css/resolver/style_builder_converter.cc

Line 3189, Patchset 9 (Latest): const CSSValuePair& pair = To<CSSValuePair>(value);

Fredrik Söderquist . unresolved

```suggestion
  const auto& pair = To<CSSValuePair>(value);
```

File third_party/blink/renderer/core/style/applied_text_decoration.h

Line 28, Patchset 9 (Latest): TextDecorationInset = TextDecorationInset(),
EBoxDecorationBreak = EBoxDecorationBreak::kSlice);

Fredrik Söderquist . unresolved

Not using default arguments for any of the other, and their generally discourage, so don't see why these new arguments should have them?

File third_party/blink/renderer/core/style/applied_text_decoration.cc

Line 26, Patchset 9 (Latest):bool AppliedTextDecoration::operator==(const AppliedTextDecoration& o) const {
return color_ == o.color_ && lines_ == o.lines_ && style_ == o.style_ &&
box_decoration_break_ == o.box_decoration_break_ &&
thickness_ == o.thickness_ &&
underline_offset_ == o.underline_offset_ &&
decoration_inset_ == o.decoration_inset_;

Fredrik Söderquist . unresolved

This could probably be defaulted instead?

File third_party/blink/renderer/core/style/text_decoration_inset.h

Line 23, Patchset 9 (Latest): bool operator==(const TextDecorationInset& o) const {
return start_ == o.start_ && end_ == o.end_;
}


Fredrik Söderquist . unresolved

`... = default` ?

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4f4e57544b8485a5c75dc6e119d3d59745b5e715

Gerrit-Change-Number: 7993418

Gerrit-PatchSet: 9

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Comment-Date: Tue, 28 Jul 2026 14:03:26 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No