Javier Fernandez (Gerrit)

unread,

Sep 17, 2025, 7:36:50 AM (14 days ago) Sep 17

to Anders Hartvoll Ruud, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Attention needed from Anders Hartvoll Ruud

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Anders Hartvoll Ruud

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

一丝 (Gerrit)

unread,

Sep 17, 2025, 9:09:23 AM (14 days ago) Sep 17

to Javier Fernandez, Anders Hartvoll Ruud, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Attention needed from Anders Hartvoll Ruud and Javier Fernandez

一丝 added 1 comment

Commit Message

Line 12, Patchset 7 (Latest):"shape-outside", "cursor" and "-webkit-mask-box-image".

一丝 . unresolved

Should we consider the `mask-image`?

Open in Gerrit

Related details

Attention is currently required from:

Anders Hartvoll Ruud
Javier Fernandez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Javier Fernandez (Gerrit)

unread,

Sep 17, 2025, 10:36:57 AM (14 days ago) Sep 17

to 一丝, Anders Hartvoll Ruud, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Attention needed from Anders Hartvoll Ruud and 一丝

Javier Fernandez added 1 comment

Commit Message

Line 12, Patchset 7 (Latest):"shape-outside", "cursor" and "-webkit-mask-box-image".

一丝 . unresolved

Should we consider the `mask-image`?

Javier Fernandez

The mask-image property uses the CSSToStykeMap::MapFillImage codepath, which already applies the ResolveGradient function, introduced in the previous CL #6676851.

Anyway, I'll add new WPT test cases in this CL.

Open in Gerrit

Related details

Attention is currently required from:

Anders Hartvoll Ruud
一丝

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

一丝 (Gerrit)

unread,

Sep 17, 2025, 11:01:57 AM (14 days ago) Sep 17

to Javier Fernandez, Anders Hartvoll Ruud, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Attention needed from Anders Hartvoll Ruud and Javier Fernandez

一丝 added 1 comment

Commit Message

Line 12, Patchset 7:"shape-outside", "cursor" and "-webkit-mask-box-image".

一丝 . unresolved

Should we consider the `mask-image`?

Javier Fernandez

The mask-image property uses the CSSToStykeMap::MapFillImage codepath, which already applies the ResolveGradient function, introduced in the previous CL #6676851.
Anyway, I'll add new WPT test cases in this CL.

一丝

Nice!

Open in Gerrit

Related details

Attention is currently required from:

Anders Hartvoll Ruud
Javier Fernandez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Anders Hartvoll Ruud (Gerrit)

unread,

Sep 18, 2025, 7:07:21 AM (13 days ago) Sep 18

to Javier Fernandez, 一丝, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Attention needed from Javier Fernandez

Anders Hartvoll Ruud voted and added 1 comment

Votes added by Anders Hartvoll Ruud

Code-Review

+1

1 comment

File third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc

Line 1600, Patchset 9 (Latest): state.GetStyleImage(CSSPropertyID::kBorderImageSource, resolved_value));

Anders Hartvoll Ruud . unresolved

Should `GetStyleImage()` ultimately do this instead?

Open in Gerrit

Related details

Attention is currently required from:

Javier Fernandez

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Javier Fernandez (Gerrit)

unread,

Sep 18, 2025, 9:31:55 AM (13 days ago) Sep 18

to Anders Hartvoll Ruud, 一丝, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Attention needed from Anders Hartvoll Ruud

Javier Fernandez added 2 comments

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Javier Fernandez . resolved

Thanks for the review.
See my reply inline.

File third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc

Line 1600, Patchset 9 (Latest): state.GetStyleImage(CSSPropertyID::kBorderImageSource, resolved_value));

Anders Hartvoll Ruud . unresolved

Should `GetStyleImage()` ultimately do this instead?

Javier Fernandez

Good question ! That was precisely the first version of my patch. However, given that there is a FIXME in that function suggesting that it will be eventually removed, I decided to avoid that approach.

Additionally, I thought that doing it explicitly for each css property would be clearer.

I could get back the original approach if you thing it's better. The patch would be simpler, indeed.

Open in Gerrit

Related details

Attention is currently required from:

Anders Hartvoll Ruud

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Javier Fernandez (Gerrit)

unread,

Sep 18, 2025, 4:37:08 PM (12 days ago) Sep 18

to Anders Hartvoll Ruud, 一丝, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Attention needed from Anders Hartvoll Ruud and 一丝

Javier Fernandez added 1 comment

Commit Message

Line 12, Patchset 7:"shape-outside", "cursor" and "-webkit-mask-box-image".

一丝 . resolved

Should we consider the `mask-image`?

Javier Fernandez

The mask-image property uses the CSSToStykeMap::MapFillImage codepath, which already applies the ResolveGradient function, introduced in the previous CL #6676851.
Anyway, I'll add new WPT test cases in this CL.

一丝

Nice!

Javier Fernandez

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

Anders Hartvoll Ruud
一丝

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Anders Hartvoll Ruud (Gerrit)

unread,

Sep 19, 2025, 8:53:20 AM (12 days ago) Sep 19

to Javier Fernandez, 一丝, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Attention needed from Javier Fernandez and 一丝

Anders Hartvoll Ruud added 1 comment

File third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc

Line 1600, Patchset 9 (Latest): state.GetStyleImage(CSSPropertyID::kBorderImageSource, resolved_value));

Anders Hartvoll Ruud . unresolved

Should `GetStyleImage()` ultimately do this instead?

Javier Fernandez

Good question ! That was precisely the first version of my patch. However, given that there is a FIXME in that function suggesting that it will be eventually removed, I decided to avoid that approach.
Additionally, I thought that doing it explicitly for each css property would be clearer.
I could get back the original approach if you thing it's better. The patch would be simpler, indeed.

Anders Hartvoll Ruud

Yeah, I think it's better to do it in a single place. Just remove the FIXME; it's not sacred.

Open in Gerrit

Related details

Attention is currently required from:

Javier Fernandez
一丝

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Javier Fernandez (Gerrit)

unread,

Sep 21, 2025, 4:02:42 PM (9 days ago) Sep 21

to Anders Hartvoll Ruud, 一丝, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Attention needed from Anders Hartvoll Ruud and 一丝

Javier Fernandez added 1 comment

File third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc

Line 1600, Patchset 9: state.GetStyleImage(CSSPropertyID::kBorderImageSource, resolved_value));

Anders Hartvoll Ruud . resolved

Should `GetStyleImage()` ultimately do this instead?

Javier Fernandez

Good question ! That was precisely the first version of my patch. However, given that there is a FIXME in that function suggesting that it will be eventually removed, I decided to avoid that approach.
Additionally, I thought that doing it explicitly for each css property would be clearer.
I could get back the original approach if you thing it's better. The patch would be simpler, indeed.

Anders Hartvoll Ruud

Yeah, I think it's better to do it in a single place. Just remove the FIXME; it's not sacred.

Javier Fernandez

Done

Open in Gerrit

Related details

Attention is currently required from:

Anders Hartvoll Ruud
一丝

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Anders Hartvoll Ruud (Gerrit)

unread,

Sep 22, 2025, 3:24:23 AM (9 days ago) Sep 22

to Javier Fernandez, 一丝, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Attention needed from Javier Fernandez and 一丝

Anders Hartvoll Ruud voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Javier Fernandez
一丝

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Javier Fernandez (Gerrit)

unread,

Sep 22, 2025, 4:00:21 AM (9 days ago) Sep 22

to Anders Hartvoll Ruud, 一丝, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Attention needed from 一丝

Javier Fernandez voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

一丝

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Sep 22, 2025, 4:58:10 AM (9 days ago) Sep 22

to Javier Fernandez, Anders Hartvoll Ruud, 一丝, AyeAye, Alexis Menard, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Apply the CSSGradientValue resolution to other properties

This change calls to the ResolveGradient function for several CSS
properties that accept CSSGRadientValues as <image> values. These
properties are "border-image-source", "list-style-image", "content",


"shape-outside", "cursor" and "-webkit-mask-box-image".

It's worth mentioning that the "cursor" property doesn't support <image>
values yet as <cursor-image>, although it's specified [1], just <url> or
<url-set>. That's why the new WPT tests have failure expectations for
now.

The failures expectations of the shape-outside test cases are related to
the issue #40468636 or a subset of it. The problem is that chrome
serializes 50% as center, when it should use a <LengthPercentage> as
computed value.

[1] https://drafts.csswg.org/css-ui-4/#typedef-cursor-cursor-image

Bug: 40620723

Change-Id: I7df1712902bb505492f667bb4578b4ef36b5cf76

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6722514

Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>

Commit-Queue: Javier Fernandez <jfern...@igalia.com>

Cr-Commit-Position: refs/heads/main@{#1518568}

Files:

M third_party/blink/renderer/core/css/resolver/css_to_style_map.cc
M third_party/blink/renderer/core/css/resolver/style_resolver_state.h
M third_party/blink/web_tests/external/wpt/css/css-backgrounds/parsing/border-image-source-computed.sub.html
M third_party/blink/web_tests/external/wpt/css/css-content/parsing/content-computed.html
D third_party/blink/web_tests/external/wpt/css/css-lists/parsing/list-style-image-computed.sub-expected.txt
M third_party/blink/web_tests/external/wpt/css/css-lists/parsing/list-style-image-computed.sub.html
M third_party/blink/web_tests/external/wpt/css/css-masking/parsing/mask-computed.html
A third_party/blink/web_tests/external/wpt/css/css-shapes/shape-outside/values/shape-outside-gradient-computed-expected.txt
A third_party/blink/web_tests/external/wpt/css/css-shapes/shape-outside/values/shape-outside-gradient-computed.html
A third_party/blink/web_tests/external/wpt/css/css-ui/parsing/cursor-computed-expected.txt
M third_party/blink/web_tests/external/wpt/css/css-ui/parsing/cursor-computed.html
A third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-mask-box-image-expected.txt
A third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-mask-box-image.html

Change size: M

Delta: 13 files changed, 116 insertions(+), 15 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Anders Hartvoll Ruud

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Blink W3C Test Autoroller (Gerrit)

unread,

Sep 22, 2025, 5:45:43 AM (9 days ago) Sep 22

to Chromium LUCI CQ, Javier Fernandez, Anders Hartvoll Ruud, 一丝, AyeAye, Alexis Menard, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/54972

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Apply the CSSGradientValue resolution to other properties [chromium/src : main]

Javier Fernandez (Gerrit)

New activity on the change

Related details

一丝 (Gerrit)

一丝 added 1 comment

Related details

Javier Fernandez (Gerrit)

Javier Fernandez added 1 comment

Related details

一丝 (Gerrit)

一丝 added 1 comment

Related details

Anders Hartvoll Ruud (Gerrit)

Anders Hartvoll Ruud voted and added 1 comment

Votes added by Anders Hartvoll Ruud

1 comment

Related details

Javier Fernandez (Gerrit)

Javier Fernandez added 2 comments

Related details

Javier Fernandez (Gerrit)

Javier Fernandez added 1 comment

Related details

Anders Hartvoll Ruud (Gerrit)

Anders Hartvoll Ruud added 1 comment

Related details

Javier Fernandez (Gerrit)

Javier Fernandez added 1 comment

Related details

Anders Hartvoll Ruud (Gerrit)

Anders Hartvoll Ruud voted Code-Review+1

Related details

Javier Fernandez (Gerrit)

Javier Fernandez voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Blink W3C Test Autoroller (Gerrit)

Message from Blink W3C Test Autoroller

Related details