Rename ImageResourceContent::IsAccessAllowed() to IsCorsSameOrigin() [chromium/src : main]

0 views
Skip to first unread message

Fredrik Söderquist (Gerrit)

unread,
Apr 17, 2026, 9:11:35 AM (yesterday) Apr 17
to Stephen Chenney, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Nate Chapin, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, kouhe...@chromium.org, loading...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Attention needed from Stephen Chenney

Fredrik Söderquist voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Stephen Chenney
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I63d3d73bf70f58d26ecd0868b9062bbbe36e11a7
Gerrit-Change-Number: 7772809
Gerrit-PatchSet: 1
Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Stephen Chenney <sche...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Apr 2026 13:11:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Stephen Chenney (Gerrit)

unread,
Apr 17, 2026, 10:07:00 AM (yesterday) Apr 17
to Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Nate Chapin, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, kouhe...@chromium.org, loading...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Attention needed from Fredrik Söderquist

Stephen Chenney voted and added 1 comment

Votes added by Stephen Chenney

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Stephen Chenney . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I63d3d73bf70f58d26ecd0868b9062bbbe36e11a7
    Gerrit-Change-Number: 7772809
    Gerrit-PatchSet: 1
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
    Gerrit-Comment-Date: Fri, 17 Apr 2026 14:06:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 17, 2026, 10:26:35 AM (yesterday) Apr 17
    to Fredrik Söderquist, Stephen Chenney, chromium...@chromium.org, Dirk Schulze, Nate Chapin, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, kouhe...@chromium.org, loading...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Rename ImageResourceContent::IsAccessAllowed() to IsCorsSameOrigin()

    Better reflects the meaning of the flag (bottoms out at
    ResourceResponse::IsCorsSameOrigin()).

    Also renames the lower level function on ImageResourceInfo.
    Change-Id: I63d3d73bf70f58d26ecd0868b9062bbbe36e11a7
    Commit-Queue: Stephen Chenney <sche...@chromium.org>
    Auto-Submit: Fredrik Söderquist <f...@opera.com>
    Reviewed-by: Stephen Chenney <sche...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1616536}
    Files:
    • M third_party/blink/renderer/core/clipboard/data_transfer.cc
    • M third_party/blink/renderer/core/html/canvas/image_element_base.cc
    • M third_party/blink/renderer/core/layout/layout_image_resource.cc
    • M third_party/blink/renderer/core/loader/resource/image_resource.cc
    • M third_party/blink/renderer/core/loader/resource/image_resource.h
    • M third_party/blink/renderer/core/loader/resource/image_resource_content.cc
    • M third_party/blink/renderer/core/loader/resource/image_resource_content.h
    • M third_party/blink/renderer/core/loader/resource/image_resource_info.h
    • M third_party/blink/renderer/core/style/style_fetched_image.cc
    • M third_party/blink/renderer/core/svg/svg_fe_image_element.cc
    Change size: S
    Delta: 10 files changed, 22 insertions(+), 21 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Stephen Chenney
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I63d3d73bf70f58d26ecd0868b9062bbbe36e11a7
    Gerrit-Change-Number: 7772809
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages