[cleanup] Remove StyleDifference::NeedsLayout [chromium/src : main]

0 views
Skip to first unread message

Ian Kilpatrick (Gerrit)

unread,
Feb 4, 2026, 8:51:07 AM (9 days ago) Feb 4
to Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Morten Stenshorne

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Morten Stenshorne
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib620fa78bc3c963477948418b3ca81b24ce59f31
Gerrit-Change-Number: 7535212
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
Gerrit-Comment-Date: Wed, 04 Feb 2026 13:50:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Morten Stenshorne (Gerrit)

unread,
Feb 4, 2026, 9:00:51 AM (9 days ago) Feb 4
to Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick

Morten Stenshorne voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib620fa78bc3c963477948418b3ca81b24ce59f31
    Gerrit-Change-Number: 7535212
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Comment-Date: Wed, 04 Feb 2026 14:00:37 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Ian Kilpatrick (Gerrit)

    unread,
    Feb 4, 2026, 9:12:09 AM (9 days ago) Feb 4
    to Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Ian Kilpatrick voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib620fa78bc3c963477948418b3ca81b24ce59f31
    Gerrit-Change-Number: 7535212
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-Comment-Date: Wed, 04 Feb 2026 14:11:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 4, 2026, 9:40:27 AM (9 days ago) Feb 4
    to Ian Kilpatrick, Morten Stenshorne, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [cleanup] Remove StyleDifference::NeedsLayout

    This method was prone to misuse. Most of the callsites should have been
    checking NeedsFullLayout instead.

    Remove so that the sutble over-invalidations don't get introduced.

    There should be no behaviour change.
    Change-Id: Ib620fa78bc3c963477948418b3ca81b24ce59f31
    Reviewed-by: Morten Stenshorne <mste...@chromium.org>
    Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1579413}
    Files:
    • M third_party/blink/renderer/core/layout/grid/layout_grid.cc
    • M third_party/blink/renderer/core/layout/layout_custom_scrollbar_part.cc
    • M third_party/blink/renderer/core/layout/layout_object.cc
    • M third_party/blink/renderer/core/layout/table/layout_table_column.cc
    • M third_party/blink/renderer/core/style/computed_style.cc
    • M third_party/blink/renderer/core/style/style_difference.h
    Change size: S
    Delta: 6 files changed, 10 insertions(+), 17 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Morten Stenshorne
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib620fa78bc3c963477948418b3ca81b24ce59f31
    Gerrit-Change-Number: 7535212
    Gerrit-PatchSet: 3
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages