[cleanup] Remove StyleDifference::NeedsLayout [chromium/src : main]
0 views
Skip to first unread message
Ian Kilpatrick (Gerrit)
Feb 4, 2026, 8:51:07 AM (9 days ago) Feb 4
to Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Morten Stenshorne
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Morten Stenshorne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Morten Stenshorne (Gerrit)
Feb 4, 2026, 9:00:51 AM (9 days ago) Feb 4
to Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick
Morten Stenshorne voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
Feb 4, 2026, 9:12:09 AM (9 days ago) Feb 4
to Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Ian Kilpatrick voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 4, 2026, 9:40:27 AM (9 days ago) Feb 4
to Ian Kilpatrick, Morten Stenshorne, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[cleanup] Remove StyleDifference::NeedsLayout
This method was prone to misuse. Most of the callsites should have been
checking NeedsFullLayout instead.
Remove so that the sutble over-invalidations don't get introduced.
There should be no behaviour change.
Change-Id: Ib620fa78bc3c963477948418b3ca81b24ce59f31
Reviewed-by: Morten Stenshorne <mste...@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1579413}
Files:
- M third_party/blink/renderer/core/layout/grid/layout_grid.cc
- M third_party/blink/renderer/core/layout/layout_custom_scrollbar_part.cc
- M third_party/blink/renderer/core/layout/layout_object.cc
- M third_party/blink/renderer/core/layout/table/layout_table_column.cc
- M third_party/blink/renderer/core/style/computed_style.cc
- M third_party/blink/renderer/core/style/style_difference.h
Change size: S
Delta: 6 files changed, 10 insertions(+), 17 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Morten Stenshorne
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages