Revert "[web-tests] Lint VirtualTestSuites for formatting" [chromium/src : main]

0 views
Skip to first unread message

Jonathan Lee (Gerrit)

unread,
Sep 26, 2025, 4:10:47 PM (4 days ago) Sep 26
to Rubber Stamper, Chromium LUCI CQ, Philip Rogers, Jiamei Liu, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Jiamei Liu and Philip Rogers

Jonathan Lee voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jiamei Liu
  • Philip Rogers
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia8cc390f24252ffa56041df2a9aa1aa84d6bdf43
Gerrit-Change-Number: 6991218
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Jiamei Liu <jia...@google.com>
Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Attention: Jiamei Liu <jia...@google.com>
Gerrit-Comment-Date: Fri, 26 Sep 2025 20:10:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Sep 26, 2025, 4:11:21 PM (4 days ago) Sep 26
to Jonathan Lee, Chromium LUCI CQ, Philip Rogers, Jiamei Liu, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Jiamei Liu and Philip Rogers

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jiamei Liu
  • Philip Rogers
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia8cc390f24252ffa56041df2a9aa1aa84d6bdf43
    Gerrit-Change-Number: 6991218
    Gerrit-PatchSet: 1
    Gerrit-Owner: Jonathan Lee <jonath...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jiamei Liu <jia...@google.com>
    Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Attention: Jiamei Liu <jia...@google.com>
    Gerrit-Comment-Date: Fri, 26 Sep 2025 20:11:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ian Wells (Gerrit)

    unread,
    Sep 26, 2025, 4:25:12 PM (4 days ago) Sep 26
    to Jonathan Lee, Rubber Stamper, Chromium LUCI CQ, Philip Rogers, Jiamei Liu, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org
    Attention needed from Jiamei Liu, Jonathan Lee and Philip Rogers

    Ian Wells voted

    Code-Review+1
    Commit-Queue+2
    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jiamei Liu
    • Jonathan Lee
    • Philip Rogers
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia8cc390f24252ffa56041df2a9aa1aa84d6bdf43
    Gerrit-Change-Number: 6991218
    Gerrit-PatchSet: 1
    Gerrit-Owner: Jonathan Lee <jonath...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Ian Wells <iwe...@chromium.org>
    Gerrit-Reviewer: Jiamei Liu <jia...@google.com>
    Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Attention: Jonathan Lee <jonath...@google.com>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Attention: Jiamei Liu <jia...@google.com>
    Gerrit-Comment-Date: Fri, 26 Sep 2025 20:25:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 26, 2025, 5:10:16 PM (4 days ago) Sep 26
    to Jonathan Lee, Ian Wells, Rubber Stamper, Philip Rogers, Jiamei Liu, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "[web-tests] Lint VirtualTestSuites for formatting"

    This reverts commit 4e02bcf24befea9f5af207aec50260b3250489e9.

    Reason for revert: Seems to incorrectly block CLs

    Original change's description:
    > [web-tests] Lint VirtualTestSuites for formatting
    >
    > 1. Upload script to sort the VirtualTestSuites
    > 2. Sort the current VirtualTestSuites.
    > 3. Add lint test against the VirtualTestSuites
    > using the sorting script.
    >
    > Script is from:
    > https://docs.google.com/document/d/13QRcFJaGywMJfOsxMNsfMwCG84rsLGQtF_YAxn154kg/edit?content_ref=sortable_items+sort+key+lambda+group+group+1+get+prefix&tab=t.0
    >
    > Change-Id: If7dbe2f0b5ceb7424aee7170a020da987286f50d
    > Bug: 424896700
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6962615
    > Reviewed-by: Jonathan Lee <jonath...@google.com>
    > Reviewed-by: Philip Rogers <p...@chromium.org>
    > Commit-Queue: Jiamei Liu <jia...@google.com>
    > Auto-Submit: Jiamei Liu <jia...@google.com>
    > Cr-Commit-Position: refs/heads/main@{#1520800}
    Bug: 424896700
    Change-Id: Ia8cc390f24252ffa56041df2a9aa1aa84d6bdf43
    Reviewed-by: Ian Wells <iwe...@chromium.org>
    Owners-Override: Ian Wells <iwe...@chromium.org>
    Auto-Submit: Jonathan Lee <jonath...@google.com>
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Commit-Queue: Ian Wells <iwe...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1521557}
    Files:
    • D third_party/blink/tools/blinkpy/style/virtual_suites_formatter.py
    • D third_party/blink/tools/blinkpy/style/virtual_suites_formatter_unittest.py
    • M third_party/blink/tools/blinkpy/web_tests/lint_test_expectations.py
    • M third_party/blink/tools/blinkpy/web_tests/lint_test_expectations_unittest.py
    • D third_party/blink/tools/format_virtual_test_suites.py
    • M third_party/blink/web_tests/VirtualTestSuites
    Change size: L
    Delta: 6 files changed, 103 insertions(+), 411 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Ian Wells, Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia8cc390f24252ffa56041df2a9aa1aa84d6bdf43
    Gerrit-Change-Number: 6991218
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement

    Jiamei Liu (Gerrit)

    unread,
    Sep 29, 2025, 4:12:30 PM (yesterday) Sep 29
    to Jonathan Lee, Chromium LUCI CQ, Ian Wells, Rubber Stamper, Philip Rogers, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org

    Jiamei Liu has created a revert of this change

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: revert
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages