Make initial-letter depend on font metrics [chromium/src : main]
0 views
Skip to first unread message
Rune Lillesveen (Gerrit)
Aug 22, 2025, 9:21:38 AMAug 22
to Rune Lillesveen, Koji Ishii, chromium...@chromium.org, AyeAye, blink-re...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Koji Ishii
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rune Lillesveen (Gerrit)
Aug 22, 2025, 9:21:38 AMAug 22
to Rune Lillesveen, Koji Ishii, chromium...@chromium.org, AyeAye, blink-re...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Koji Ishii
Rune Lillesveen voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 22, 2025, 10:25:56 AMAug 22
to Rune Lillesveen, Koji Ishii, chromium...@chromium.org, AyeAye, blink-re...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Make initial-letter depend on font metrics
The adjusted font size of the actual initial letter depends on font
selection for the ::first-letter. That means we need to force a style
recalc for the ::first-letter when web fonts finish loading.
Also, since the ComputedStyle will be the same, we need to force
applying changes for LayoutObject::SetStyle() so that the re-computation
of the initial letter style happens in
LayoutObject::SetPseudoElementStyle().
initial-letter-short-para-initial-letter-wraps.html still has a
regression from the local('Ahem') removal for some reason.
Bug: 431030816
Change-Id: I8d01fe7fb3ba9daee6ff73208476854573b6e051
Commit-Queue: Rune Lillesveen <fut...@chromium.org>
Reviewed-by: Koji Ishii <ko...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1505047}
Files:
- M third_party/blink/renderer/core/dom/element.cc
- M third_party/blink/renderer/core/style/computed_style.h
- M third_party/blink/web_tests/TestExpectations
Change size: M
Delta: 3 files changed, 9 insertions(+), 59 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Koji Ishii
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages