[Gap Decorations]: Update the default value of interior insets to 0 [chromium/src : main]

0 views
Skip to first unread message

Javier Contreras (Gerrit)

unread,
Feb 2, 2026, 6:35:42 PM (11 days ago) Feb 2
to Sam Davis Omekara, Kevin Babbitt, Alison Maher, Olga Gerchikov, Chromium LUCI CQ, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Alison Maher, Kevin Babbitt and Sam Davis Omekara

Javier Contreras voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alison Maher
  • Kevin Babbitt
  • Sam Davis Omekara
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0a9d802849c78c91d874f5de43616c2d58591712
Gerrit-Change-Number: 7533997
Gerrit-PatchSet: 7
Gerrit-Owner: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Javier Contreras <javi...@microsoft.com>
Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Reviewer: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Alison Maher <alm...@microsoft.com>
Gerrit-Attention: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-Attention: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Comment-Date: Mon, 02 Feb 2026 23:35:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kevin Babbitt (Gerrit)

unread,
Feb 2, 2026, 6:56:44 PM (11 days ago) Feb 2
to Sam Davis Omekara, Javier Contreras, Alison Maher, Olga Gerchikov, Chromium LUCI CQ, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Alison Maher and Sam Davis Omekara

Kevin Babbitt voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alison Maher
  • Sam Davis Omekara
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0a9d802849c78c91d874f5de43616c2d58591712
Gerrit-Change-Number: 7533997
Gerrit-PatchSet: 7
Gerrit-Owner: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Javier Contreras <javi...@microsoft.com>
Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Reviewer: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Alison Maher <alm...@microsoft.com>
Gerrit-Attention: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-Comment-Date: Mon, 02 Feb 2026 23:56:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Sam Davis Omekara (Gerrit)

unread,
Feb 2, 2026, 7:09:25 PM (11 days ago) Feb 2
to Kevin Babbitt, Javier Contreras, Alison Maher, Olga Gerchikov, Chromium LUCI CQ, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Alison Maher

Sam Davis Omekara voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Alison Maher
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0a9d802849c78c91d874f5de43616c2d58591712
Gerrit-Change-Number: 7533997
Gerrit-PatchSet: 7
Gerrit-Owner: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Javier Contreras <javi...@microsoft.com>
Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Reviewer: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Alison Maher <alm...@microsoft.com>
Gerrit-Comment-Date: Tue, 03 Feb 2026 00:09:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Blink W3C Test Autoroller (Gerrit)

unread,
Feb 2, 2026, 7:14:21 PM (11 days ago) Feb 2
to Sam Davis Omekara, Kevin Babbitt, Javier Contreras, Alison Maher, Olga Gerchikov, Chromium LUCI CQ, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Alison Maher

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57501.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention is currently required from:
  • Alison Maher
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0a9d802849c78c91d874f5de43616c2d58591712
Gerrit-Change-Number: 7533997
Gerrit-PatchSet: 7
Gerrit-Owner: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Javier Contreras <javi...@microsoft.com>
Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Reviewer: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Alison Maher <alm...@microsoft.com>
Gerrit-Comment-Date: Tue, 03 Feb 2026 00:14:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 2, 2026, 7:29:10 PM (11 days ago) Feb 2
to Sam Davis Omekara, Blink W3C Test Autoroller, Kevin Babbitt, Javier Contreras, Alison Maher, Olga Gerchikov, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[Gap Decorations]: Update the default value of interior insets to 0

This CL changes the default value for interior insets properties from
-50% to 0, in line with the resolution of csswg issue [1]. It also
updates the relevant test files. Two flex tests are incorrect and have
bugs, so these have been added to the TestExpectations files.

[1]: https://github.com/w3c/csswg-drafts/issues/13137
Bug: 357648037
Change-Id: I0a9d802849c78c91d874f5de43616c2d58591712
Commit-Queue: Sam Davis Omekara <samome...@microsoft.com>
Reviewed-by: Javier Contreras <javi...@microsoft.com>
Reviewed-by: Kevin Babbitt <kbab...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1578458}
Files:
  • M third_party/blink/renderer/core/css/css_properties.json5
  • M third_party/blink/web_tests/TestExpectations
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/agnostic/gap-decorations-002-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/animation/column-rule-outset-interpolation.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/animation/row-rule-outset-interpolation.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/flex/flex-gap-decorations-004-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/flex/flex-gap-decorations-005-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/flex/flex-gap-decorations-012-ref.html
  • A third_party/blink/web_tests/external/wpt/css/css-gaps/flex/flex-gap-decorations-022-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/flex/flex-gap-decorations-022.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/flex/flex-gap-decorations-029-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-001-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/fragmentation/grid-gap-decorations-fragmentation-008-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/grid-gap-decorations-006-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/grid-gap-decorations-009-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/grid-gap-decorations-011-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/grid-gap-decorations-015-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/grid-gap-decorations-038.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/grid-gap-decorations-040-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/grid-gap-decorations-052-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/grid-gap-decorations-057-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/subgrid/subgrid-gap-decorations-012-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/subgrid/subgrid-gap-decorations-013-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/subgrid/subgrid-gap-decorations-015-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/subgrid/subgrid-gap-decorations-016-ref.html
  • M third_party/blink/web_tests/external/wpt/css/css-gaps/grid/subgrid/subgrid-gap-decorations-017-ref.html
  • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
  • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
  • M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
Change size: L
Delta: 29 files changed, 235 insertions(+), 139 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Javier Contreras, +1 by Kevin Babbitt
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0a9d802849c78c91d874f5de43616c2d58591712
Gerrit-Change-Number: 7533997
Gerrit-PatchSet: 8
Gerrit-Owner: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Javier Contreras <javi...@microsoft.com>
Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Reviewer: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
open
diffy
satisfied_requirement

Blink W3C Test Autoroller (Gerrit)

unread,
Feb 2, 2026, 9:01:03 PM (11 days ago) Feb 2
to Chromium LUCI CQ, Sam Davis Omekara, Kevin Babbitt, Javier Contreras, Alison Maher, Olga Gerchikov, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57501

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0a9d802849c78c91d874f5de43616c2d58591712
Gerrit-Change-Number: 7533997
Gerrit-PatchSet: 8
Gerrit-Owner: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Javier Contreras <javi...@microsoft.com>
Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Reviewer: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Comment-Date: Tue, 03 Feb 2026 02:00:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages