Remove the ShapeBox::kMissing value [chromium/src : main]
0 views
Skip to first unread message
Fredrik Söderquist (Gerrit)
Jul 1, 2026, 1:51:52 PM (4 days ago) Jul 1
to Ian Kilpatrick, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
Jul 1, 2026, 4:11:55 PM (4 days ago) Jul 1
to Fredrik Söderquist, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Fredrik Söderquist
Ian Kilpatrick voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jul 1, 2026, 4:31:44 PM (4 days ago) Jul 1
to Fredrik Söderquist, Ian Kilpatrick, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Fredrik Söderquist
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/61029.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
Jul 2, 2026, 4:13:48 AM (3 days ago) Jul 2
to Blink W3C Test Autoroller, Ian Kilpatrick, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Fredrik Söderquist voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 2, 2026, 4:47:33 AM (3 days ago) Jul 2
to Fredrik Söderquist, Blink W3C Test Autoroller, Ian Kilpatrick, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove the ShapeBox::kMissing value
A missing <shape-box> for a <basic-shape> is the same as 'margin-box'.
Removing the kMissing value makes the code a bit simpler. It affects the
serialization of the computed value, but since the parser produces a
canonical form where 'margin-box' will be treated the same as no
<shape-box>, this won't be observable, but mirror the parser's behavior.
This simplifies the related animation code quite a bit, and makes
following cleanups easier.
Add basic WPT coverage for computed shape-outside with different
<shape-box> values since none were found in a cursory search.
Bug: 530077400
Change-Id: I649d15646f6f1dafc6e2460352e35f2a6f9af65c
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Commit-Queue: Fredrik Söderquist <f...@opera.com>
Cr-Commit-Position: refs/heads/main@{#1655951}
Files:
- M third_party/blink/renderer/core/animation/basic_shape_interpolation_functions.cc
- M third_party/blink/renderer/core/animation/css_basic_shape_interpolation_type.cc
- M third_party/blink/renderer/core/animation/css_path_interpolation_type.cc
- M third_party/blink/renderer/core/animation/css_shape_interpolation_type.cc
- M third_party/blink/renderer/core/animation/path_interpolation_functions.cc
- M third_party/blink/renderer/core/animation/path_interpolation_functions.h
- M third_party/blink/renderer/core/animation/shape_interpolation_functions.cc
- M third_party/blink/renderer/core/css/css_identifier_value_mappings.h
- M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
- M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
- M third_party/blink/renderer/core/layout/floats_utils.cc
- M third_party/blink/renderer/core/layout/shapes/shape_outside_info.cc
- M third_party/blink/renderer/core/style/computed_style_constants.h
- M third_party/blink/renderer/core/style/shape_value.h
- M third_party/blink/web_tests/external/wpt/css/css-shapes/parsing/shape-outside-computed.html
Change size: M
Delta: 15 files changed, 28 insertions(+), 52 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ian Kilpatrick
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jul 2, 2026, 5:33:26 AM (3 days ago) Jul 2
to Chromium LUCI CQ, Fredrik Söderquist, Ian Kilpatrick, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/61029
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages