Remove string operator+ usages in Blink production code [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Dec 5, 2025, 3:47:59 AM (5 days ago) Dec 5
to Kent Tamura, Fredrik Söderquist, Hiroki Nakagawa, Daniel Cheng, Luna Lu, chromium...@chromium.org, prerendering-reviews, Chromium LUCI CQ, Olga Gerchikov, Kentaro Hara, David Bokan, Javier Fernandez, Raphael Kubo da Costa, Kevin Babbitt, Yoav Weiss (@Shopify), (Julie)Jeongeun Kim, Dirk Schulze, Stephen Chenney, Menard, Alexis, AyeAye, devtools-re...@chromium.org, feature-v...@chromium.org, feature-me...@chromium.org, kinuko+ser...@chromium.org, shimazu+se...@chromium.org, servicewor...@chromium.org, extension...@chromium.org, jbroma...@chromium.org, chromium-a...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, dcheng+c...@chromium.org, ricea...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, jmedle...@chromium.org, iclella...@chromium.org, blink-reviews-p...@chromium.org, antoniosarto...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, yuzo+...@chromium.org, mkwst+w...@chromium.org, blink-re...@chromium.org, dominicc+...@chromium.org, pdr+svgw...@chromium.org, arthursonzog...@chromium.org, jshin...@chromium.org, nektar...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, zol...@webkit.org, lucasrada...@google.com, drott+bl...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, kyungjunle...@google.com, blink-work...@chromium.org, speed-metrics...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, francisjp...@google.com, gavinp+p...@chromium.org, core-timi...@chromium.org, abigailbk...@google.com, josiah...@chromium.org, shimazu...@chromium.org
Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 17 (Latest):
Kent Tamura . resolved

fs@, would you review this please?
This is the last CL for operator+-to-StrCat conversion.

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5acef2bbd0cced3cac3bb4bbd5ff82e1cfce2b43
Gerrit-Change-Number: 7155438
Gerrit-PatchSet: 17
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Fri, 05 Dec 2025 08:47:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Dec 5, 2025, 4:59:04 AM (5 days ago) Dec 5
to Kent Tamura, Hiroki Nakagawa, Daniel Cheng, Luna Lu, chromium...@chromium.org, prerendering-reviews, Chromium LUCI CQ, Olga Gerchikov, Kentaro Hara, David Bokan, Javier Fernandez, Raphael Kubo da Costa, Kevin Babbitt, Yoav Weiss (@Shopify), (Julie)Jeongeun Kim, Dirk Schulze, Stephen Chenney, Menard, Alexis, AyeAye, devtools-re...@chromium.org, feature-v...@chromium.org, feature-me...@chromium.org, kinuko+ser...@chromium.org, shimazu+se...@chromium.org, servicewor...@chromium.org, extension...@chromium.org, jbroma...@chromium.org, chromium-a...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, dcheng+c...@chromium.org, ricea...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, jmedle...@chromium.org, iclella...@chromium.org, blink-reviews-p...@chromium.org, antoniosarto...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, yuzo+...@chromium.org, mkwst+w...@chromium.org, blink-re...@chromium.org, dominicc+...@chromium.org, pdr+svgw...@chromium.org, arthursonzog...@chromium.org, jshin...@chromium.org, nektar...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, zol...@webkit.org, lucasrada...@google.com, drott+bl...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, kyungjunle...@google.com, blink-work...@chromium.org, speed-metrics...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, francisjp...@google.com, gavinp+p...@chromium.org, core-timi...@chromium.org, abigailbk...@google.com, josiah...@chromium.org, shimazu...@chromium.org
Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Fri, 05 Dec 2025 09:58:58 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 5, 2025, 5:02:18 AM (5 days ago) Dec 5
    to Kent Tamura, Fredrik Söderquist, Hiroki Nakagawa, Daniel Cheng, Luna Lu, chromium...@chromium.org, prerendering-reviews, Olga Gerchikov, Kentaro Hara, Akihiro Ota, David Bokan, Javier Fernandez, Raphael Kubo da Costa, Kevin Babbitt, Yoav Weiss (@Shopify), (Julie)Jeongeun Kim, Dirk Schulze, Stephen Chenney, Menard, Alexis, AyeAye, devtools-re...@chromium.org, feature-v...@chromium.org, feature-me...@chromium.org, kinuko+ser...@chromium.org, shimazu+se...@chromium.org, servicewor...@chromium.org, extension...@chromium.org, jbroma...@chromium.org, chromium-a...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, dcheng+c...@chromium.org, ricea...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, jmedle...@chromium.org, iclella...@chromium.org, blink-reviews-p...@chromium.org, antoniosarto...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, fmalit...@chromium.org, kinuko...@chromium.org, yuzo+...@chromium.org, mkwst+w...@chromium.org, blink-re...@chromium.org, dominicc+...@chromium.org, pdr+svgw...@chromium.org, arthursonzog...@chromium.org, jshin...@chromium.org, nektar...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, zol...@webkit.org, lucasrada...@google.com, drott+bl...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, kyungjunle...@google.com, blink-work...@chromium.org, speed-metrics...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, francisjp...@google.com, gavinp+p...@chromium.org, core-timi...@chromium.org, abigailbk...@google.com, josiah...@chromium.org, shimazu...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove string operator+ usages in Blink production code

    StrCat() is smaller and faster than operator+.
    This CL has no behavior changes.
    Bug: 419595599
    Change-Id: I5acef2bbd0cced3cac3bb4bbd5ff82e1cfce2b43
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Reviewed-by: Fredrik Söderquist <f...@opera.com>
    Cr-Commit-Position: refs/heads/main@{#1554552}
    Files:
    • M third_party/blink/renderer/core/animation/animation.cc
    • M third_party/blink/renderer/core/animation/animation_input_helpers.cc
    • M third_party/blink/renderer/core/animation/effect_input.cc
    • M third_party/blink/renderer/core/clipboard/data_transfer_item_list.cc
    • M third_party/blink/renderer/core/css/style_element.cc
    • M third_party/blink/renderer/core/geometry/dom_matrix_read_only.cc
    • M third_party/blink/renderer/core/html/html_view_source_document.cc
    • M third_party/blink/renderer/core/inspector/inspector_style_sheet.cc
    • M third_party/blink/renderer/core/intersection_observer/intersection_observer.cc
    • M third_party/blink/renderer/core/mathml/mathml_element.cc
    • M third_party/blink/renderer/core/mathml/mathml_space_element.cc
    • M third_party/blink/renderer/core/messaging/message_port.cc
    • M third_party/blink/renderer/core/mojo/test/mojo_interface_interceptor.cc
    • M third_party/blink/renderer/core/navigation_api/navigate_event.cc
    • M third_party/blink/renderer/core/navigation_api/navigation_api.cc
    • M third_party/blink/renderer/core/speculation_rules/speculation_rule_set.cc
    • M third_party/blink/renderer/core/view_transition/view_transition_style_tracker.cc
    • M third_party/blink/renderer/core/workers/abstract_worker.cc
    • M third_party/blink/renderer/core/workers/shared_worker.cc
    • M third_party/blink/renderer/core/workers/worker_classic_script_loader.cc
    • M third_party/blink/renderer/core/workers/worker_global_scope.cc
    • M third_party/blink/renderer/core/workers/worklet.cc
    • M third_party/blink/renderer/platform/fonts/web_font_decoder.cc
    • M third_party/blink/renderer/platform/text/locale_win.cc
    Change size: M
    Delta: 24 files changed, 87 insertions(+), 77 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Fredrik Söderquist
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5acef2bbd0cced3cac3bb4bbd5ff82e1cfce2b43
    Gerrit-Change-Number: 7155438
    Gerrit-PatchSet: 18
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages