[cleanup] Simplify ComputeOutOfFlowInsets [chromium/src : main]
2 views
Skip to first unread message
Ian Kilpatrick (Gerrit)
May 8, 2026, 12:33:35 PM (7 days ago) May 8
to David Grogan, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from David Grogan
Ian Kilpatrick voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- David Grogan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Grogan (Gerrit)
May 8, 2026, 3:09:46 PM (7 days ago) May 8
to Ian Kilpatrick, David Grogan, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick
David Grogan voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
May 8, 2026, 3:19:13 PM (6 days ago) May 8
to David Grogan, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Ian Kilpatrick voted![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 8, 2026, 3:22:22 PM (6 days ago) May 8
to Ian Kilpatrick, David Grogan, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[cleanup] Simplify ComputeOutOfFlowInsets
This function was unnecessarily converting to/from the physical
coordinate space, when all of the calculations were being done in a
consistent writing-direction.
Remove these logical->physical->logical conversions, and remove code
duplication.
Additionally remove a redundant if-stmt within
ComputeAnchorCenterPosition.
There should be no behaviour change.
Change-Id: I00ccd1de2006489d05aba934f53a34f6c2bc8102
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Reviewed-by: David Grogan <dgr...@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1627827}
Files:
- M third_party/blink/renderer/core/layout/absolute_utils.cc
- M third_party/blink/renderer/core/layout/absolute_utils.h
- M third_party/blink/renderer/core/layout/absolute_utils_test.cc
- M third_party/blink/renderer/core/layout/out_of_flow_layout_part.cc
- M third_party/blink/renderer/core/style/computed_style.h
Change size: M
Delta: 5 files changed, 44 insertions(+), 84 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by David Grogan, +1 by Ian Kilpatrick
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages