[cleanup] Simplify ComputeOutOfFlowInsets [chromium/src : main]

2 views
Skip to first unread message

Ian Kilpatrick (Gerrit)

unread,
May 8, 2026, 12:33:35 PM (7 days ago) May 8
to David Grogan, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from David Grogan

Ian Kilpatrick voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Grogan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I00ccd1de2006489d05aba934f53a34f6c2bc8102
Gerrit-Change-Number: 7829465
Gerrit-PatchSet: 5
Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Attention: David Grogan <dgr...@chromium.org>
Gerrit-Comment-Date: Fri, 08 May 2026 16:33:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

David Grogan (Gerrit)

unread,
May 8, 2026, 3:09:46 PM (7 days ago) May 8
to Ian Kilpatrick, David Grogan, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick

David Grogan voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I00ccd1de2006489d05aba934f53a34f6c2bc8102
    Gerrit-Change-Number: 7829465
    Gerrit-PatchSet: 6
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Comment-Date: Fri, 08 May 2026 19:09:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ian Kilpatrick (Gerrit)

    unread,
    May 8, 2026, 3:19:13 PM (6 days ago) May 8
    to David Grogan, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Ian Kilpatrick voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I00ccd1de2006489d05aba934f53a34f6c2bc8102
      Gerrit-Change-Number: 7829465
      Gerrit-PatchSet: 6
      Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Comment-Date: Fri, 08 May 2026 19:18:59 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      May 8, 2026, 3:22:22 PM (6 days ago) May 8
      to Ian Kilpatrick, David Grogan, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [cleanup] Simplify ComputeOutOfFlowInsets

      This function was unnecessarily converting to/from the physical
      coordinate space, when all of the calculations were being done in a
      consistent writing-direction.

      Remove these logical->physical->logical conversions, and remove code
      duplication.

      Additionally remove a redundant if-stmt within
      ComputeAnchorCenterPosition.

      There should be no behaviour change.
      Change-Id: I00ccd1de2006489d05aba934f53a34f6c2bc8102
      Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
      Reviewed-by: David Grogan <dgr...@chromium.org>
      Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1627827}
      Files:
      • M third_party/blink/renderer/core/layout/absolute_utils.cc
      • M third_party/blink/renderer/core/layout/absolute_utils.h
      • M third_party/blink/renderer/core/layout/absolute_utils_test.cc
      • M third_party/blink/renderer/core/layout/out_of_flow_layout_part.cc
      • M third_party/blink/renderer/core/style/computed_style.h
      Change size: M
      Delta: 5 files changed, 44 insertions(+), 84 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by David Grogan, +1 by Ian Kilpatrick
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I00ccd1de2006489d05aba934f53a34f6c2bc8102
      Gerrit-Change-Number: 7829465
      Gerrit-PatchSet: 7
      Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages