Felipe Erias (Gerrit)

unread,

Aug 11, 2025, 8:33:46 AMAug 11

to Ian Kilpatrick, Kent Tamura, Koji Ishii, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Ian Kilpatrick, Kent Tamura and Koji Ishii

Felipe Erias added 1 comment

Patchset-level comments

File-level comment, Patchset 10:

Felipe Erias . resolved

Hello,

This CL implements text-transform:full-width as defined in CSS Text level 3.

I have followed the Firefox example, which uses character tables gathered directly from the Unicode database.

The attached WPT test also passes on Firefox (but not on Safari, which uses a external library).

Some existing WPT tests still fail because whitespace conversion (as defined in the standard) is rather complex. I plan to fix those remaining corner cases in a separate CL.

Thank you so much for your review!

Best,
Felipe

Chromestatus:

https://chromestatus.com/feature/5185842163351552

Intent to Prototype:

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/6894ba2e.050a0220.1b8b65.0657.GAE%40google.com

Open in Gerrit

Related details

Attention is currently required from:

Ian Kilpatrick
Kent Tamura
Koji Ishii

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kent Tamura (Gerrit)

unread,

Aug 11, 2025, 6:47:44 PMAug 11

to Felipe Erias, Kent Tamura, Koji Ishii, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Felipe Erias and Koji Ishii

Kent Tamura added 8 comments

File third_party/blink/renderer/core/style/computed_style.cc

Line 1975, Patchset 11 (Latest): static const UChar32 kKatakanaTable[] = {

Kent Tamura . unresolved

Should be `auto kKatakanaTable = std::to_array<UChar32>(` to avoid `UNSAFE_BUFFERS` below.

Line 2024, Patchset 11 (Latest): case 0x0020: // Space

Kent Tamura . unresolved

Use `uchar::kSpace`.

Line 2025, Patchset 11 (Latest): return 0x3000;

Kent Tamura . unresolved

Use `uchar::kIdeographicSpace`.

Line 2036, Patchset 11 (Latest): case 0x00A5: // Yen sign

Kent Tamura . unresolved

Use `uchar::kYenSign`.

Line 2055, Patchset 11 (Latest): return 0x25A0;

Kent Tamura . unresolved

Use `uchar::kBlackSquare`.

Line 2069, Patchset 11 (Latest): for (unsigned i = 0; i < text.length(); ++i) {

Kent Tamura . unresolved

Let's use `CodePointerIterator` to simplify the code.

    for (UChar32 code_point : StringView(text)) {
      if (code_point == uchar::kSpace && !preserve_white_space || !U_IS_BMP(code_point)) {
        result.Append(code_point);

Line 2090, Patchset 11 (Latest): if (code_point == 0x20 && !preserve_white_space) {

Kent Tamura . unresolved

Use `uchar::kSpace`.

Line 2098, Patchset 11 (Latest): String transformed_string = result.ToString();

Kent Tamura . unresolved

`ReleaseString()` is preferable.

Open in Gerrit

Related details

Attention is currently required from:

Felipe Erias
Koji Ishii

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Koji Ishii (Gerrit)

unread,

Aug 14, 2025, 12:33:17 AMAug 14

to Felipe Erias, Kent Tamura, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Felipe Erias

Koji Ishii added 1 comment

File third_party/blink/renderer/core/style/computed_style.cc

Line 1985, Patchset 11 (Latest): DCHECK(index >= 0 && index < std::size(kKatakanaTable));

Koji Ishii . unresolved

Can this be `CHECK` instead of `DCHECK` since the failure can be out-of-bounds access?

Open in Gerrit

Related details

Attention is currently required from:

Felipe Erias

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Koji Ishii (Gerrit)

unread,

Aug 14, 2025, 12:49:22 AMAug 14

to Felipe Erias, Kent Tamura, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Felipe Erias

Koji Ishii added 2 comments

File third_party/blink/renderer/core/style/computed_style.cc

Line 1985, Patchset 11 (Latest): DCHECK(index >= 0 && index < std::size(kKatakanaTable));

Koji Ishii . unresolved

Can this be `CHECK` instead of `DCHECK` since the failure can be out-of-bounds access?

Koji Ishii

Also `index >= 0 && ` isn't necessary as `size_t` is unsigned.

File third_party/blink/web_tests/TestExpectations

Line 794, Patchset 11 (Latest):crbug.com/1219023 external/wpt/css/css-text/text-transform/text-transform-fullwidth-009.html [ Failure ]

Koji Ishii . unresolved

Are you planning to fix them in future patches?

satisfied_requirement

unsatisfied_requirement

open

diffy

Felipe Erias (Gerrit)

unread,

Aug 18, 2025, 7:42:55 AMAug 18

to Kent Tamura, Koji Ishii, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Kent Tamura and Koji Ishii

Felipe Erias added 11 comments

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Felipe Erias . resolved

Thank you so much for your detailed feedback.

I have tried to address every point, please let me know if anything else is needed.

Best,
Felipe

File third_party/blink/renderer/core/style/computed_style.cc

Line 1975, Patchset 11: static const UChar32 kKatakanaTable[] = {

Kent Tamura . resolved

Should be `auto kKatakanaTable = std::to_array<UChar32>(` to avoid `UNSAFE_BUFFERS` below.

Felipe Erias

Done

Line 1985, Patchset 11: DCHECK(index >= 0 && index < std::size(kKatakanaTable));

Koji Ishii . resolved

Can this be `CHECK` instead of `DCHECK` since the failure can be out-of-bounds access?

Koji Ishii

Also `index >= 0 && ` isn't necessary as `size_t` is unsigned.

Felipe Erias

Done

Line 2024, Patchset 11: case 0x0020: // Space

Kent Tamura . resolved

Use `uchar::kSpace`.

Felipe Erias

Done

Line 2025, Patchset 11: return 0x3000;

Kent Tamura . resolved

Use `uchar::kIdeographicSpace`.

Felipe Erias

Done

Line 2036, Patchset 11: case 0x00A5: // Yen sign

Kent Tamura . resolved

Use `uchar::kYenSign`.

Felipe Erias

Done

Line 2055, Patchset 11: return 0x25A0;

Kent Tamura . resolved

Use `uchar::kBlackSquare`.

Felipe Erias

Done

Line 2069, Patchset 11: for (unsigned i = 0; i < text.length(); ++i) {

Kent Tamura . resolved

Let's use `CodePointerIterator` to simplify the code.

    for (UChar32 code_point : StringView(text)) {
      if (code_point == uchar::kSpace && !preserve_white_space || !U_IS_BMP(code_point)) {
        result.Append(code_point);

Felipe Erias

Done

Line 2090, Patchset 11: if (code_point == 0x20 && !preserve_white_space) {

Kent Tamura . resolved

Use `uchar::kSpace`.

Felipe Erias

Done

Line 2098, Patchset 11: String transformed_string = result.ToString();

Kent Tamura . resolved

`ReleaseString()` is preferable.

Felipe Erias

Done

File third_party/blink/web_tests/TestExpectations

Line 794, Patchset 11:crbug.com/1219023 external/wpt/css/css-text/text-transform/text-transform-fullwidth-009.html [ Failure ]

Koji Ishii . unresolved

Are you planning to fix them in future patches?

Felipe Erias

Yes, I plan to fix those tests after this CL lands.

Open in Gerrit

Related details

Attention is currently required from:

Kent Tamura
Koji Ishii

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kent Tamura (Gerrit)

unread,

Aug 19, 2025, 1:53:41 AMAug 19

to Felipe Erias, Kent Tamura, Koji Ishii, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Felipe Erias and Koji Ishii

Kent Tamura voted and added 2 comments

Votes added by Kent Tamura

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Kent Tamura . resolved

LGTM.

File third_party/blink/renderer/core/style/computed_style.cc

Line 1988, Patchset 12 (Latest): CHECK(index < std::size(kKatakanaTable));

Kent Tamura . unresolved

This check is unnecessary. std::array::operator[] contains a similar one.

Open in Gerrit

Related details

Attention is currently required from:

Felipe Erias
Koji Ishii

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Koji Ishii (Gerrit)

unread,

Aug 19, 2025, 12:40:39 PMAug 19

to Felipe Erias, Kent Tamura, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Felipe Erias

Koji Ishii voted and added 2 comments

Votes added by Koji Ishii

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Koji Ishii . resolved

lgtm w/Kent's feedback applied.

File third_party/blink/web_tests/TestExpectations

Line 794, Patchset 11:crbug.com/1219023 external/wpt/css/css-text/text-transform/text-transform-fullwidth-009.html [ Failure ]

Koji Ishii . resolved

Are you planning to fix them in future patches?

Felipe Erias

Yes, I plan to fix those tests after this CL lands.

Koji Ishii

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

Felipe Erias

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Felipe Erias (Gerrit)

unread,

Aug 20, 2025, 4:06:21 AMAug 20

to Koji Ishii, Kent Tamura, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Kent Tamura and Koji Ishii

Felipe Erias added 2 comments

Patchset-level comments

File-level comment, Patchset 13:

Felipe Erias . resolved

Thank you, I have removed the unnecessary check.

I have kept the variable declaration in a separate line because IMHO it is a bit easier to read:

    size_t index = code_point - 0xFF61;
    return kKatakanaTable[index];

File third_party/blink/renderer/core/style/computed_style.cc

Line 1988, Patchset 12: CHECK(index < std::size(kKatakanaTable));

Kent Tamura . resolved

This check is unnecessary. std::array::operator[] contains a similar one.

Felipe Erias

Done

Open in Gerrit

Related details

Attention is currently required from:

Kent Tamura
Koji Ishii

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Koji Ishii (Gerrit)

unread,

Aug 20, 2025, 6:02:22 AMAug 20

to Felipe Erias, Kent Tamura, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Felipe Erias and Kent Tamura

Koji Ishii voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Felipe Erias
Kent Tamura

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Koji Ishii (Gerrit)

unread,

Aug 20, 2025, 6:02:35 AMAug 20

to Felipe Erias, Kent Tamura, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Felipe Erias and Kent Tamura

Koji Ishii added 1 comment

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Koji Ishii . resolved

lgtm

Open in Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kent Tamura (Gerrit)

unread,

Aug 20, 2025, 6:16:19 AMAug 20

to Felipe Erias, Kent Tamura, Koji Ishii, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Felipe Erias

Kent Tamura voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Felipe Erias

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Felipe Erias (Gerrit)

unread,

Aug 20, 2025, 9:09:14 AMAug 20

to Kent Tamura, Koji Ishii, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Felipe Erias voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Aug 20, 2025, 9:34:37 AMAug 20

to Felipe Erias, Kent Tamura, Koji Ishii, AyeAye, Alexis Menard, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

blink/css: Implement text-transform: full-width

Adds support for CSS text-transform: full-width specified in CSS Text
Level 3.

https://www.w3.org/TR/css-text-3/#text-transform-property

This value transforms all narrow characters that have a full-width
mapping in Unicode to their wide equivalents. This includes ASCII,
Japanese Katakana, Korean Hangul, and several special symbols.

The concrete list of character conversions follows the one used by
Firefox, which was compiled directly from the Unicode database. See:

https://bugzilla.mozilla.org/show_bug.cgi?id=774560

This CL includes a new WPT test:

/css/css-text/text-transform/text-transform-fullwidth-010.html

Bug: 41297237

Change-Id: I280d4c5df9d221167bfb51c5988f485a03bdfad4

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6790585

Commit-Queue: Felipe Erias <felip...@igalia.com>

Reviewed-by: Kent Tamura <tk...@chromium.org>

Reviewed-by: Koji Ishii <ko...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1503902}

Files:

M third_party/blink/renderer/core/css/css_properties.json5
M third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc
M third_party/blink/renderer/core/style/computed_style.cc
M third_party/blink/renderer/platform/runtime_enabled_features.json5
M third_party/blink/web_tests/NeverFixTests
M third_party/blink/web_tests/TestExpectations
M third_party/blink/web_tests/W3CImportExpectations
M third_party/blink/web_tests/external/wpt/css/css-text/parsing/text-transform-computed-expected.txt
M third_party/blink/web_tests/external/wpt/css/css-text/parsing/text-transform-valid-expected.txt
A third_party/blink/web_tests/external/wpt/css/css-text/text-transform/reference/text-transform-fullwidth-010-ref.html
A third_party/blink/web_tests/external/wpt/css/css-text/text-transform/text-transform-fullwidth-010.html
D third_party/blink/web_tests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-transform-expected.txt

Change size: M

Delta: 12 files changed, 221 insertions(+), 20 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Kent Tamura, +1 by Koji Ishii

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Blink W3C Test Autoroller (Gerrit)

unread,

Aug 20, 2025, 12:04:10 PMAug 20

to Felipe Erias, Chromium LUCI CQ, Kent Tamura, Koji Ishii, AyeAye, Alexis Menard, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/54427

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Brad Triebwasser (Gerrit)

unread,

Aug 20, 2025, 12:57:35 PMAug 20

to Felipe Erias, Chromium LUCI CQ, Blink W3C Test Autoroller, Kent Tamura, Koji Ishii, AyeAye, Alexis Menard, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Brad Triebwasser has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

blink/css: Implement text-transform: full-width [chromium/src : main]

Felipe Erias (Gerrit)

Felipe Erias added 1 comment

Related details

Kent Tamura (Gerrit)

Kent Tamura added 8 comments

Related details

Koji Ishii (Gerrit)

Koji Ishii added 1 comment

Related details

Koji Ishii (Gerrit)

Koji Ishii added 2 comments

Felipe Erias (Gerrit)

Felipe Erias added 11 comments

Related details

Kent Tamura (Gerrit)

Kent Tamura voted and added 2 comments

Votes added by Kent Tamura

2 comments

Related details

Koji Ishii (Gerrit)

Koji Ishii voted and added 2 comments

Votes added by Koji Ishii

2 comments

Related details

Felipe Erias (Gerrit)

Felipe Erias added 2 comments

Related details

Koji Ishii (Gerrit)

Koji Ishii voted Code-Review+1

Related details

Koji Ishii (Gerrit)

Koji Ishii added 1 comment

Kent Tamura (Gerrit)

Kent Tamura voted Code-Review+1

Related details

Felipe Erias (Gerrit)

Felipe Erias voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Blink W3C Test Autoroller (Gerrit)

Message from Blink W3C Test Autoroller

Related details

Brad Triebwasser (Gerrit)

Brad Triebwasser has created a revert of this change

Related details