Revert "[layout] Reinsert LayoutObjects which undergo a in-flow state change." [chromium/src : main]

0 views
Skip to first unread message

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 19, 2025, 7:44:26 PM (13 days ago) 12/19/25
to Demetrios Papadopoulos, Rubber Stamper, AyeAye, Chromium LUCI CQ, Philip Rogers, Ian Kilpatrick, Rune Lillesveen, Morten Stenshorne, AI Code Reviewer, chromium...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, mac-r...@chromium.org, kinuko...@chromium.org
Attention needed from Demetrios Papadopoulos, Ian Kilpatrick, Morten Stenshorne, Philip Rogers and Rune Lillesveen

Message from luci-bi...@appspot.gserviceaccount.com

LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.

Open in Gerrit

Related details

Attention is currently required from:
  • Demetrios Papadopoulos
  • Ian Kilpatrick
  • Morten Stenshorne
  • Philip Rogers
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id465131d8ef51191e475ded57794e5226a3bcb73
Gerrit-Change-Number: 7281514
Gerrit-PatchSet: 1
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@google.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Attention: Demetrios Papadopoulos <dpa...@google.com>
Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
Gerrit-Comment-Date: Sat, 20 Dec 2025 00:44:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Dec 19, 2025, 7:45:15 PM (13 days ago) 12/19/25
to luci-bi...@appspot.gserviceaccount.com, Demetrios Papadopoulos, AyeAye, Chromium LUCI CQ, Philip Rogers, Ian Kilpatrick, Rune Lillesveen, Morten Stenshorne, AI Code Reviewer, chromium...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, mac-r...@chromium.org, kinuko...@chromium.org
Attention needed from Demetrios Papadopoulos, Ian Kilpatrick, Morten Stenshorne, Philip Rogers and Rune Lillesveen

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Demetrios Papadopoulos
  • Ian Kilpatrick
  • Morten Stenshorne
  • Philip Rogers
  • Rune Lillesveen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Comment-Date: Sat, 20 Dec 2025 00:45:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ian Kilpatrick (Gerrit)

    unread,
    Dec 19, 2025, 9:03:25 PM (13 days ago) 12/19/25
    to luci-bi...@appspot.gserviceaccount.com, Rubber Stamper, Demetrios Papadopoulos, AyeAye, Chromium LUCI CQ, Philip Rogers, Rune Lillesveen, Morten Stenshorne, AI Code Reviewer, chromium...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, mac-r...@chromium.org, kinuko...@chromium.org
    Attention needed from Demetrios Papadopoulos, Morten Stenshorne, Philip Rogers and Rune Lillesveen

    Ian Kilpatrick voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Demetrios Papadopoulos
    • Morten Stenshorne
    • Philip Rogers
    • Rune Lillesveen
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id465131d8ef51191e475ded57794e5226a3bcb73
      Gerrit-Change-Number: 7281514
      Gerrit-PatchSet: 1
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@google.com>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
      Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
      Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
      Gerrit-Attention: Philip Rogers <p...@chromium.org>
      Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
      Gerrit-Attention: Demetrios Papadopoulos <dpa...@google.com>
      Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Comment-Date: Sat, 20 Dec 2025 02:03:15 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Ian Kilpatrick (Gerrit)

      unread,
      Dec 19, 2025, 9:03:37 PM (13 days ago) 12/19/25
      to luci-bi...@appspot.gserviceaccount.com, Rubber Stamper, Demetrios Papadopoulos, AyeAye, Chromium LUCI CQ, Philip Rogers, Rune Lillesveen, Morten Stenshorne, AI Code Reviewer, chromium...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, mac-r...@chromium.org, kinuko...@chromium.org
      Attention needed from Demetrios Papadopoulos, Morten Stenshorne, Philip Rogers and Rune Lillesveen

      Ian Kilpatrick voted Commit-Queue+2

      Commit-Queue+2
      Gerrit-Comment-Date: Sat, 20 Dec 2025 02:03:27 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Dec 19, 2025, 9:04:03 PM (13 days ago) 12/19/25
      to luci-bi...@appspot.gserviceaccount.com, Ian Kilpatrick, Rubber Stamper, Demetrios Papadopoulos, AyeAye, Philip Rogers, Rune Lillesveen, Morten Stenshorne, AI Code Reviewer, chromium...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, mac-r...@chromium.org, kinuko...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Revert "[layout] Reinsert LayoutObjects which undergo a in-flow state change."

      This reverts commit f57a40a0aa2b6ad6c397d45a1194da9cc32f24b8.

      Reason for revert:
      LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5667847364673536

      Sample build with failed test: https://ci.chromium.org/b/8695026507201286817
      Affected test(s):
      [://chrome/test\:browser_tests!gtest::CrElementsTest#CrViewManager](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::CrElementsTest%23CrViewManager?q=VHash%3A5a9885bd2bc5b6c9)
      [://chrome/test\:browser_tests!gtest::InterstitialUITest#BillingInterstitial](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::InterstitialUITest%23BillingInterstitial?q=VHash%3A5a9885bd2bc5b6c9)
      [://chrome/test\:browser_tests!gtest::InterstitialUITest#BlockedInterceptionInterstitial](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::InterstitialUITest%23BlockedInterceptionInterstitial?q=VHash%3A5a9885bd2bc5b6c9)
      [://chrome/test\:browser_tests!gtest::InterstitialUITest#CTInterstitial](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::InterstitialUITest%23CTInterstitial?q=VHash%3A5a9885bd2bc5b6c9)
      [://chrome/test\:browser_tests!gtest::InterstitialUITest#ClientsideMalwareInterstitial](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::InterstitialUITest%23ClientsideMalwareInterstitial?q=VHash%3A5a9885bd2bc5b6c9)
      and 10 more ...

      If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5667847364673536&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7271268&type=BUG

      Original change's description:
      > [layout] Reinsert LayoutObjects which undergo a in-flow state change.
      >
      > This patch reinserts layout-objects into the layout-tree when their
      > out-of-flow state changes. (E.g. a change from position:static to
      > position:absolute or float:left to float:none).
      >
      > When their out-of-flow state changes we'll remove it from the
      > layout-object tree, update the style, then reinsert into the tree. This
      > is similar to layout-tree reattachment, except the layout-object (and
      > related objects/caches) are kept around.
      >
      > This simplifies our logic when style changes in this way. Previously
      > we'd need to mutate the layout tree during LayoutObject::SetStyle which
      > was complex and error prone, and a source of bugs.
      >
      > See removal patch for complexity we can remove:
      > https://chromium-review.googlesource.com/c/chromium/src/+/7263470
      >
      > All behaviour changes should be behind the flag:
      > LayoutReinsertOnPositionStateChangeEnabled
      >
      > Fuchsia-Binary-Size: Increase is temporary.
      > Bug: 469120960
      > Change-Id: Ied7a212aae707b2db627a8ee15ba57b5b289235a
      > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7271268
      > Reviewed-by: Rune Lillesveen <fut...@chromium.org>
      > Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
      > Reviewed-by: Morten Stenshorne <mste...@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#1561208}
      >
      Bug: 469120960
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Change-Id: Id465131d8ef51191e475ded57794e5226a3bcb73
      Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
      Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
      Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1561469}
      Files:
      • M third_party/blink/renderer/core/dom/element.cc
      • M third_party/blink/renderer/core/layout/layout_block_flow.cc
      • M third_party/blink/renderer/core/layout/layout_box.cc
      • M third_party/blink/renderer/core/layout/layout_inline.cc
      • M third_party/blink/renderer/core/layout/layout_object.cc
      • M third_party/blink/renderer/core/layout/layout_object.h
      • M third_party/blink/renderer/core/style/computed_style.cc
      • M third_party/blink/renderer/core/style/computed_style.h
      • M third_party/blink/renderer/platform/runtime_enabled_features.json5
      • M third_party/blink/web_tests/paint/invalidation/position/position-change-keeping-geometry-expected.txt
      • M third_party/blink/web_tests/paint/invalidation/position/positioned-document-element-expected.txt
      • M third_party/blink/web_tests/platform/mac/paint/invalidation/position/position-change-keeping-geometry-expected.txt
      Change size: M
      Delta: 12 files changed, 34 insertions(+), 121 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Ian Kilpatrick, Bot-Commit+1 by Rubber Stamper
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id465131d8ef51191e475ded57794e5226a3bcb73
      Gerrit-Change-Number: 7281514
      Gerrit-PatchSet: 2
      open
      diffy
      satisfied_requirement

      Chrome Crash (Prod) (Gerrit)

      unread,
      Dec 20, 2025, 8:09:04 AM (13 days ago) 12/20/25
      to Rubber Stamper, AyeAye, Chromium LUCI CQ, Philip Rogers, Ian Kilpatrick, Rune Lillesveen, Morten Stenshorne, Bro, AI Code Reviewer, chromium...@chromium.org, jmedle...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, zol...@webkit.org, mac-r...@chromium.org
      Attention needed from Ian Kilpatrick, Morten Stenshorne, Philip Rogers and Rune Lillesveen

      Chrome Crash (Prod) voted Commit-Queue+1

      Trigger the CQ Dryrun through the Set Review API to save waiting time.

      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Ian Kilpatrick
      • Morten Stenshorne
      • Philip Rogers
      • Rune Lillesveen
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ifea01eb4f80c1acded1acbb2a5e73531c4484bc9
          Gerrit-Change-Number: 7287482
          Gerrit-PatchSet: 2
          Gerrit-Owner: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
          Gerrit-Reviewer: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
          Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
          Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
          Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
          Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
          Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
          Gerrit-CC: Bro <batma...@gmail.com>
          Gerrit-Attention: Philip Rogers <p...@chromium.org>
          Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
          Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
          Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
          Gerrit-Comment-Date: Sat, 20 Dec 2025 13:08:59 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Rubber Stamper (Gerrit)

          unread,
          Dec 20, 2025, 8:09:25 AM (13 days ago) 12/20/25
          to Chrome Crash (Prod), AyeAye, Chromium LUCI CQ, Philip Rogers, Ian Kilpatrick, Rune Lillesveen, Morten Stenshorne, Bro, AI Code Reviewer, chromium...@chromium.org, jmedle...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, zol...@webkit.org, mac-r...@chromium.org
          Attention needed from Ian Kilpatrick, Morten Stenshorne, Philip Rogers and Rune Lillesveen

          Rubber Stamper voted Bot-Commit+1

          Bot-Commit+1
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Ian Kilpatrick
          • Morten Stenshorne
          • Philip Rogers
          • Rune Lillesveen
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Ifea01eb4f80c1acded1acbb2a5e73531c4484bc9
            Gerrit-Change-Number: 7287482
            Gerrit-PatchSet: 3
            Gerrit-Owner: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
            Gerrit-Reviewer: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
            Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
            Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
            Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
            Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
            Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
            Gerrit-CC: Bro <batma...@gmail.com>
            Gerrit-Attention: Philip Rogers <p...@chromium.org>
            Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
            Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
            Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Comment-Date: Sat, 20 Dec 2025 13:09:13 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Morten Stenshorne (Gerrit)

            unread,
            Dec 22, 2025, 4:19:51 AM (11 days ago) 12/22/25
            to Chrome Crash (Prod), Rubber Stamper, AyeAye, Chromium LUCI CQ, Philip Rogers, Ian Kilpatrick, Rune Lillesveen, AI Code Reviewer, chromium...@chromium.org, jmedle...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, zol...@webkit.org, mac-r...@chromium.org

            Morten Stenshorne abandoned this change

            Related details

            Attention set is empty
            Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: abandon
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Ifea01eb4f80c1acded1acbb2a5e73531c4484bc9
            Gerrit-Change-Number: 7287482
            Gerrit-PatchSet: 3
            Gerrit-Owner: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
            Gerrit-Reviewer: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
            Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
            Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
            Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
            Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
            Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
            Gerrit-CC: Deleted User
            satisfied_requirement
            open
            diffy
            Reply all
            Reply to author
            Forward
            0 new messages