Revert "Implement non-overlay mode for ::overscroll-area-parent" [chromium/src : main]

0 views
Skip to first unread message

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,
Mar 10, 2026, 5:24:50 PM (18 hours ago) Mar 10
to Rubber Stamper, Chromium LUCI CQ, Philip Rogers, Robert Flack, Vladimir Levin, AyeAye, Stephen Chenney, chromium...@chromium.org, Menard, Alexis, Dirk Schulze, xiaol...@google.com, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, apavlo...@chromium.org
Attention needed from Philip Rogers, Robert Flack and Vladimir Levin

Message from luci-bi...@appspot.gserviceaccount.com

LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
  • Robert Flack
  • Vladimir Levin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I188446aaee10b9d1a1d515bb52ebac514fe2e7e8
Gerrit-Change-Number: 7653382
Gerrit-PatchSet: 1
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Attention: Robert Flack <fla...@chromium.org>
Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Mar 2026 21:24:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Mar 10, 2026, 5:25:20 PM (18 hours ago) Mar 10
to luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Philip Rogers, Robert Flack, Vladimir Levin, AyeAye, Stephen Chenney, chromium...@chromium.org, Menard, Alexis, Dirk Schulze, xiaol...@google.com, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, apavlo...@chromium.org
Attention needed from Philip Rogers, Robert Flack and Vladimir Levin

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
  • Robert Flack
  • Vladimir Levin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I188446aaee10b9d1a1d515bb52ebac514fe2e7e8
    Gerrit-Change-Number: 7653382
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Attention: Robert Flack <fla...@chromium.org>
    Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Mar 2026 21:25:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Robert Flack (Gerrit)

    unread,
    Mar 10, 2026, 5:32:23 PM (17 hours ago) Mar 10
    to luci-bi...@appspot.gserviceaccount.com, Rubber Stamper, Chromium LUCI CQ, Philip Rogers, Vladimir Levin, AyeAye, Stephen Chenney, chromium...@chromium.org, Menard, Alexis, Dirk Schulze, xiaol...@google.com, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, apavlo...@chromium.org
    Attention needed from Philip Rogers and Vladimir Levin

    Robert Flack voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Philip Rogers
    • Vladimir Levin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I188446aaee10b9d1a1d515bb52ebac514fe2e7e8
    Gerrit-Change-Number: 7653382
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Mar 2026 21:32:16 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Robert Flack (Gerrit)

    unread,
    Mar 10, 2026, 5:32:34 PM (17 hours ago) Mar 10
    to luci-bi...@appspot.gserviceaccount.com, Rubber Stamper, Chromium LUCI CQ, Philip Rogers, Vladimir Levin, AyeAye, Stephen Chenney, chromium...@chromium.org, Menard, Alexis, Dirk Schulze, xiaol...@google.com, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, apavlo...@chromium.org
    Attention needed from Philip Rogers and Vladimir Levin

    Robert Flack voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Tue, 10 Mar 2026 21:32:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 10, 2026, 5:32:57 PM (17 hours ago) Mar 10
    to luci-bi...@appspot.gserviceaccount.com, Robert Flack, Rubber Stamper, Philip Rogers, Vladimir Levin, AyeAye, Stephen Chenney, chromium...@chromium.org, Menard, Alexis, Dirk Schulze, xiaol...@google.com, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, zol...@webkit.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, apavlo...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "Implement non-overlay mode for ::overscroll-area-parent"

    This reverts commit e10bce24723b1d8b2ef2e3f01731a91ca47907c5.

    Reason for revert:
    LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5727713504526336

    Sample build with failed test: https://ci.chromium.org/b/8687689896853591793
    Affected test(s):
    [://\:blink_wpt_tests!webtest::wpt_internal/overscroll-gestures#shutdown-overscrollcontainer-crash.html](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_wpt_tests%21webtest::wpt_internal%2Foverscroll-gestures%23shutdown-overscrollcontainer-crash.html?q=VHash%3A726fdd7b7e18282a)

    If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5727713504526336&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7545871&type=BUG

    Original change's description:
    > Implement non-overlay mode for ::overscroll-area-parent
    >
    > The overscrollcontainer attribute now supports an
    > overlay value to opt in to overlay mode.
    > When not in overlay mode, the content is shifted
    > by scrolling in the overscroll.
    >
    > Bug: 477041877, 488121767
    > Change-Id: I4a0aea4fb911f2b076953a23cef0168d5b37f517
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7545871
    > Reviewed-by: Philip Rogers <p...@chromium.org>
    > Commit-Queue: Robert Flack <fla...@chromium.org>
    > Reviewed-by: Vladimir Levin <vmp...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1597221}
    >
    Bug: 477041877, 488121767
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: I188446aaee10b9d1a1d515bb52ebac514fe2e7e8
    Reviewed-by: Robert Flack <fla...@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Commit-Queue: Robert Flack <fla...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1597330}
    Files:
    • M third_party/blink/renderer/core/css/css_properties.json5
    • M third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc
    • M third_party/blink/renderer/core/css/resolver/style_adjuster.cc
    • M third_party/blink/renderer/core/css/style_recalc_context.cc
    • M third_party/blink/renderer/core/dom/element.cc
    • M third_party/blink/renderer/core/html/resources/html.css
    • M third_party/blink/renderer/core/layout/layout_box.cc
    • M third_party/blink/renderer/core/layout/layout_object.cc
    • M third_party/blink/renderer/core/layout/layout_object.h
    • M third_party/blink/renderer/core/layout/physical_box_fragment.cc
    • M third_party/blink/renderer/core/layout/physical_box_fragment.h
    • M third_party/blink/renderer/core/layout/physical_fragment.h
    • M third_party/blink/renderer/core/overscroll/overscroll_area_tracker_test.cc
    • M third_party/blink/renderer/core/paint/box_fragment_painter.cc
    • M third_party/blink/renderer/core/paint/compositing/compositing_reason_finder.cc
    • M third_party/blink/renderer/core/paint/fragment_data.cc
    • M third_party/blink/renderer/core/paint/object_paint_properties.h
    • M third_party/blink/renderer/core/paint/paint_layer.cc
    • M third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
    • M third_party/blink/renderer/core/paint/paint_property_tree_builder.h
    • M third_party/blink/renderer/core/paint/paint_property_tree_printer.cc
    • M third_party/blink/renderer/core/style/computed_style.cc
    • M third_party/blink/renderer/core/style/computed_style.h
    • D third_party/blink/web_tests/wpt_internal/overscroll-gestures/overscroll-container-overlay.html
    • D third_party/blink/web_tests/wpt_internal/overscroll-gestures/overscroll-multiple-overlay-expected.txt
    • D third_party/blink/web_tests/wpt_internal/overscroll-gestures/overscroll-multiple-overlay.html
    • D third_party/blink/web_tests/wpt_internal/overscroll-gestures/overscroll-multiple.html
    • M third_party/blink/web_tests/wpt_internal/overscroll-gestures/overscroll-negative-scroll.html
    Change size: L
    Delta: 28 files changed, 113 insertions(+), 816 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Robert Flack, Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I188446aaee10b9d1a1d515bb52ebac514fe2e7e8
    Gerrit-Change-Number: 7653382
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages