Rename StyleImage::IsAccessAllowed() to IsSameOrigin() [chromium/src : main]

0 views

Skip to first unread message

Fredrik Söderquist (Gerrit)

unread,

Apr 16, 2026, 4:19:29 AM (3 days ago) Apr 16

to Stephen Chenney, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org

Attention needed from Stephen Chenney

Fredrik Söderquist voted Auto-Submit+1

Auto-Submit

Open in Gerrit

Related details

Attention is currently required from:

Stephen Chenney

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Stephen Chenney (Gerrit)

unread,

Apr 16, 2026, 11:22:17 AM (2 days ago) Apr 16

to Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org

Attention needed from Fredrik Söderquist

Stephen Chenney added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Stephen Chenney . resolved

Please make it IsCorsSameOrigin, because at the end of the day that's what it's actually checking and the most accurate assessment of what it means to allow access. See ImageResource::IsAccessAllowed
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/loader/resource/image_resource.cc;drc=ab3903cafa49d204b050a363fc6a835e366b75b5;l=661