[animation-trigger] Introduce StyleTriggerAttachment [chromium/src : main]
0 views
Skip to first unread message
AI Code Reviewer (Gerrit)
Sep 4, 2025, 2:47:04 PM (5 days ago) Sep 4
to David Awogbemila, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
AI Code Reviewer added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/style/style_trigger_attachment.h
Line 42, Patchset 1 (Latest):
HeapVector<std::pair<AtomicString, AtomicString>> action_behavior_pairs_;AI Code Reviewer . unresolved
Blink Style Guide: Prefer blink:: types over STL and base types. Please use `WTF::KeyValuePair` instead of `std::pair`.
***
_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options: \
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason \
\
This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent). \
AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve. \
[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Awogbemila (Gerrit)
Sep 4, 2025, 4:15:04 PM (5 days ago) Sep 4
to Anders Hartvoll Ruud, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud
David Awogbemila added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/style/style_trigger_attachment.h
Line 42, Patchset 1:
HeapVector<std::pair<AtomicString, AtomicString>> action_behavior_pairs_;AI Code Reviewer . resolved
Blink Style Guide: Prefer blink:: types over STL and base types. Please use `WTF::KeyValuePair` instead of `std::pair`.
***_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options: \
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason \
\
This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent). \
AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve. \
[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
David Awogbemila
Won't fix: "error: static assertion failed due to requirement 'internal::IsTraceableV<blink::KeyValuePair"
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Sep 5, 2025, 4:55:05 AM (5 days ago) Sep 5
to David Awogbemila, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from David Awogbemila
Anders Hartvoll Ruud added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Anders Hartvoll Ruud . unresolved
Same comment as in CL:6917514: we should not land untested and unexercised code. I'd merge it into the next CL.
Related details
Attention is currently required from:
- David Awogbemila
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Awogbemila (Gerrit)
Sep 8, 2025, 10:59:31 AM (yesterday) Sep 8
to Anders Hartvoll Ruud, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud
David Awogbemila added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Anders Hartvoll Ruud . resolved
Same comment as in CL:6917514: we should not land untested and unexercised code. I'd merge it into the next CL.
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Awogbemila (Gerrit)
Sep 8, 2025, 10:59:44 AM (yesterday) Sep 8
to Anders Hartvoll Ruud, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
David Awogbemila abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages