Fix polygon() rounding radius clamping formula [chromium/src : main]
0 views
Skip to first unread message
Jason Leo (Gerrit)
Apr 10, 2026, 7:03:39 AM (9 days ago) Apr 10
to Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Fredrik Söderquist
Jason Leo added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
Apr 10, 2026, 7:55:24 AM (9 days ago) Apr 10
to Jason Leo, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Jason Leo
Fredrik Söderquist added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/css/css-borders/border-shape/border-shape-polygon-rounding-clamp.html
Fredrik Söderquist . unresolved
It feels like these tests should have a stronger affinity to `css-shapes` (rather than `css-borders`) since it's testing behavior from that spec. I think it would also be better to not rely on `border-shape` for these tests.
Related details
Attention is currently required from:
- Jason Leo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jason Leo (Gerrit)
Apr 15, 2026, 7:40:13 AM (4 days ago) Apr 15
to Fredrik Söderquist, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Fredrik Söderquist
Jason Leo voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jason Leo
| Commit-Queue | +1 |
1 comment
File third_party/blink/web_tests/external/wpt/css/css-borders/border-shape/border-shape-polygon-rounding-clamp.html
It feels like these tests should have a stronger affinity to `css-shapes` (rather than `css-borders`) since it's testing behavior from that spec. I think it would also be better to not rely on `border-shape` for these tests.
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
Apr 15, 2026, 8:28:23 AM (4 days ago) Apr 15
to Jason Leo, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Jason Leo
Fredrik Söderquist voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jason Leo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jason Leo (Gerrit)
Apr 15, 2026, 9:16:25 AM (3 days ago) Apr 15
to Fredrik Söderquist, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Jason Leo voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jason Leo
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 15, 2026, 9:22:28 AM (3 days ago) Apr 15
to Jason Leo, Fredrik Söderquist, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/59236.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Apr 15, 2026, 9:26:58 AM (3 days ago) Apr 15
to Jason Leo, Blink W3C Test Autoroller, Fredrik Söderquist, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Fix polygon() rounding radius clamping formula
The clamping formula in ComputeRoundedPolygonVertex used tan(θ/2) where
θ is the angle between the edge direction vectors, but the spec defines
the clamp in terms of the interior angle α = π − θ, giving tan(α/2) =
1/tan(θ/2).
This caused max_radius and tangent_distance to use inverted factors:
multiplication instead of division and vice-versa. The bug was invisible
at 90° vertices (tan(45°) = 1) but produced wrong clamping at all other
angles — triangles, pentagons, and other non-rectangular polygons.
The fix computes the interior angle directly (by negating the dot
product) so the clamping and tangent-distance formulas read exactly as
the spec writes them:
max_radius = tan(α/2) × segment / 2
tangent_distance = radius / tan(α/2)
A WPT reftest under css-shapes/shape-functions exercises clamping across
five polygon shapes using clip-path. The reference uses exact clamped
radii where possible (rectangle, equilateral triangle, diamond) and
overclamped 9999px for shapes with non-uniform vertex angles (pentagon,
isosceles triangle).
Bug: 329302249
Change-Id: I1e55f843d07b5688ad045e1b062461381379c5d5
Commit-Queue: Jason Leo <cg...@chromium.org>
Reviewed-by: Fredrik Söderquist <f...@opera.com>
Cr-Commit-Position: refs/heads/main@{#1615110}
Files:
- M third_party/blink/renderer/core/style/basic_shapes.cc
- A third_party/blink/web_tests/external/wpt/css/css-shapes/shape-functions/polygon-function-rounding-clamp-ref.html
- A third_party/blink/web_tests/external/wpt/css/css-shapes/shape-functions/polygon-function-rounding-clamp.html
Change size: M
Delta: 3 files changed, 111 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Fredrik Söderquist
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 15, 2026, 10:34:52 AM (3 days ago) Apr 15
to chromiu...@luci-project-accounts.iam.gserviceaccount.com, Jason Leo, Fredrik Söderquist, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/59236
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages