[gap-decorations] Allow gap decorations to apply to -webkit-box [chromium/src : main]

0 views
Skip to first unread message

Chromium LUCI CQ (Gerrit)

unread,
May 12, 2026, 8:51:10 PM (2 days ago) May 12
to Ian Kilpatrick, Blink W3C Test Autoroller, Sam Davis Omekara, Kevin Babbitt, Javier Fernandez, Menard, Alexis, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org

Chromium LUCI CQ submitted the change

Unreviewed changes

9 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[gap-decorations] Allow gap decorations to apply to -webkit-box

There should be minimal differences between display:flex and
display:-webkit-box.

Both display types respect the "gap" property. This patch makes it such
that -webkit-box also respects the "rule" properties.
Change-Id: I70e74a4a2011d22e6a709da2df29ecea1cb54383
Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
Reviewed-by: Kevin Babbitt <kbab...@microsoft.com>
Reviewed-by: Sam Davis Omekara <samome...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1629668}
Files:
  • M third_party/blink/renderer/core/style/computed_style.h
  • A third_party/blink/web_tests/external/wpt/css/css-gaps/flex/webkit-box.tentative.html
Change size: S
Delta: 2 files changed, 30 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Sam Davis Omekara, +1 by Kevin Babbitt
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I70e74a4a2011d22e6a709da2df29ecea1cb54383
Gerrit-Change-Number: 7836744
Gerrit-PatchSet: 11
Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Reviewer: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
open
diffy
satisfied_requirement

Blink W3C Test Autoroller (Gerrit)

unread,
May 12, 2026, 10:28:24 PM (2 days ago) May 12
to Chromium LUCI CQ, Ian Kilpatrick, Sam Davis Omekara, Kevin Babbitt, Javier Fernandez, Menard, Alexis, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/59837

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I70e74a4a2011d22e6a709da2df29ecea1cb54383
Gerrit-Change-Number: 7836744
Gerrit-PatchSet: 11
Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Reviewer: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Comment-Date: Wed, 13 May 2026 02:28:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages