[border-shape] Fix dynamic border-color update for border-shape [chromium/src : main]
0 views
Skip to first unread message
Daniil Sakhapov (Gerrit)
Apr 14, 2026, 9:06:55 AM (4 days ago) Apr 14
to Rune Lillesveen, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Rune Lillesveen
Daniil Sakhapov voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rune Lillesveen (Gerrit)
Apr 14, 2026, 10:55:09 AM (4 days ago) Apr 14
to Daniil Sakhapov, Rune Lillesveen, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Daniil Sakhapov
Rune Lillesveen voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Daniil Sakhapov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 14, 2026, 11:14:19 AM (4 days ago) Apr 14
to Daniil Sakhapov, Rune Lillesveen, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Daniil Sakhapov
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/59212.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Daniil Sakhapov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniil Sakhapov (Gerrit)
Apr 14, 2026, 12:03:12 PM (4 days ago) Apr 14
to Blink W3C Test Autoroller, Rune Lillesveen, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Daniil Sakhapov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Apr 14, 2026, 12:07:44 PM (4 days ago) Apr 14
to Daniil Sakhapov, Blink W3C Test Autoroller, Rune Lillesveen, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[border-shape] Fix dynamic border-color update for border-shape
BorderVisuallyEqual was skipping color comparisons when border-style
is 'none'. However, border-shape can still render a fill between two
shapes even with border-style: none. This change ensures color
updates are detected when border-shape is present and adds an
equality check for the border-shape property itself.
Fixed: 501626909
Change-Id: Ifda0aa5064f128ce6e9b02060c66a86e60c9e78d
Reviewed-by: Rune Lillesveen <fut...@chromium.org>
Commit-Queue: Daniil Sakhapov <sakh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1614520}
Files:
- M third_party/blink/renderer/core/style/computed_style.h
- A third_party/blink/web_tests/external/wpt/css/css-borders/border-shape/border-shape-dynamic-color-ref.html
- A third_party/blink/web_tests/external/wpt/css/css-borders/border-shape/border-shape-dynamic-color.html
Change size: M
Delta: 3 files changed, 48 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rune Lillesveen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 14, 2026, 10:16:00 PM (4 days ago) Apr 14
to chromiu...@luci-project-accounts.iam.gserviceaccount.com, Daniil Sakhapov, Rune Lillesveen, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/59212
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages