[FileSystemAccess] Fix internal Content URI blocklist bypasses on Android [chromium/src : main]

0 views
Skip to first unread message

Nate Chapin (Gerrit)

unread,
1:55 PM (7 hours ago) 1:55 PM
to Balazs Engedy, SLSA Policy Verification Service, Hongchan Choi, Hu, Ningxin, Andrew Rayskiy, (Julie)Jeongeun Kim, Sinan Sahin, Enterprise Policy Reviews, Ale Bzk, Gazal Agarwal, Sam Zackrisson, Daniel Cheng, Raphael Kubo da Costa, Hans Wennborg, Christian Biesinger, Mirko Bonadei, Fredrik Söderquist, Lei Zhang, Stephen Chenney, Jerome Jiang, Robert Kroeger, Menard, Alexis, Rijubrata Bhaumik, Nikhil Nayunigari, Per Åhgren, Charles Hager, David Worsham, Khushal Sagar, Olga Gerchikov, Eleanor Lee, Kevin Babbitt, Moe Adel, Mark Schillaci, Ryan Sultanem, James Maclean, Zijie He, Kentaro Hara, Jiewei Qian, Shu Yang, Simon Hangl, Linyu He, Dirk Schulze, Chromium Metrics Reviews, ChromeOS Gardener Code Reviews, Benoit Lize, Code Review Nudger, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Permissions Reviews, Peter Beverloo, Chromium LUCI CQ, abigailbk...@google.com, mattsimm...@chromium.org, odejesu...@chromium.org, aakalla...@chromium.org, jdeblas...@chromium.org, wychen...@chromium.org, telemetr...@chromium.org, msrame...@chromium.org, vinnypersky+...@google.com, bmcquad...@chromium.org, jshin...@chromium.org, cros-print...@google.com, chromeos-kio...@google.com, mfoltz+wa...@chromium.org, mar...@chromium.org, khorimoto+w...@chromium.org, hsuregan+wa...@chromium.org, ydago...@chromium.org, chrome-b...@google.com, npm+...@chromium.org, hais+wat...@google.com, jmedle...@chromium.org, mac-r...@chromium.org, omnibox-...@chromium.org, mschillaci...@google.com, marq+...@chromium.org, eic+...@google.com, yhanada+...@chromium.org, gavin...@chromium.org, blink-reviews-p...@chromium.org, yuzo+...@chromium.org, philli...@chromium.org, mbarowsky+watc...@chromium.org, webapks-...@chromium.org, drott+bl...@chromium.org, blink-rev...@chromium.org, cblume+im...@chromium.org, emi...@google.com, johnche...@chromium.org, rsesek...@chromium.org, wfh+...@chromium.org, nektar...@chromium.org, chungshe...@google.com, xinghui...@chromium.org, asvitkine...@chromium.org, jackshira+w...@google.com, gogeral...@chromium.org, tmartino+tran...@chromium.org, bling-ai-foundatio...@google.com, crmulli...@chromium.org, gcasto+w...@chromium.org, sky+...@chromium.org, zol...@webkit.org, dtseng...@chromium.org, performance-m...@chromium.org, asvitki...@chromium.org, jorgel...@chromium.org, dtapuska+...@chromium.org, martijn...@martijnc.be, cwalle...@chromium.org, dibyapal+wa...@chromium.org, android-web...@chromium.org, media-cro...@chromium.org, ajayramamurth...@google.com, dullweb...@chromium.org, enne...@chromium.org, ozone-...@chromium.org, blink-re...@chromium.org, oshima...@chromium.org, blink-revie...@chromium.org, dmurph+watch...@chromium.org, hanxi...@chromium.org, chrome-regionalc...@google.com, khorimoto+wa...@chromium.org, blink-revie...@chromium.org, fserb...@chromium.org, apavlo...@chromium.org, chromium-a...@chromium.org, stevenjb+wa...@chromium.org, blink-re...@chromium.org, jbrom...@chromium.org, dclasson+w...@google.com, hidehik...@chromium.org, alexmo...@chromium.org, mattreyno...@chromium.org, pkotwic...@chromium.org, siashah+au...@chromium.org, blink-revi...@chromium.org, lize...@chromium.org, hansberry+w...@chromium.org, speed-metrics...@chromium.org, chadduffin+w...@chromium.org, yongshun+...@google.com, chrome-intell...@chromium.org, chasej...@chromium.org, katie...@chromium.org, osaul+aut...@google.com, jeffreycohen+watc...@chromium.org, grt+...@chromium.org, pdr+svgw...@chromium.org, pushi+wat...@google.com, chadduffin+w...@chromium.org, feature-me...@chromium.org, suetfei+wa...@google.com, hansenmichael...@google.com, blink-work...@chromium.org, chromiumme...@microsoft.com, chromotin...@chromium.org, penghu...@chromium.org, ramyagopa...@google.com, loading-re...@chromium.org, roblia...@chromium.org, crisrael+w...@google.com, penghuan...@chromium.org, horo+...@chromium.org, kouhe...@chromium.org, bartek...@chromium.org, vakh+safe_br...@chromium.org, blink-...@chromium.org, loading-rev...@chromium.org, nicolas...@chromium.org, rrsilva+wat...@google.com, chfreme...@chromium.org, gavin...@chromium.org, dtraino...@chromium.org, halliwe...@chromium.org, chlily...@chromium.org, mfoltz+wa...@chromium.org, chrome-intelligence-te...@google.com, weiluanw...@google.com, siyua+aut...@chromium.org, devtools...@chromium.org, filesapp...@chromium.org, dewitt...@chromium.org, meilian...@chromium.org, nwoked...@chromium.org, ios-revie...@chromium.org, niharm...@google.com, byronle...@chromium.org, feature-v...@chromium.org, net-r...@chromium.org, spang...@chromium.org, cblume...@chromium.org, jiajunz+wat...@google.com, fmalit...@chromium.org, prerenderi...@chromium.org, media-wi...@chromium.org, ios-r...@chromium.org, peilinwa...@google.com, knollr+wat...@chromium.org, davidj...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, chrome-tab-group-en...@google.com, lwinston+watc...@google.com, dmurph+watc...@chromium.org, derinel+wat...@google.com, armalhotra+a...@google.com, ender...@chromium.org, xlythe+wa...@google.com, jatapiaro+wat...@google.com, chromeos-gfx-...@google.com, blink-rev...@chromium.org, zelin+watch-we...@chromium.org, dmurph+wa...@chromium.org, titoua...@chromium.org, tburkar...@chromium.org, nona+...@chromium.org, dmurph+wat...@chromium.org, ortuno+w...@chromium.org, wnwen...@chromium.org, shuche...@chromium.org, loading-rev...@chromium.org, danakj...@chromium.org, speed-metr...@chromium.org, josiah...@chromium.org, christia...@chromium.org, yhanad...@chromium.org, creis...@chromium.org, keithle...@chromium.org, fgal...@chromium.org, srahim...@chromium.org, hirokisa...@chromium.org, iclella...@chromium.org, fuchsia...@chromium.org, loading...@chromium.org, webap...@microsoft.com, ejcaruso+wa...@chromium.org, tracing...@chromium.org, pdf-r...@chromium.org, cbe-cep-eng...@google.com, jdonnel...@chromium.org, sloboda...@chromium.org, aixba+wat...@chromium.org, shannc...@chromium.org, droger+w...@chromium.org, kinuko...@chromium.org, tbarzi...@chromium.org, orinj...@chromium.org, webauthn...@chromium.org, menghua...@google.com, mpdento...@chromium.org, ios-actor...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, hsuregan+wa...@chromium.org, navigation...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, anastas...@google.com, print-rev...@chromium.org, shimazu...@chromium.org, ejcaruso+wa...@chromium.org, kuragin+web-ap...@chromium.org, kainin...@chromium.org, ortuno+wat...@chromium.org, cc-...@chromium.org, yuezhang...@chromium.org, arc-review...@google.com, blink-revie...@chromium.org, extension...@chromium.org, japhet+...@chromium.org, loyso...@chromium.org, jimmyxgong+watch...@chromium.org, tgupta...@chromium.org, trewin...@google.com, network-ser...@chromium.org, rsleev...@chromium.org, edgesto...@microsoft.com, kyungjunle...@google.com, rmcelra...@chromium.org, jackshira+w...@google.com, drott...@chromium.org, csharris...@chromium.org, blink-revi...@chromium.org, jiajunz+wa...@google.com, mek+w...@chromium.org, croissant-...@chromium.org, mgiuca...@chromium.org, aleventh...@chromium.org, dcheng+c...@chromium.org, zackha...@chromium.org, lucasrada...@google.com, tranbaod...@chromium.org, thegreenf...@chromium.org, yusufo...@chromium.org, dennyh...@google.com, jonmann+wa...@chromium.org, blink-rev...@chromium.org, jz...@chromium.org, yigu+...@chromium.org, security-...@chromium.org, agriev...@chromium.org, lizeb+watch...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, storage...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Balazs Engedy and Benoit Lize

Nate Chapin added 1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Nate Chapin . resolved

engedy: PTAL at chrome/browser/file_system_access/

Open in Gerrit

Related details

Attention is currently required from:
  • Balazs Engedy
  • Benoit Lize
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I369b05fa63e0157c2ddb42e83ffb5d627d503bc2
Gerrit-Change-Number: 7986593
Gerrit-PatchSet: 8
Gerrit-Owner: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: Balazs Engedy <eng...@chromium.org>
Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Ale Bzk <ales...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Charles Hager <clh...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: ChromeOS Gardener Code Reviews <chrome-os-gar...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Eleanor Lee <elean...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Gazal Agarwal <aga...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Khushal Sagar <khusha...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Linyu He <lin...@google.com>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-CC: Moe Adel <ad...@google.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Per Åhgren <pe...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Ryan Sultanem <rs...@google.com>
Gerrit-CC: Sam Zackrisson <sa...@chromium.org>
Gerrit-CC: Shu Yang <shu...@google.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Sinan Sahin <sinan...@google.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Benoit Lize <li...@chromium.org>
Gerrit-Attention: Balazs Engedy <eng...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Jul 2026 17:55:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Joel Hockey (Gerrit)

unread,
6:53 PM (2 hours ago) 6:53 PM
to Nate Chapin, Joel Hockey, Balazs Engedy, SLSA Policy Verification Service, Hongchan Choi, Hu, Ningxin, Andrew Rayskiy, (Julie)Jeongeun Kim, Sinan Sahin, Enterprise Policy Reviews, Ale Bzk, Gazal Agarwal, Sam Zackrisson, Daniel Cheng, Raphael Kubo da Costa, Hans Wennborg, Christian Biesinger, Mirko Bonadei, Fredrik Söderquist, Lei Zhang, Stephen Chenney, Jerome Jiang, Robert Kroeger, Menard, Alexis, Rijubrata Bhaumik, Nikhil Nayunigari, Per Åhgren, Charles Hager, David Worsham, Khushal Sagar, Olga Gerchikov, Eleanor Lee, Kevin Babbitt, Moe Adel, Mark Schillaci, Ryan Sultanem, James Maclean, Zijie He, Kentaro Hara, Jiewei Qian, Shu Yang, Simon Hangl, Linyu He, Dirk Schulze, Chromium Metrics Reviews, ChromeOS Gardener Code Reviews, Benoit Lize, Code Review Nudger, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Permissions Reviews, Peter Beverloo, Chromium LUCI CQ, abigailbk...@google.com, mattsimm...@chromium.org, odejesu...@chromium.org, aakalla...@chromium.org, jdeblas...@chromium.org, wychen...@chromium.org, telemetr...@chromium.org, msrame...@chromium.org, vinnypersky+...@google.com, bmcquad...@chromium.org, jshin...@chromium.org, cros-print...@google.com, chromeos-kio...@google.com, mfoltz+wa...@chromium.org, mar...@chromium.org, khorimoto+w...@chromium.org, hsuregan+wa...@chromium.org, ydago...@chromium.org, chrome-b...@google.com, npm+...@chromium.org, hais+wat...@google.com, jmedle...@chromium.org, mac-r...@chromium.org, omnibox-...@chromium.org, mschillaci...@google.com, marq+...@chromium.org, eic+...@google.com, yhanada+...@chromium.org, gavin...@chromium.org, blink-reviews-p...@chromium.org, yuzo+...@chromium.org, philli...@chromium.org, mbarowsky+watc...@chromium.org, webapks-...@chromium.org, drott+bl...@chromium.org, blink-rev...@chromium.org, cblume+im...@chromium.org, emi...@google.com, johnche...@chromium.org, rsesek...@chromium.org, wfh+...@chromium.org, nektar...@chromium.org, chungshe...@google.com, xinghui...@chromium.org, asvitkine...@chromium.org, jackshira+w...@google.com, gogeral...@chromium.org, tmartino+tran...@chromium.org, bling-ai-foundatio...@google.com, crmulli...@chromium.org, gcasto+w...@chromium.org, sky+...@chromium.org, zol...@webkit.org, dtseng...@chromium.org, performance-m...@chromium.org, asvitki...@chromium.org, jorgel...@chromium.org, dtapuska+...@chromium.org, martijn...@martijnc.be, cwalle...@chromium.org, dibyapal+wa...@chromium.org, android-web...@chromium.org, media-cro...@chromium.org, ajayramamurth...@google.com, dullweb...@chromium.org, enne...@chromium.org, ozone-...@chromium.org, blink-re...@chromium.org, oshima...@chromium.org, blink-revie...@chromium.org, dmurph+watch...@chromium.org, hanxi...@chromium.org, chrome-regionalc...@google.com, khorimoto+wa...@chromium.org, blink-revie...@chromium.org, fserb...@chromium.org, apavlo...@chromium.org, chromium-a...@chromium.org, stevenjb+wa...@chromium.org, blink-re...@chromium.org, jbrom...@chromium.org, dclasson+w...@google.com, hidehik...@chromium.org, alexmo...@chromium.org, mattreyno...@chromium.org, pkotwic...@chromium.org, siashah+au...@chromium.org, blink-revi...@chromium.org, lize...@chromium.org, hansberry+w...@chromium.org, speed-metrics...@chromium.org, chadduffin+w...@chromium.org, yongshun+...@google.com, chrome-intell...@chromium.org, chasej...@chromium.org, katie...@chromium.org, osaul+aut...@google.com, jeffreycohen+watc...@chromium.org, grt+...@chromium.org, pdr+svgw...@chromium.org, pushi+wat...@google.com, chadduffin+w...@chromium.org, feature-me...@chromium.org, suetfei+wa...@google.com, hansenmichael...@google.com, blink-work...@chromium.org, chromiumme...@microsoft.com, chromotin...@chromium.org, penghu...@chromium.org, ramyagopa...@google.com, loading-re...@chromium.org, roblia...@chromium.org, crisrael+w...@google.com, penghuan...@chromium.org, horo+...@chromium.org, kouhe...@chromium.org, bartek...@chromium.org, vakh+safe_br...@chromium.org, blink-...@chromium.org, loading-rev...@chromium.org, nicolas...@chromium.org, rrsilva+wat...@google.com, chfreme...@chromium.org, gavin...@chromium.org, dtraino...@chromium.org, halliwe...@chromium.org, chlily...@chromium.org, mfoltz+wa...@chromium.org, chrome-intelligence-te...@google.com, weiluanw...@google.com, siyua+aut...@chromium.org, devtools...@chromium.org, filesapp...@chromium.org, dewitt...@chromium.org, meilian...@chromium.org, nwoked...@chromium.org, ios-revie...@chromium.org, niharm...@google.com, byronle...@chromium.org, feature-v...@chromium.org, net-r...@chromium.org, spang...@chromium.org, cblume...@chromium.org, jiajunz+wat...@google.com, fmalit...@chromium.org, prerenderi...@chromium.org, media-wi...@chromium.org, ios-r...@chromium.org, peilinwa...@google.com, knollr+wat...@chromium.org, davidj...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, chrome-tab-group-en...@google.com, lwinston+watc...@google.com, dmurph+watc...@chromium.org, derinel+wat...@google.com, armalhotra+a...@google.com, ender...@chromium.org, xlythe+wa...@google.com, jatapiaro+wat...@google.com, chromeos-gfx-...@google.com, blink-rev...@chromium.org, zelin+watch-we...@chromium.org, dmurph+wa...@chromium.org, titoua...@chromium.org, tburkar...@chromium.org, nona+...@chromium.org, dmurph+wat...@chromium.org, ortuno+w...@chromium.org, wnwen...@chromium.org, shuche...@chromium.org, loading-rev...@chromium.org, danakj...@chromium.org, speed-metr...@chromium.org, josiah...@chromium.org, christia...@chromium.org, yhanad...@chromium.org, creis...@chromium.org, keithle...@chromium.org, fgal...@chromium.org, srahim...@chromium.org, hirokisa...@chromium.org, iclella...@chromium.org, fuchsia...@chromium.org, loading...@chromium.org, webap...@microsoft.com, ejcaruso+wa...@chromium.org, tracing...@chromium.org, pdf-r...@chromium.org, cbe-cep-eng...@google.com, jdonnel...@chromium.org, sloboda...@chromium.org, aixba+wat...@chromium.org, shannc...@chromium.org, droger+w...@chromium.org, kinuko...@chromium.org, tbarzi...@chromium.org, orinj...@chromium.org, webauthn...@chromium.org, menghua...@google.com, mpdento...@chromium.org, ios-actor...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, hsuregan+wa...@chromium.org, navigation...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, anastas...@google.com, print-rev...@chromium.org, shimazu...@chromium.org, ejcaruso+wa...@chromium.org, kuragin+web-ap...@chromium.org, kainin...@chromium.org, ortuno+wat...@chromium.org, cc-...@chromium.org, yuezhang...@chromium.org, arc-review...@google.com, blink-revie...@chromium.org, extension...@chromium.org, japhet+...@chromium.org, loyso...@chromium.org, jimmyxgong+watch...@chromium.org, tgupta...@chromium.org, trewin...@google.com, network-ser...@chromium.org, rsleev...@chromium.org, edgesto...@microsoft.com, kyungjunle...@google.com, rmcelra...@chromium.org, jackshira+w...@google.com, drott...@chromium.org, csharris...@chromium.org, blink-revi...@chromium.org, jiajunz+wa...@google.com, mek+w...@chromium.org, croissant-...@chromium.org, mgiuca...@chromium.org, aleventh...@chromium.org, dcheng+c...@chromium.org, zackha...@chromium.org, lucasrada...@google.com, tranbaod...@chromium.org, thegreenf...@chromium.org, yusufo...@chromium.org, dennyh...@google.com, jonmann+wa...@chromium.org, blink-rev...@chromium.org, jz...@chromium.org, yigu+...@chromium.org, security-...@chromium.org, agriev...@chromium.org, lizeb+watch...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, storage...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Balazs Engedy, Benoit Lize and Nate Chapin

Joel Hockey added 2 comments

File base/android/content_uri_utils.h
Line 69, Patchset 8 (Latest):// invalid.
Joel Hockey . unresolved

This comment belongs to GetContentUriMimeType() below

File base/test/android/java/AndroidManifest_file_provider.xml
Line 19, Patchset 8 (Latest): android:authorities="${applicationId}.inmemory;${applicationId}"
Joel Hockey . unresolved

why is this changing?

Open in Gerrit

Related details

Attention is currently required from:
  • Balazs Engedy
  • Benoit Lize
  • Nate Chapin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Gerrit-CC: Joel Hockey <joelh...@chromium.org>
    Gerrit-Attention: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Balazs Engedy <eng...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Jul 2026 22:53:13 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Joel Hockey (Gerrit)

    unread,
    6:54 PM (2 hours ago) 6:54 PM
    to Nate Chapin, Joel Hockey, Balazs Engedy, SLSA Policy Verification Service, Hongchan Choi, Hu, Ningxin, Andrew Rayskiy, (Julie)Jeongeun Kim, Sinan Sahin, Enterprise Policy Reviews, Ale Bzk, Gazal Agarwal, Sam Zackrisson, Daniel Cheng, Raphael Kubo da Costa, Hans Wennborg, Christian Biesinger, Mirko Bonadei, Fredrik Söderquist, Lei Zhang, Stephen Chenney, Jerome Jiang, Robert Kroeger, Menard, Alexis, Rijubrata Bhaumik, Nikhil Nayunigari, Per Åhgren, Charles Hager, David Worsham, Khushal Sagar, Olga Gerchikov, Eleanor Lee, Kevin Babbitt, Moe Adel, Mark Schillaci, Ryan Sultanem, James Maclean, Zijie He, Kentaro Hara, Jiewei Qian, Shu Yang, Simon Hangl, Linyu He, Dirk Schulze, Chromium Metrics Reviews, ChromeOS Gardener Code Reviews, Benoit Lize, Code Review Nudger, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Permissions Reviews, Peter Beverloo, Chromium LUCI CQ, abigailbk...@google.com, mattsimm...@chromium.org, odejesu...@chromium.org, aakalla...@chromium.org, jdeblas...@chromium.org, wychen...@chromium.org, telemetr...@chromium.org, msrame...@chromium.org, vinnypersky+...@google.com, bmcquad...@chromium.org, jshin...@chromium.org, cros-print...@google.com, chromeos-kio...@google.com, mfoltz+wa...@chromium.org, mar...@chromium.org, khorimoto+w...@chromium.org, hsuregan+wa...@chromium.org, ydago...@chromium.org, chrome-b...@google.com, npm+...@chromium.org, hais+wat...@google.com, jmedle...@chromium.org, mac-r...@chromium.org, omnibox-...@chromium.org, mschillaci...@google.com, marq+...@chromium.org, eic+...@google.com, yhanada+...@chromium.org, gavin...@chromium.org, blink-reviews-p...@chromium.org, yuzo+...@chromium.org, philli...@chromium.org, mbarowsky+watc...@chromium.org, webapks-...@chromium.org, drott+bl...@chromium.org, blink-rev...@chromium.org, cblume+im...@chromium.org, emi...@google.com, johnche...@chromium.org, rsesek...@chromium.org, wfh+...@chromium.org, nektar...@chromium.org, chungshe...@google.com, xinghui...@chromium.org, asvitkine...@chromium.org, jackshira+w...@google.com, gogeral...@chromium.org, tmartino+tran...@chromium.org, bling-ai-foundatio...@google.com, crmulli...@chromium.org, gcasto+w...@chromium.org, sky+...@chromium.org, zol...@webkit.org, dtseng...@chromium.org, performance-m...@chromium.org, asvitki...@chromium.org, jorgel...@chromium.org, dtapuska+...@chromium.org, martijn...@martijnc.be, cwalle...@chromium.org, dibyapal+wa...@chromium.org, android-web...@chromium.org, media-cro...@chromium.org, ajayramamurth...@google.com, dullweb...@chromium.org, enne...@chromium.org, ozone-...@chromium.org, blink-re...@chromium.org, oshima...@chromium.org, blink-revie...@chromium.org, dmurph+watch...@chromium.org, hanxi...@chromium.org, chrome-regionalc...@google.com, khorimoto+wa...@chromium.org, blink-revie...@chromium.org, fserb...@chromium.org, apavlo...@chromium.org, chromium-a...@chromium.org, stevenjb+wa...@chromium.org, blink-re...@chromium.org, jbrom...@chromium.org, dclasson+w...@google.com, hidehik...@chromium.org, alexmo...@chromium.org, mattreyno...@chromium.org, pkotwic...@chromium.org, siashah+au...@chromium.org, blink-revi...@chromium.org, lize...@chromium.org, hansberry+w...@chromium.org, speed-metrics...@chromium.org, chadduffin+w...@chromium.org, yongshun+...@google.com, chrome-intell...@chromium.org, chasej...@chromium.org, katie...@chromium.org, osaul+aut...@google.com, jeffreycohen+watc...@chromium.org, grt+...@chromium.org, pdr+svgw...@chromium.org, pushi+wat...@google.com, chadduffin+w...@chromium.org, feature-me...@chromium.org, suetfei+wa...@google.com, hansenmichael...@google.com, blink-work...@chromium.org, chromiumme...@microsoft.com, chromotin...@chromium.org, penghu...@chromium.org, ramyagopa...@google.com, loading-re...@chromium.org, roblia...@chromium.org, crisrael+w...@google.com, penghuan...@chromium.org, horo+...@chromium.org, kouhe...@chromium.org, bartek...@chromium.org, vakh+safe_br...@chromium.org, blink-...@chromium.org, loading-rev...@chromium.org, nicolas...@chromium.org, rrsilva+wat...@google.com, chfreme...@chromium.org, gavin...@chromium.org, dtraino...@chromium.org, halliwe...@chromium.org, chlily...@chromium.org, mfoltz+wa...@chromium.org, chrome-intelligence-te...@google.com, weiluanw...@google.com, siyua+aut...@chromium.org, devtools...@chromium.org, filesapp...@chromium.org, dewitt...@chromium.org, meilian...@chromium.org, nwoked...@chromium.org, ios-revie...@chromium.org, niharm...@google.com, byronle...@chromium.org, feature-v...@chromium.org, net-r...@chromium.org, spang...@chromium.org, cblume...@chromium.org, jiajunz+wat...@google.com, fmalit...@chromium.org, prerenderi...@chromium.org, media-wi...@chromium.org, ios-r...@chromium.org, peilinwa...@google.com, knollr+wat...@chromium.org, davidj...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, chrome-tab-group-en...@google.com, lwinston+watc...@google.com, dmurph+watc...@chromium.org, derinel+wat...@google.com, armalhotra+a...@google.com, ender...@chromium.org, xlythe+wa...@google.com, jatapiaro+wat...@google.com, chromeos-gfx-...@google.com, blink-rev...@chromium.org, zelin+watch-we...@chromium.org, dmurph+wa...@chromium.org, titoua...@chromium.org, tburkar...@chromium.org, nona+...@chromium.org, dmurph+wat...@chromium.org, ortuno+w...@chromium.org, wnwen...@chromium.org, shuche...@chromium.org, loading-rev...@chromium.org, danakj...@chromium.org, speed-metr...@chromium.org, josiah...@chromium.org, christia...@chromium.org, yhanad...@chromium.org, creis...@chromium.org, keithle...@chromium.org, fgal...@chromium.org, srahim...@chromium.org, hirokisa...@chromium.org, iclella...@chromium.org, fuchsia...@chromium.org, loading...@chromium.org, webap...@microsoft.com, ejcaruso+wa...@chromium.org, tracing...@chromium.org, pdf-r...@chromium.org, cbe-cep-eng...@google.com, jdonnel...@chromium.org, sloboda...@chromium.org, aixba+wat...@chromium.org, shannc...@chromium.org, droger+w...@chromium.org, kinuko...@chromium.org, tbarzi...@chromium.org, orinj...@chromium.org, webauthn...@chromium.org, menghua...@google.com, mpdento...@chromium.org, ios-actor...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, hsuregan+wa...@chromium.org, navigation...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, anastas...@google.com, print-rev...@chromium.org, shimazu...@chromium.org, ejcaruso+wa...@chromium.org, kuragin+web-ap...@chromium.org, kainin...@chromium.org, ortuno+wat...@chromium.org, cc-...@chromium.org, yuezhang...@chromium.org, arc-review...@google.com, blink-revie...@chromium.org, extension...@chromium.org, japhet+...@chromium.org, loyso...@chromium.org, jimmyxgong+watch...@chromium.org, tgupta...@chromium.org, trewin...@google.com, network-ser...@chromium.org, rsleev...@chromium.org, edgesto...@microsoft.com, kyungjunle...@google.com, rmcelra...@chromium.org, jackshira+w...@google.com, drott...@chromium.org, csharris...@chromium.org, blink-revi...@chromium.org, jiajunz+wa...@google.com, mek+w...@chromium.org, croissant-...@chromium.org, mgiuca...@chromium.org, aleventh...@chromium.org, dcheng+c...@chromium.org, zackha...@chromium.org, lucasrada...@google.com, tranbaod...@chromium.org, thegreenf...@chromium.org, yusufo...@chromium.org, dennyh...@google.com, jonmann+wa...@chromium.org, blink-rev...@chromium.org, jz...@chromium.org, yigu+...@chromium.org, security-...@chromium.org, agriev...@chromium.org, lizeb+watch...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, storage...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
    Attention needed from Balazs Engedy, Benoit Lize and Nate Chapin

    Joel Hockey voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Balazs Engedy
    • Benoit Lize
    • Nate Chapin
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I369b05fa63e0157c2ddb42e83ffb5d627d503bc2
      Gerrit-Change-Number: 7986593
      Gerrit-PatchSet: 8
      Gerrit-Owner: Nate Chapin <jap...@chromium.org>
      Gerrit-Reviewer: Balazs Engedy <eng...@chromium.org>
      Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
      Gerrit-Reviewer: Joel Hockey <joelh...@chromium.org>
      Gerrit-Comment-Date: Tue, 28 Jul 2026 22:53:40 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Kirubel (Gerrit)

      unread,
      8:50 PM (11 minutes ago) 8:50 PM
      to Nate Chapin, bling-ai-foundatio...@google.com, Joel Hockey, Balazs Engedy, SLSA Policy Verification Service, Hongchan Choi, Hu, Ningxin, Andrew Rayskiy, (Julie)Jeongeun Kim, Sinan Sahin, Enterprise Policy Reviews, Ale Bzk, Gazal Agarwal, Sam Zackrisson, Daniel Cheng, Raphael Kubo da Costa, Hans Wennborg, Christian Biesinger, Mirko Bonadei, Fredrik Söderquist, Lei Zhang, Stephen Chenney, Jerome Jiang, Robert Kroeger, Menard, Alexis, Rijubrata Bhaumik, Nikhil Nayunigari, Per Åhgren, Charles Hager, David Worsham, Khushal Sagar, Olga Gerchikov, Eleanor Lee, Kevin Babbitt, Moe Adel, Mark Schillaci, Ryan Sultanem, James Maclean, Zijie He, Kentaro Hara, Jiewei Qian, Shu Yang, Simon Hangl, Linyu He, Dirk Schulze, Chromium Metrics Reviews, ChromeOS Gardener Code Reviews, Benoit Lize, Code Review Nudger, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Permissions Reviews, Peter Beverloo, Chromium LUCI CQ, abigailbk...@google.com, mattsimm...@chromium.org, odejesu...@chromium.org, aakalla...@chromium.org, jdeblas...@chromium.org, wychen...@chromium.org, telemetr...@chromium.org, msrame...@chromium.org, vinnypersky+...@google.com, bmcquad...@chromium.org, jshin...@chromium.org, cros-print...@google.com, chromeos-kio...@google.com, mfoltz+wa...@chromium.org, mar...@chromium.org, khorimoto+w...@chromium.org, hsuregan+wa...@chromium.org, ydago...@chromium.org, chrome-b...@google.com, npm+...@chromium.org, hais+wat...@google.com, jmedle...@chromium.org, mac-r...@chromium.org, omnibox-...@chromium.org, mschillaci...@google.com, marq+...@chromium.org, eic+...@google.com, yhanada+...@chromium.org, gavin...@chromium.org, blink-reviews-p...@chromium.org, yuzo+...@chromium.org, philli...@chromium.org, mbarowsky+watc...@chromium.org, webapks-...@chromium.org, drott+bl...@chromium.org, blink-rev...@chromium.org, cblume+im...@chromium.org, emi...@google.com, johnche...@chromium.org, rsesek...@chromium.org, wfh+...@chromium.org, nektar...@chromium.org, chungshe...@google.com, xinghui...@chromium.org, asvitkine...@chromium.org, jackshira+w...@google.com, gogeral...@chromium.org, tmartino+tran...@chromium.org, crmulli...@chromium.org, gcasto+w...@chromium.org, sky+...@chromium.org, zol...@webkit.org, dtseng...@chromium.org, performance-m...@chromium.org, asvitki...@chromium.org, jorgel...@chromium.org, dtapuska+...@chromium.org, martijn...@martijnc.be, cwalle...@chromium.org, dibyapal+wa...@chromium.org, android-web...@chromium.org, media-cro...@chromium.org, ajayramamurth...@google.com, dullweb...@chromium.org, enne...@chromium.org, ozone-...@chromium.org, blink-re...@chromium.org, oshima...@chromium.org, blink-revie...@chromium.org, dmurph+watch...@chromium.org, hanxi...@chromium.org, chrome-regionalc...@google.com, khorimoto+wa...@chromium.org, blink-revie...@chromium.org, fserb...@chromium.org, apavlo...@chromium.org, chromium-a...@chromium.org, stevenjb+wa...@chromium.org, blink-re...@chromium.org, jbrom...@chromium.org, dclasson+w...@google.com, hidehik...@chromium.org, alexmo...@chromium.org, mattreyno...@chromium.org, pkotwic...@chromium.org, siashah+au...@chromium.org, blink-revi...@chromium.org, lize...@chromium.org, hansberry+w...@chromium.org, speed-metrics...@chromium.org, chadduffin+w...@chromium.org, yongshun+...@google.com, chrome-intell...@chromium.org, chasej...@chromium.org, katie...@chromium.org, osaul+aut...@google.com, jeffreycohen+watc...@chromium.org, grt+...@chromium.org, pdr+svgw...@chromium.org, pushi+wat...@google.com, chadduffin+w...@chromium.org, feature-me...@chromium.org, suetfei+wa...@google.com, hansenmichael...@google.com, blink-work...@chromium.org, chromiumme...@microsoft.com, chromotin...@chromium.org, penghu...@chromium.org, ramyagopa...@google.com, loading-re...@chromium.org, roblia...@chromium.org, crisrael+w...@google.com, penghuan...@chromium.org, horo+...@chromium.org, kouhe...@chromium.org, bartek...@chromium.org, vakh+safe_br...@chromium.org, blink-...@chromium.org, loading-rev...@chromium.org, nicolas...@chromium.org, rrsilva+wat...@google.com, chfreme...@chromium.org, gavin...@chromium.org, dtraino...@chromium.org, halliwe...@chromium.org, chlily...@chromium.org, mfoltz+wa...@chromium.org, chrome-intelligence-te...@google.com, weiluanw...@google.com, siyua+aut...@chromium.org, devtools...@chromium.org, filesapp...@chromium.org, dewitt...@chromium.org, meilian...@chromium.org, nwoked...@chromium.org, ios-revie...@chromium.org, niharm...@google.com, byronle...@chromium.org, feature-v...@chromium.org, net-r...@chromium.org, spang...@chromium.org, cblume...@chromium.org, jiajunz+wat...@google.com, fmalit...@chromium.org, prerenderi...@chromium.org, media-wi...@chromium.org, ios-r...@chromium.org, peilinwa...@google.com, knollr+wat...@chromium.org, davidj...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, chrome-tab-group-en...@google.com, lwinston+watc...@google.com, dmurph+watc...@chromium.org, derinel+wat...@google.com, armalhotra+a...@google.com, ender...@chromium.org, xlythe+wa...@google.com, jatapiaro+wat...@google.com, chromeos-gfx-...@google.com, blink-rev...@chromium.org, zelin+watch-we...@chromium.org, dmurph+wa...@chromium.org, titoua...@chromium.org, tburkar...@chromium.org, nona+...@chromium.org, dmurph+wat...@chromium.org, ortuno+w...@chromium.org, wnwen...@chromium.org, shuche...@chromium.org, loading-rev...@chromium.org, danakj...@chromium.org, speed-metr...@chromium.org, josiah...@chromium.org, christia...@chromium.org, yhanad...@chromium.org, creis...@chromium.org, keithle...@chromium.org, fgal...@chromium.org, srahim...@chromium.org, hirokisa...@chromium.org, iclella...@chromium.org, fuchsia...@chromium.org, loading...@chromium.org, webap...@microsoft.com, ejcaruso+wa...@chromium.org, tracing...@chromium.org, pdf-r...@chromium.org, cbe-cep-eng...@google.com, jdonnel...@chromium.org, sloboda...@chromium.org, aixba+wat...@chromium.org, shannc...@chromium.org, droger+w...@chromium.org, kinuko...@chromium.org, tbarzi...@chromium.org, orinj...@chromium.org, webauthn...@chromium.org, menghua...@google.com, mpdento...@chromium.org, ios-actor...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, hsuregan+wa...@chromium.org, navigation...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, anastas...@google.com, print-rev...@chromium.org, shimazu...@chromium.org, ejcaruso+wa...@chromium.org, kuragin+web-ap...@chromium.org, kainin...@chromium.org, ortuno+wat...@chromium.org, cc-...@chromium.org, yuezhang...@chromium.org, arc-review...@google.com, blink-revie...@chromium.org, extension...@chromium.org, japhet+...@chromium.org, loyso...@chromium.org, jimmyxgong+watch...@chromium.org, tgupta...@chromium.org, trewin...@google.com, network-ser...@chromium.org, rsleev...@chromium.org, edgesto...@microsoft.com, kyungjunle...@google.com, rmcelra...@chromium.org, jackshira+w...@google.com, drott...@chromium.org, csharris...@chromium.org, blink-revi...@chromium.org, jiajunz+wa...@google.com, mek+w...@chromium.org, croissant-...@chromium.org, mgiuca...@chromium.org, aleventh...@chromium.org, dcheng+c...@chromium.org, zackha...@chromium.org, lucasrada...@google.com, tranbaod...@chromium.org, thegreenf...@chromium.org, yusufo...@chromium.org, dennyh...@google.com, jonmann+wa...@chromium.org, blink-rev...@chromium.org, jz...@chromium.org, yigu+...@chromium.org, security-...@chromium.org, agriev...@chromium.org, lizeb+watch...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, storage...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
      Attention needed from Balazs Engedy, Benoit Lize and Nate Chapin

      Kirubel removed bling-ai-foundatio...@google.com from this change

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Balazs Engedy
      • Benoit Lize
      • Nate Chapin
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: deleteReviewer
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages