Move IsAnimationAffectingProperty into a bitset. [chromium/src : main]
0 views
Skip to first unread message
Steinar H Gunderson (Gerrit)
Jan 20, 2026, 8:55:35 AM (3 days ago) Jan 20
to Olga Gerchikov, chromium...@chromium.org, Menard, Alexis, blink-re...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Steinar H Gunderson has uploaded the change for review![]( "Open in Gerrit")
Commit message
Move IsAnimationAffectingProperty into a bitset.
This makes for slightly faster code, but more importantly, it moves
the knowledge of which properties are animation-affecting into Jinja,
so that the next patch can use it for generating “transition: all”
comparison code.
The behavior should be the same, except that some alias property IDs
(e.g. kAliasWebkitAnimation) are true now and were false before.
This seems like mostly an oversight, but also an inconsequential one.
Change-Id: I3115d7a192d95294f8d8c3fcf8d62d59f0e83585
Change diff
Change information
Files:
- M third_party/blink/renderer/build/scripts/core/css/css_properties.py
- M third_party/blink/renderer/build/scripts/core/css/properties/make_property_bitsets.py
- M third_party/blink/renderer/build/scripts/core/css/properties/templates/property_bitsets.cc.tmpl
- M third_party/blink/renderer/core/animation/css/css_animations.cc
- M third_party/blink/renderer/core/css/css_properties.json5
- M third_party/blink/renderer/core/css/property_bitsets.h
Change size: M
Delta: 6 files changed, 86 insertions(+), 55 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Jan 22, 2026, 6:42:47 AM (yesterday) Jan 22
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Steinar H Gunderson
Anders Hartvoll Ruud voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Steinar H Gunderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steinar H Gunderson (Gerrit)
Jan 22, 2026, 6:42:58 AM (yesterday) Jan 22
to Anders Hartvoll Ruud, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Steinar H Gunderson voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 22, 2026, 7:37:23 AM (yesterday) Jan 22
to Steinar H Gunderson, Anders Hartvoll Ruud, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Move IsAnimationAffectingProperty into a bitset.
This makes for slightly faster code, but more importantly, it moves
the knowledge of which properties are animation-affecting into Jinja,
so that the next patch can use it for generating “transition: all”
comparison code.
The behavior should be the same, except that some alias property IDs
(e.g. kAliasWebkitAnimation) are true now and were false before.
This seems like mostly an oversight, but also an inconsequential one.
Change-Id: I3115d7a192d95294f8d8c3fcf8d62d59f0e83585
Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
Commit-Queue: Steinar H Gunderson <se...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1572904}
Files:
- M third_party/blink/renderer/build/scripts/core/css/css_properties.py
- M third_party/blink/renderer/build/scripts/core/css/properties/make_property_bitsets.py
- M third_party/blink/renderer/build/scripts/core/css/properties/templates/property_bitsets.cc.tmpl
- M third_party/blink/renderer/core/animation/css/css_animations.cc
- M third_party/blink/renderer/core/css/css_properties.json5
- M third_party/blink/renderer/core/css/property_bitsets.h
Change size: M
Delta: 6 files changed, 86 insertions(+), 55 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Anders Hartvoll Ruud
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages