Introduce blink::Vector::append_range() [chromium/src : main]

2 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
Feb 26, 2026, 6:22:52 PM (13 days ago) Feb 26
to Daniel Cheng, Jeremy Roman, Chromium LUCI CQ, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Josh Karlin, Kevin Babbitt, Kenneth R Christiansen, Raphael Kubo da Costa, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Urvang Joshi, Wang, Wei4, Yao Xiao, Yoav Weiss (@Shopify), abigailbk...@google.com, aleventh...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, jz...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, mbarowsky+wat...@chromium.org, mbarowsky+watc...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, npm+...@chromium.org, ricea...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, yhiran...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org
Attention needed from Jeremy Roman

Daniel Cheng added 1 comment

File third_party/blink/renderer/platform/wtf/vector.h
Line 1529, Patchset 2 (Latest): void Append(const U*, wtf_size_t);
Daniel Cheng . unresolved

I guess this should be `UNSAFE_BUFFERS_USAGE` / removed in the future, but that's not something I'm interested in pursuing atm :)

Open in Gerrit

Related details

Attention is currently required from:
  • Jeremy Roman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie4e13024b12ac490621d295b8f01640231a7cd96
Gerrit-Change-Number: 7614687
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Josh Karlin <jka...@chromium.org>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Urvang Joshi <urv...@chromium.org>
Gerrit-CC: Wang, Wei4 <wei4...@intel.com>
Gerrit-CC: Yao Xiao <yao...@chromium.org>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
Gerrit-Comment-Date: Thu, 26 Feb 2026 23:22:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jeremy Roman (Gerrit)

unread,
Feb 27, 2026, 10:48:40 AM (12 days ago) Feb 27
to Daniel Cheng, Jeremy Roman, Chromium LUCI CQ, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Josh Karlin, Kevin Babbitt, Kenneth R Christiansen, Raphael Kubo da Costa, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Urvang Joshi, Wang, Wei4, Yao Xiao, Yoav Weiss (@Shopify), abigailbk...@google.com, aleventh...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, jz...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, mbarowsky+wat...@chromium.org, mbarowsky+watc...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, npm+...@chromium.org, ricea...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, yhiran...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org
Attention needed from Daniel Cheng

Jeremy Roman voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Fri, 27 Feb 2026 15:48:33 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Feb 27, 2026, 11:55:33 AM (12 days ago) Feb 27
    to Daniel Cheng, Jeremy Roman, Chromium LUCI CQ, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Josh Karlin, Kevin Babbitt, Kenneth R Christiansen, Raphael Kubo da Costa, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Urvang Joshi, Wang, Wei4, Yao Xiao, Yoav Weiss (@Shopify), abigailbk...@google.com, aleventh...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, jz...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, mbarowsky+wat...@chromium.org, mbarowsky+watc...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, npm+...@chromium.org, ricea...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, yhiran...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org

    Daniel Cheng voted and added 1 comment

    Votes added by Daniel Cheng

    Commit-Queue+2

    1 comment

    File third_party/blink/renderer/platform/wtf/vector.h
    Line 1529, Patchset 2 (Latest): void Append(const U*, wtf_size_t);
    Daniel Cheng . resolved

    I guess this should be `UNSAFE_BUFFERS_USAGE` / removed in the future, but that's not something I'm interested in pursuing atm :)

    Daniel Cheng

    Acknowledged

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Gerrit-Comment-Date: Fri, 27 Feb 2026 16:55:24 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Feb 27, 2026, 11:58:17 AM (12 days ago) Feb 27
      to Daniel Cheng, Jeremy Roman, Akihiro Ota, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Josh Karlin, Kevin Babbitt, Kenneth R Christiansen, Raphael Kubo da Costa, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Urvang Joshi, Wang, Wei4, Yao Xiao, Yoav Weiss (@Shopify), abigailbk...@google.com, aleventh...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, jz...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, mbarowsky+wat...@chromium.org, mbarowsky+watc...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, npm+...@chromium.org, ricea...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, yhiran...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Introduce blink::Vector::append_range()

      This is analogous to `std::vector::append_range()` in the standard
      library and will replace the current `blink::Vector::AppendSpan()` and
      `blink::Vector::AppendVector()`.
      Bug: 487938766
      Change-Id: Ie4e13024b12ac490621d295b8f01640231a7cd96
      Reviewed-by: Jeremy Roman <jbr...@chromium.org>
      Commit-Queue: Daniel Cheng <dch...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1591600}
      Files:
      • M third_party/blink/renderer/platform/wtf/vector.h
      Change size: S
      Delta: 1 file changed, 25 insertions(+), 9 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Jeremy Roman
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie4e13024b12ac490621d295b8f01640231a7cd96
      Gerrit-Change-Number: 7614687
      Gerrit-PatchSet: 3
      Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
      Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages