Migrate Vector::AppendVector()/Vector::AppendSpan() to append_range() [chromium/src : main]

2 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
Feb 26, 2026, 6:23:18 PM (13 days ago) Feb 26
to Daniel Cheng, Jeremy Roman, Chromium LUCI CQ, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Josh Karlin, Kevin Babbitt, Kenneth R Christiansen, Raphael Kubo da Costa, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Urvang Joshi, Wang, Wei4, Yao Xiao, Yoav Weiss (@Shopify), abigailbk...@google.com, aleventh...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, jz...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, mbarowsky+wat...@chromium.org, mbarowsky+watc...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, npm+...@chromium.org, ricea...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, yhiran...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org
Attention needed from Jeremy Roman

Daniel Cheng added 5 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Daniel Cheng . resolved

This is largely pretty straightforward. I left a comment on some of the more interesting bits.

File third_party/blink/renderer/core/css/counter_style.cc
Line 214, Patchset 1: result.append_range(Vector<wtf_size_t>(repetitions, index));
Daniel Cheng . resolved

I guess this would be a nice place to be able to use `std::views`...

File third_party/blink/renderer/core/fetch/multipart_parser_test.cc
Line 68, Patchset 1: boundary.append_range(base::span_from_cstring("boundary"));
Daniel Cheng . unresolved

I think these should be spelled as `std::string_view("boundary")` but I didn't want to get into that too much here.

My general feeling is:

  • it's probably generally undesirable to implicitly treat classic NUL-terminated C string literals as ranges
  • code that doesn't want the NUL can use `std::string_view`
  • ... code that does want the NUL can use... something else.
File third_party/blink/renderer/core/html/image_document_test.cc
Line 389, Patchset 1: data.append_range(JpegImage());
Daniel Cheng . resolved

This looks a bit silly but is a straightforward translation of the existing code.

It's because we're converting between a vector of unsigned char to a vector of signed char...

File third_party/blink/renderer/core/inspector/thread_debugger_common_impl.cc
Line 841, Patchset 1: types.append_range(kAllEvents);
Daniel Cheng . resolved

This seemed a bit nicer than creating the temporary Vector but LMK if you don't like this.

Open in Gerrit

Related details

Attention is currently required from:
  • Jeremy Roman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6d43debd5bd778ee3e9c46d077433cd8a22235b7
Gerrit-Change-Number: 7614688
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Josh Karlin <jka...@chromium.org>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Urvang Joshi <urv...@chromium.org>
Gerrit-CC: Wang, Wei4 <wei4...@intel.com>
Gerrit-CC: Yao Xiao <yao...@chromium.org>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
Gerrit-Comment-Date: Thu, 26 Feb 2026 23:23:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

AI Code Reviewer (Gerrit)

unread,
Feb 26, 2026, 6:26:14 PM (13 days ago) Feb 26
to Daniel Cheng, Jeremy Roman, Chromium LUCI CQ, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Josh Karlin, Kevin Babbitt, Kenneth R Christiansen, Raphael Kubo da Costa, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Urvang Joshi, Wang, Wei4, Yao Xiao, Yoav Weiss (@Shopify), abigailbk...@google.com, aleventh...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, jz...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, mbarowsky+wat...@chromium.org, mbarowsky+watc...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, npm+...@chromium.org, ricea...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, yhiran...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org
Attention needed from Jeremy Roman

AI Code Reviewer added 1 comment

File third_party/blink/renderer/core/inspector/thread_debugger_common_impl.cc
Line 832, Patchset 2 (Latest): static constexpr std::string_view kAllEvents[] = {
AI Code Reviewer . unresolved

Blink Style Guide: Prefer blink:: types over STL and base types. Consider using 'const char*' or 'StringView' instead of 'std::string_view' for the array of string literals.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:
  • Jeremy Roman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6d43debd5bd778ee3e9c46d077433cd8a22235b7
Gerrit-Change-Number: 7614688
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-Comment-Date: Thu, 26 Feb 2026 23:26:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jeremy Roman (Gerrit)

unread,
Feb 27, 2026, 10:49:01 AM (12 days ago) Feb 27
to Daniel Cheng, Jeremy Roman, AI Code Reviewer, Chromium LUCI CQ, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Josh Karlin, Kevin Babbitt, Kenneth R Christiansen, Raphael Kubo da Costa, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Urvang Joshi, Wang, Wei4, Yao Xiao, Yoav Weiss (@Shopify), abigailbk...@google.com, aleventh...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, jz...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, mbarowsky+wat...@chromium.org, mbarowsky+watc...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, npm+...@chromium.org, ricea...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, yhiran...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org
Attention needed from Daniel Cheng

Jeremy Roman voted and added 1 comment

Votes added by Jeremy Roman

Code-Review+1

1 comment

Patchset-level comments
Jeremy Roman . resolved

lgtm, though you might want to split this if you don't want to spend time in rebase hell 😊

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Fri, 27 Feb 2026 15:48:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Feb 27, 2026, 11:56:35 AM (12 days ago) Feb 27
    to Daniel Cheng, Jeremy Roman, AI Code Reviewer, Chromium LUCI CQ, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Josh Karlin, Kevin Babbitt, Kenneth R Christiansen, Raphael Kubo da Costa, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Urvang Joshi, Wang, Wei4, Yao Xiao, Yoav Weiss (@Shopify), abigailbk...@google.com, aleventh...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, jz...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, mbarowsky+wat...@chromium.org, mbarowsky+watc...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, npm+...@chromium.org, ricea...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, yhiran...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org

    Daniel Cheng added 2 comments

    File third_party/blink/renderer/core/fetch/multipart_parser_test.cc
    Line 68, Patchset 1: boundary.append_range(base::span_from_cstring("boundary"));
    Daniel Cheng . resolved

    I think these should be spelled as `std::string_view("boundary")` but I didn't want to get into that too much here.

    My general feeling is:

    • it's probably generally undesirable to implicitly treat classic NUL-terminated C string literals as ranges
    • code that doesn't want the NUL can use `std::string_view`
    • ... code that does want the NUL can use... something else.
    Daniel Cheng

    Acknowledged

    File third_party/blink/renderer/core/inspector/thread_debugger_common_impl.cc
    Line 832, Patchset 2 (Latest): static constexpr std::string_view kAllEvents[] = {
    AI Code Reviewer . resolved

    Blink Style Guide: Prefer blink:: types over STL and base types. Consider using 'const char*' or 'StringView' instead of 'std::string_view' for the array of string literals.

    To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
    **Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


    _This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
    _AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
    _[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

    Daniel Cheng

    OK but won't fix: `std::string_view` makes more sense here.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Gerrit-Comment-Date: Fri, 27 Feb 2026 16:56:27 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
      Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
      satisfied_requirement
      open
      diffy

      Daniel Cheng (Gerrit)

      unread,
      Feb 27, 2026, 11:56:45 AM (12 days ago) Feb 27
      to Daniel Cheng, Jeremy Roman, AI Code Reviewer, Chromium LUCI CQ, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Josh Karlin, Kevin Babbitt, Kenneth R Christiansen, Raphael Kubo da Costa, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Urvang Joshi, Wang, Wei4, Yao Xiao, Yoav Weiss (@Shopify), abigailbk...@google.com, aleventh...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, jz...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, mbarowsky+wat...@chromium.org, mbarowsky+watc...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, npm+...@chromium.org, ricea...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, yhiran...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org

      Daniel Cheng voted Commit-Queue+2

      Commit-Queue+2
      Gerrit-Comment-Date: Fri, 27 Feb 2026 16:56:33 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Feb 27, 2026, 12:00:13 PM (12 days ago) Feb 27
      to Daniel Cheng, Jeremy Roman, AI Code Reviewer, Akihiro Ota, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Josh Karlin, Kevin Babbitt, Kenneth R Christiansen, Raphael Kubo da Costa, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Urvang Joshi, Wang, Wei4, Yao Xiao, Yoav Weiss (@Shopify), abigailbk...@google.com, aleventh...@chromium.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, jz...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, mbarowsky+wat...@chromium.org, mbarowsky+watc...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, npm+...@chromium.org, ricea...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, yhiran...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zol...@webkit.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Migrate Vector::AppendVector()/Vector::AppendSpan() to append_range()
      Bug: 487938766
      Change-Id: I6d43debd5bd778ee3e9c46d077433cd8a22235b7
      Reviewed-by: Jeremy Roman <jbr...@chromium.org>
      Commit-Queue: Daniel Cheng <dch...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1591601}
      Files:
      • M third_party/blink/renderer/bindings/core/v8/script_streamer.cc
      • M third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer.cc
      • M third_party/blink/renderer/bindings/core/v8/v8_wasm_response_extensions.cc
      • M third_party/blink/renderer/bindings/modules/v8/v8_binding_for_modules_test.cc
      • M third_party/blink/renderer/core/animation/interpolable_transform_list.cc
      • M third_party/blink/renderer/core/animation/keyframe_effect_model.cc
      • M third_party/blink/renderer/core/animation/keyframe_effect_model.h
      • M third_party/blink/renderer/core/animation/length_list_property_functions.cc
      • M third_party/blink/renderer/core/animation/pending_animations.cc
      • M third_party/blink/renderer/core/css/active_style_sheets.cc
      • M third_party/blink/renderer/core/css/counter_style.cc
      • M third_party/blink/renderer/core/css/css_math_expression_node.cc
      • M third_party/blink/renderer/core/css/css_paint_value.cc
      • M third_party/blink/renderer/core/css/cssom/style_value_factory.cc
      • M third_party/blink/renderer/core/css/invalidation/rule_invalidation_data_visitor.cc
      • M third_party/blink/renderer/core/css/mixin_map.cc
      • M third_party/blink/renderer/core/css/parser/css_parser_impl.cc
      • M third_party/blink/renderer/core/css/parser/css_selector_parser_test.cc
      • M third_party/blink/renderer/core/css/rule_set.cc
      • M third_party/blink/renderer/core/css/style_engine.cc
      • M third_party/blink/renderer/core/css/style_sheet_contents.cc
      • M third_party/blink/renderer/core/dom/node.cc
      • M third_party/blink/renderer/core/dom/pseudo_element_data.h
      • M third_party/blink/renderer/core/dom/range.cc
      • M third_party/blink/renderer/core/editing/commands/undo_step.cc
      • M third_party/blink/renderer/core/editing/finder/find_buffer.cc
      • M third_party/blink/renderer/core/editing/finder/find_results_test.cc
      • M third_party/blink/renderer/core/editing/markers/document_marker_controller.cc
      • M third_party/blink/renderer/core/execution_context/security_context_init.cc
      • M third_party/blink/renderer/core/exported/web_searchable_form_data.cc
      • M third_party/blink/renderer/core/fetch/bytes_consumer_tee.cc
      • M third_party/blink/renderer/core/fetch/fetch_data_loader.cc
      • M third_party/blink/renderer/core/fetch/form_data_bytes_consumer_test.cc
      • M third_party/blink/renderer/core/fetch/multipart_parser.cc
      • M third_party/blink/renderer/core/fetch/multipart_parser_test.cc
      • M third_party/blink/renderer/core/frame/ad_tracker_test.cc
      • M third_party/blink/renderer/core/frame/local_frame.cc
      • M third_party/blink/renderer/core/frame/web_local_frame_impl.cc
      • M third_party/blink/renderer/core/html/anchor_element_metrics_sender.cc
      • M third_party/blink/renderer/core/html/forms/file_input_type.cc
      • M third_party/blink/renderer/core/html/forms/form_controller.cc
      • M third_party/blink/renderer/core/html/html_collection.cc
      • M third_party/blink/renderer/core/html/html_slot_element.cc
      • M third_party/blink/renderer/core/html/image_document_test.cc
      • M third_party/blink/renderer/core/html/media/html_media_element.cc
      • M third_party/blink/renderer/core/html/parser/html_formatting_element_list.cc
      • M third_party/blink/renderer/core/html/parser/text_resource_decoder.cc
      • M third_party/blink/renderer/core/input/touch_list.h
      • M third_party/blink/renderer/core/inspector/devtools_session.cc
      • M third_party/blink/renderer/core/inspector/inspector_diff.cc
      • M third_party/blink/renderer/core/inspector/inspector_highlight.cc
      • M third_party/blink/renderer/core/inspector/inspector_network_agent.cc
      • M third_party/blink/renderer/core/inspector/protocol_unittest.cc
      • M third_party/blink/renderer/core/inspector/thread_debugger_common_impl.cc
      • M third_party/blink/renderer/core/inspector/v8_inspector_string.cc
      • M third_party/blink/renderer/core/intersection_observer/intersection_observation.cc
      • M third_party/blink/renderer/core/layout/exclusions/exclusion_space.cc
      • M third_party/blink/renderer/core/layout/inline/inline_item_segment.cc
      • M third_party/blink/renderer/core/layout/inline/ruby_utils.cc
      • M third_party/blink/renderer/core/layout/inline/text_auto_space_test.cc
      • M third_party/blink/renderer/core/layout/layout_text.cc
      • M third_party/blink/renderer/core/layout/out_of_flow_layout_part.cc
      • M third_party/blink/renderer/core/layout/outline_rect_collector.cc
      • M third_party/blink/renderer/core/layout/physical_box_fragment.cc
      • M third_party/blink/renderer/core/loader/document_loader.cc
      • M third_party/blink/renderer/core/loader/form_submission.cc
      • M third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser.cc
      • M third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser_test.cc
      • M third_party/blink/renderer/core/messaging/blink_transferable_message_mojom_traits_test.cc
      • M third_party/blink/renderer/core/paint/paint_layer.cc
      • M third_party/blink/renderer/core/speculation_rules/document_rule_predicate.cc
      • M third_party/blink/renderer/core/speculation_rules/document_speculation_rules.cc
      • M third_party/blink/renderer/core/speculation_rules/speculation_rule_set.cc
      • M third_party/blink/renderer/core/style/grid_track_list.cc
      • M third_party/blink/renderer/core/testing/intersection_observer_test_helper.h
      • M third_party/blink/renderer/core/testing/sequence_test.cc
      • M third_party/blink/renderer/core/timing/performance_observer.cc
      • M third_party/blink/renderer/core/timing/performance_observer_entry_list.cc
      • M third_party/blink/renderer/core/xml/parser/xml_document_parser.cc
      • M third_party/blink/renderer/core/xml/xpath_node_set.cc
      • M third_party/blink/renderer/core/xml/xpath_node_set.h
      • M third_party/blink/renderer/modules/accessibility/ax_object.cc
      • M third_party/blink/renderer/modules/canvas/canvas2d/canvas_filter_operation_resolver.cc
      • M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_state.cc
      • M third_party/blink/renderer/modules/clipboard/clipboard_reader.cc
      • M third_party/blink/renderer/modules/compute_pressure/pressure_observer_test.cc
      • M third_party/blink/renderer/modules/content_extraction/document_chunker.cc
      • M third_party/blink/renderer/modules/credentialmanagement/credential_manager_type_converters.cc
      • M third_party/blink/renderer/modules/direct_sockets/tcp_readable_stream_wrapper_unittest.cc
      • M third_party/blink/renderer/modules/direct_sockets/udp_writable_stream_wrapper_unittest.cc
      • M third_party/blink/renderer/modules/eventsource/event_source_parser.cc
      • M third_party/blink/renderer/modules/file_system_access/file_system_access_incognito_file_delegate.cc
      • M third_party/blink/renderer/modules/filesystem/directory_reader.cc
      • M third_party/blink/renderer/modules/hid/hid_device.cc
      • M third_party/blink/renderer/modules/indexeddb/idb_request_loader.cc
      • M third_party/blink/renderer/modules/indexeddb/idb_value_wrapping.cc
      • M third_party/blink/renderer/modules/nfc/ndef_message.cc
      • M third_party/blink/renderer/modules/nfc/ndef_record.cc
      • M third_party/blink/renderer/modules/notifications/notification_data.cc
      • M third_party/blink/renderer/modules/payments/secure_payment_confirmation_helper_test.cc
      • M third_party/blink/renderer/modules/peerconnection/rtc_transport/rtc_transport.cc
      • M third_party/blink/renderer/modules/presentation/presentation_connection.cc
      • M third_party/blink/renderer/modules/push_messaging/push_message_data.cc
      • M third_party/blink/renderer/modules/push_messaging/push_messaging_client.cc
      • M third_party/blink/renderer/modules/push_messaging/push_subscription_options.cc
      • M third_party/blink/renderer/modules/push_messaging/push_type_converter.cc
      • M third_party/blink/renderer/modules/service_worker/service_worker_installed_scripts_manager.cc
      • M third_party/blink/renderer/modules/smart_card/smart_card_connection.cc
      • M third_party/blink/renderer/modules/webaudio/deferred_task_handler.cc
      • M third_party/blink/renderer/modules/webcodecs/image_decoder_external.cc
      • M third_party/blink/renderer/modules/webmidi/midi_dispatcher.cc
      • M third_party/blink/renderer/modules/websockets/websocket_channel_impl.cc
      • M third_party/blink/renderer/modules/websockets/websocket_channel_impl_test.cc
      • M third_party/blink/renderer/modules/websockets/websocket_message_chunk_accumulator_test.cc
      • M third_party/blink/renderer/modules/webtransport/incoming_stream_test.cc
      • M third_party/blink/renderer/modules/webtransport/web_transport.cc
      • M third_party/blink/renderer/modules/webtransport/web_transport_test.cc
      • M third_party/blink/renderer/platform/bindings/parkable_string.cc
      • M third_party/blink/renderer/platform/blob/blob_bytes_provider.cc
      • M third_party/blink/renderer/platform/blob/blob_bytes_provider_test.cc
      • M third_party/blink/renderer/platform/blob/blob_data.cc
      • M third_party/blink/renderer/platform/blob/blob_data_test.cc
      • M third_party/blink/renderer/platform/blob/testing/fake_blob_registry.cc
      • M third_party/blink/renderer/platform/data_resource_helper.cc
      • M third_party/blink/renderer/platform/exported/web_thread_safe_data.cc
      • M third_party/blink/renderer/platform/exported/web_url_response.cc
      • M third_party/blink/renderer/platform/fonts/script_run_iterator.cc
      • M third_party/blink/renderer/platform/fonts/shaping/font_features.h
      • M third_party/blink/renderer/platform/fonts/shaping/harfbuzz_shaper.cc
      • M third_party/blink/renderer/platform/graphics/color_space_profile_data.cc
      • M third_party/blink/renderer/platform/graphics/compositing/pending_layer.cc
      • M third_party/blink/renderer/platform/graphics/paint/paint_chunk_subset.h
      • M third_party/blink/renderer/platform/graphics/parkable_image.cc
      • M third_party/blink/renderer/platform/image-decoders/webp/webp_image_decoder.cc
      • M third_party/blink/renderer/platform/image-encoders/image_encoder.h
      • M third_party/blink/renderer/platform/loader/fetch/buffering_bytes_consumer.cc
      • M third_party/blink/renderer/platform/loader/fetch/cached_metadata.cc
      • M third_party/blink/renderer/platform/loader/fetch/cached_metadata.h
      • M third_party/blink/renderer/platform/loader/fetch/cached_metadata_test.cc
      • M third_party/blink/renderer/platform/loader/fetch/raw_resource_test.cc
      • M third_party/blink/renderer/platform/loader/fetch/response_body_loader.cc
      • M third_party/blink/renderer/platform/loader/fetch/script_cached_metadata_handler.cc
      • M third_party/blink/renderer/platform/loader/subresource_integrity.cc
      • M third_party/blink/renderer/platform/loader/testing/bytes_consumer_test_reader.cc
      • M third_party/blink/renderer/platform/loader/testing/replaying_bytes_consumer.h
      • M third_party/blink/renderer/platform/media/watch_time_component.cc
      • M third_party/blink/renderer/platform/mhtml/mhtml_archive.cc
      • M third_party/blink/renderer/platform/mhtml/mhtml_parser.cc
      • M third_party/blink/renderer/platform/mhtml/shared_buffer_chunk_reader.cc
      • M third_party/blink/renderer/platform/network/encoded_form_data.cc
      • M third_party/blink/renderer/platform/network/encoded_form_data_test.cc
      • M third_party/blink/renderer/platform/network/form_data_encoder.cc
      • M third_party/blink/renderer/platform/network/network_utils.cc
      • M third_party/blink/renderer/platform/transforms/transform_operations.cc
      • M third_party/blink/renderer/platform/wtf/shared_buffer.h
      • M third_party/blink/renderer/platform/wtf/shared_buffer_test.cc
      • M third_party/blink/renderer/platform/wtf/text/line_ending.cc
      • M third_party/blink/renderer/platform/wtf/text/string_builder.cc
      • M third_party/blink/renderer/platform/wtf/text/string_impl.h
      • M third_party/blink/renderer/platform/wtf/text/text_codec_icu.cc
      • M third_party/blink/renderer/platform/wtf/vector_test.cc
      Change size: L
      Delta: 161 files changed, 362 insertions(+), 351 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Jeremy Roman
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I6d43debd5bd778ee3e9c46d077433cd8a22235b7
      Gerrit-Change-Number: 7614688
      Gerrit-PatchSet: 3
      Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
      Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages