[css-lists] Make CounterDirectives use default comparison [chromium/src : main]

0 views
Skip to first unread message

Minseong Kim (Gerrit)

unread,
Dec 2, 2025, 2:30:29 AM (8 days ago) Dec 2
to Daniil Sakhapov, Rune Lillesveen, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Daniil Sakhapov and Rune Lillesveen

Minseong Kim added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Minseong Kim . resolved

Would you, please, review this CL?

Open in Gerrit

Related details

Attention is currently required from:
  • Daniil Sakhapov
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3af878a6fcda2f3a0115748400149f3f61a40ad6
Gerrit-Change-Number: 7206459
Gerrit-PatchSet: 2
Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Dec 2025 07:29:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rune Lillesveen (Gerrit)

unread,
Dec 2, 2025, 4:17:53 AM (8 days ago) Dec 2
to Minseong Kim, Rune Lillesveen, Daniil Sakhapov, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Daniil Sakhapov and Minseong Kim

Rune Lillesveen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniil Sakhapov
  • Minseong Kim
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3af878a6fcda2f3a0115748400149f3f61a40ad6
Gerrit-Change-Number: 7206459
Gerrit-PatchSet: 2
Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Attention: Minseong Kim <jja0...@gmail.com>
Gerrit-Comment-Date: Tue, 02 Dec 2025 09:17:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniil Sakhapov (Gerrit)

unread,
Dec 2, 2025, 6:53:49 AM (8 days ago) Dec 2
to Minseong Kim, Rune Lillesveen, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Minseong Kim

Daniil Sakhapov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Minseong Kim
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3af878a6fcda2f3a0115748400149f3f61a40ad6
    Gerrit-Change-Number: 7206459
    Gerrit-PatchSet: 2
    Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
    Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
    Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Minseong Kim <jja0...@gmail.com>
    Gerrit-Comment-Date: Tue, 02 Dec 2025 11:53:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Minseong Kim (Gerrit)

    unread,
    Dec 2, 2025, 7:24:32 AM (8 days ago) Dec 2
    to Daniil Sakhapov, Rune Lillesveen, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

    Minseong Kim voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3af878a6fcda2f3a0115748400149f3f61a40ad6
    Gerrit-Change-Number: 7206459
    Gerrit-PatchSet: 2
    Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
    Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
    Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Comment-Date: Tue, 02 Dec 2025 12:23:56 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Minseong Kim (Gerrit)

    unread,
    Dec 2, 2025, 8:12:59 AM (8 days ago) Dec 2
    to Daniil Sakhapov, Rune Lillesveen, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
    Gerrit-Comment-Date: Tue, 02 Dec 2025 13:12:24 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 2, 2025, 8:29:57 AM (8 days ago) Dec 2
    to Minseong Kim, Daniil Sakhapov, Rune Lillesveen, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [css-lists] Make CounterDirectives use default comparison

    This CL has no behavior changes.
    Bug: 40760770
    Change-Id: I3af878a6fcda2f3a0115748400149f3f61a40ad6
    Reviewed-by: Rune Lillesveen <fut...@chromium.org>
    Reviewed-by: Daniil Sakhapov <sakh...@chromium.org>
    Commit-Queue: Minseong Kim <jja0...@gmail.com>
    Cr-Commit-Position: refs/heads/main@{#1552758}
    Files:
    • M third_party/blink/renderer/core/style/build.gni
    • D third_party/blink/renderer/core/style/counter_directives.cc
    • M third_party/blink/renderer/core/style/counter_directives.h
    Change size: S
    Delta: 3 files changed, 1 insertion(+), 37 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Daniil Sakhapov, +1 by Rune Lillesveen
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3af878a6fcda2f3a0115748400149f3f61a40ad6
    Gerrit-Change-Number: 7206459
    Gerrit-PatchSet: 3
    Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
    Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages