Move FullWidthVariant to the Character class [chromium/src : main]
0 views
Skip to first unread message
Felipe Erias (Gerrit)
Feb 12, 2026, 12:26:43 AM (yesterday) Feb 12
to Kent Tamura, Koji Ishii, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura and Koji Ishii
Felipe Erias added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Felipe Erias . resolved
Hello,
This CL moves the FullWidthVariant function to the Character class, as we discussed in a previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/7568342
Thank you for your feedback.
Best,
Felipe
Related details
Attention is currently required from:
- Kent Tamura
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Feb 12, 2026, 12:41:22 AM (yesterday) Feb 12
to Felipe Erias, Kent Tamura, Koji Ishii, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Felipe Erias and Koji Ishii
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Felipe Erias
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
Feb 12, 2026, 11:26:54 PM (6 hours ago) Feb 12
to Felipe Erias, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Felipe Erias
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Code-Review | +1 |
1 comment
Patchset-level comments
Koji Ishii . resolved
lgtm
Related details
Attention is currently required from:
- Felipe Erias
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Erias (Gerrit)
3:02 AM (3 hours ago) 3:02 AM
to Koji Ishii, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Felipe Erias voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
4:04 AM (2 hours ago) 4:04 AM
to Felipe Erias, Koji Ishii, Kent Tamura, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Move FullWidthVariant to the Character class
FullWidthVariant() maps half-width characters to their full-width
equivalents. It is used to implement `text-transform: full-width`.
This change moves FullWidthVariant() to a public static method in
the Character class in the platform text layer.
No functional changes.
Bug: 41297237
Change-Id: Ie6a1cc15e07b23dcc3521ef1737ef7db5f4f32b0
Commit-Queue: Felipe Erias <felip...@igalia.com>
Reviewed-by: Koji Ishii <ko...@chromium.org>
Reviewed-by: Kent Tamura <tk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1584493}
Files:
- M third_party/blink/renderer/core/style/computed_style.cc
- M third_party/blink/renderer/platform/text/character.cc
- M third_party/blink/renderer/platform/text/character.h
Change size: M
Delta: 3 files changed, 103 insertions(+), 96 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kent Tamura, +1 by Koji Ishii
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages