[pseudo&] Implement DynamicPseudoExtractor [chromium/src : main]
0 views
Skip to first unread message
Anders Hartvoll Ruud (Gerrit)
Sep 16, 2025, 1:33:09 PMSep 16
to Daniil Sakhapov, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Daniil Sakhapov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Daniil Sakhapov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniil Sakhapov (Gerrit)
Sep 17, 2025, 4:50:55 AM (14 days ago) Sep 17
to Anders Hartvoll Ruud, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud
Daniil Sakhapov added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/css/dynamic_pseudo_extractor.h
Line 20, Patchset 2 (Latest):
// .foo::before {}
// .baz::after {}Daniil Sakhapov . unresolved
Could you just add an example with nested pseudo element as well, please?
File third_party/blink/renderer/core/css/dynamic_pseudo_extractor.cc
Line 40, Patchset 2 (Latest):
// The originating compound didn't match; reset the flags and keep
// on going in case this is nested pseudo-element.Daniil Sakhapov . unresolved
Suggestion:
```
// The originating compound didn't match; reset the flags and keep
// on going in case this is nested pseudo-element, e.g., when
// matching 'div::before::marker' against a <div>, the check for
// '::marker' fails because its originating part ('div::before')
// does not match the <div>. We reset flags and continue, eventually
// checking '::before', which will succeed.
```
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniil Sakhapov (Gerrit)
Sep 17, 2025, 4:51:01 AM (14 days ago) Sep 17
to Anders Hartvoll Ruud, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud
Daniil Sakhapov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Sep 17, 2025, 7:33:48 AM (14 days ago) Sep 17
to Daniil Sakhapov, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Anders Hartvoll Ruud voted and added 2 comments![]( "Open in Gerrit")
Votes added by Anders Hartvoll Ruud
| Commit-Queue | +2 |
2 comments
File third_party/blink/renderer/core/css/dynamic_pseudo_extractor.h
Could you just add an example with nested pseudo element as well, please?
Anders Hartvoll Ruud
Done
File third_party/blink/renderer/core/css/dynamic_pseudo_extractor.cc
Line 40, Patchset 2:
// The originating compound didn't match; reset the flags and keep
// on going in case this is nested pseudo-element.Daniil Sakhapov . resolved
Suggestion:
```
// The originating compound didn't match; reset the flags and keep
// on going in case this is nested pseudo-element, e.g., when
// matching 'div::before::marker' against a <div>, the check for
// '::marker' fails because its originating part ('div::before')
// does not match the <div>. We reset flags and continue, eventually
// checking '::before', which will succeed.
```
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 17, 2025, 8:24:00 AM (14 days ago) Sep 17
to Anders Hartvoll Ruud, Daniil Sakhapov, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/css/dynamic_pseudo_extractor.h
Insertions: 6, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/blink/renderer/core/css/dynamic_pseudo_extractor.cc
Insertions: 6, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[pseudo&] Implement DynamicPseudoExtractor
With selector evaluation order changed to start with the pseudo-element
compounds (CL:6940215), our old approach for creating dynamic
pseudo flags no longer works; it's completely dependent on evaluating
the originating element compound of the selector first, and then
"descending" into the pseudo element parts.
The new plan is as follows:
1. Mark selectors that can possibly trigger dynamic pseudo flags
as "pseudo-tainted" during parse-time. (Not done in this CL.)
2. In ElementRuleCollector, a pseudo-tainted rule is considered twice:
a) By the SelectorMatcher (as normal).
b) By the DynamicPseudoExtractor, to look for dynamic pseudo flags.
This CL implements the DynamicPseudoExtractor itself (needed for 2b),
but does not actually integrate it with ElementRuleCollector; it is only
by unit tests for now.
Bug: 444386484
Change-Id: Ib1f4441e97fe91b7c4e8958a5d3778226f53003b
Reviewed-by: Daniil Sakhapov <sakh...@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <and...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1516573}
Files:
- M third_party/blink/renderer/core/css/build.gni
- M third_party/blink/renderer/core/css/css_test_helpers.cc
- M third_party/blink/renderer/core/css/css_test_helpers.h
- A third_party/blink/renderer/core/css/dynamic_pseudo_extractor.cc
- A third_party/blink/renderer/core/css/dynamic_pseudo_extractor.h
- A third_party/blink/renderer/core/css/dynamic_pseudo_extractor_test.cc
- M third_party/blink/renderer/core/style/computed_style_constants.h
Change size: L
Delta: 7 files changed, 572 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniil Sakhapov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages