Rename CSSBoxType to ShapeBox [chromium/src : main]
0 views
Skip to first unread message
Fredrik Söderquist (Gerrit)
May 11, 2026, 12:28:08 PM (4 days ago) May 11
to Ian Kilpatrick, chromium...@chromium.org, Chromium LUCI CQ, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, zol...@webkit.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Attention needed from Ian Kilpatrick
Fredrik Söderquist voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
May 11, 2026, 1:30:40 PM (4 days ago) May 11
to Fredrik Söderquist, chromium...@chromium.org, Chromium LUCI CQ, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, zol...@webkit.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Attention needed from Fredrik Söderquist
Ian Kilpatrick voted![]( "Open in Gerrit")
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 11, 2026, 2:00:14 PM (4 days ago) May 11
to Fredrik Söderquist, Ian Kilpatrick, chromium...@chromium.org, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, zol...@webkit.org, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Rename CSSBoxType to ShapeBox
This is less generic, and reflects the corresponding syntax production
(<shape-box>) and is consistent with the enums for the other *-box
types. Move the definition closer to the other *-box types and update
the documentation.
Add *Box suffix to the ShapeBox enumeration values for consistency with
the other *Box types.
The rest of this CL is plain search-and-replace.
Change-Id: I5ec36a76471ea02e86e78061918fd88576691375
Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
Auto-Submit: Fredrik Söderquist <f...@opera.com>
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1628688}
Files:
- M third_party/blink/renderer/core/animation/css_basic_shape_interpolation_type.cc
- M third_party/blink/renderer/core/animation/css_path_interpolation_type.cc
- M third_party/blink/renderer/core/animation/css_shape_interpolation_type.cc
- M third_party/blink/renderer/core/animation/css_shape_interpolation_type.h
- M third_party/blink/renderer/core/animation/path_interpolation_functions.cc
- M third_party/blink/renderer/core/animation/path_interpolation_functions.h
- M third_party/blink/renderer/core/css/css_identifier_value_mappings.h
- M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
- M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
- M third_party/blink/renderer/core/layout/floats_utils.cc
- M third_party/blink/renderer/core/layout/shapes/shape_outside_info.cc
- M third_party/blink/renderer/core/style/computed_style_constants.h
- M third_party/blink/renderer/core/style/computed_style_test.cc
- M third_party/blink/renderer/core/style/shape_value.h
Change size: M
Delta: 14 files changed, 109 insertions(+), 104 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ian Kilpatrick
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages