[line-clamp] Implement the `block-ellipsis` longhand [chromium/src : main]
0 views
Skip to first unread message
Anders Hartvoll Ruud (Gerrit)
Aug 27, 2025, 9:39:41 AM (13 days ago) Aug 27
to Andreu Botella, AyeAye, Ian Kilpatrick, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Andreu Botella and Ian Kilpatrick
Anders Hartvoll Ruud voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Andreu Botella
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Aug 28, 2025, 12:42:01 PM (12 days ago) Aug 28
to Andreu Botella, Anders Hartvoll Ruud, AyeAye, Ian Kilpatrick, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Andreu Botella and Ian Kilpatrick
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/54574.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Andreu Botella
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
Aug 28, 2025, 12:43:34 PM (12 days ago) Aug 28
to Andreu Botella, Blink W3C Test Autoroller, Anders Hartvoll Ruud, AyeAye, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Andreu Botella
Ian Kilpatrick voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Andreu Botella
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreu Botella (Gerrit)
Aug 28, 2025, 12:46:49 PM (12 days ago) Aug 28
to Ian Kilpatrick, Blink W3C Test Autoroller, Anders Hartvoll Ruud, AyeAye, Chromium LUCI CQ, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Andreu Botella voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 28, 2025, 2:04:09 PM (12 days ago) Aug 28
to Andreu Botella, Ian Kilpatrick, Blink W3C Test Autoroller, Anders Hartvoll Ruud, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[line-clamp] Implement the `block-ellipsis` longhand
Previously, when making `line-clamp` a shorthand property
(https://crrev.com/c/6760402), we purposefully didn't implement the
`block-ellipsis` longhand. This is because there was an ambiguity in
the shorthand's syntax, and the way to resolve that seemed to be to
remove the `none` keyword for `block-ellipsis`. However, since we were
not planning to ship `block-ellipsis: <string>` at first, this would
leave that property being useless in our implementation, since it
would only have one possible value.
However, the CSSWG has resolved to instead rename the `none` keyword
to `block-ellipsis: no-ellipsis` (bug 440063559). This removes the
blocker for implementing this property in Chromium (since now it has
two possible values: `auto` and `no-ellipsis`), and so this CL
implements it.
This patch also fixes and adds some related WPT tests.
Bug: 40336192, 440063559, 440951911
Change-Id: I614c48a5d27bb23e4beb7c8fb0b51ea660be1b11
Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Commit-Queue: Andreu Botella <abot...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1507886}
Files:
- M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
- M third_party/blink/renderer/core/css/css_properties.json5
- M third_party/blink/renderer/core/css/css_property_equality.cc
- M third_party/blink/renderer/core/css/css_value_keywords.json5
- M third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc
- M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
- M third_party/blink/renderer/core/css/properties/shorthands/shorthands_custom.cc
- M third_party/blink/renderer/core/css/style_property_serializer.cc
- M third_party/blink/renderer/core/layout/inline/inline_layout_algorithm.cc
- M third_party/blink/web_tests/TestExpectations
- M third_party/blink/web_tests/VirtualTestSuites
- D third_party/blink/web_tests/external/wpt/css/css-overflow/inheritance-expected.txt
- M third_party/blink/web_tests/external/wpt/css/css-overflow/line-clamp/block-ellipsis-023.html
- M third_party/blink/web_tests/external/wpt/css/css-overflow/parsing/block-ellipsis-valid-expected.txt
- M third_party/blink/web_tests/external/wpt/css/css-overflow/parsing/line-clamp-invalid.html
- M third_party/blink/web_tests/external/wpt/css/css-overflow/parsing/line-clamp-valid-expected.txt
- M third_party/blink/web_tests/external/wpt/css/css-overflow/parsing/line-clamp-valid.html
- M third_party/blink/web_tests/external/wpt/css/css-overflow/parsing/webkit-line-clamp-invalid.html
- M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
- M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
- D third_party/blink/web_tests/platform/linux/virtual/disable-css-line-clamp/external/wpt/css/css-overflow/parsing/line-clamp-valid-expected.txt
- M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
- A third_party/blink/web_tests/virtual/disable-css-line-clamp/external/wpt/css/css-overflow/inheritance-expected.txt
- A third_party/blink/web_tests/virtual/disable-css-line-clamp/external/wpt/css/css-overflow/parsing/block-ellipsis-valid-expected.txt
- M third_party/blink/web_tests/virtual/disable-css-line-clamp/external/wpt/css/css-overflow/parsing/line-clamp-valid-expected.txt
- M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
- M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
- M tools/metrics/histograms/metadata/blink/enums.xml
Change size: M
Delta: 28 files changed, 133 insertions(+), 83 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ian Kilpatrick, +1 by Anders Hartvoll Ruud
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Aug 28, 2025, 2:47:25 PM (12 days ago) Aug 28
to Chromium LUCI CQ, Andreu Botella, Ian Kilpatrick, Anders Hartvoll Ruud, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/54574
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages