Mask backdrop-filter content until all mask-image layers settleHelmut JanuschkaPlease update the commit message to match the latest implementation.
Done
}Helmut JanuschkaMove this down to LayoutBoxModelObject instead (share with LayoutBox)
Done
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
SetShouldDoFullPaintInvalidationWithoutLayoutChange(Why does LayoutBox have this invalidation but LayoutInline doesn't?
LayoutBoxModelObject::ImageChanged(image, defer);Is skipping the super correct if this doesn't have a parent?
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
SetShouldDoFullPaintInvalidationWithoutLayoutChange(Why does LayoutBox have this invalidation but LayoutInline doesn't?
[`LayoutInline::ImageChanged()`](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/layout/layout_inline.cc;l=793;drc=9100cdc84fddf77af57916a8cd5944a750d98386) already calls `SetShouldDoFullPaintInvalidationWithoutLayoutChange(kImage)` for any image change when attached, so a mask-layer-specific invalidation would be redundant.
Is skipping the super correct if this doesn't have a parent?
No :(. Moved the super call before the `Parent()` check so mask paint properties are updated even while detached
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
SetShouldDoFullPaintInvalidationWithoutLayoutChange(Helmut JanuschkaWhy does LayoutBox have this invalidation but LayoutInline doesn't?
[`LayoutInline::ImageChanged()`](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/layout/layout_inline.cc;l=793;drc=9100cdc84fddf77af57916a8cd5944a750d98386) already calls `SetShouldDoFullPaintInvalidationWithoutLayoutChange(kImage)` for any image change when attached, so a mask-layer-specific invalidation would be redundant.
So I think its marginally better to shift this down to LayoutBoxModelObject, SetShouldDoFullPaintInvalidationWithoutLayoutChange is more or less "free", and if someone decides to optimize LayoutInline later they'll be less confused.
| Auto-Submit | +1 |
SetShouldDoFullPaintInvalidationWithoutLayoutChange(Helmut JanuschkaWhy does LayoutBox have this invalidation but LayoutInline doesn't?
Ian Kilpatrick[`LayoutInline::ImageChanged()`](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/layout/layout_inline.cc;l=793;drc=9100cdc84fddf77af57916a8cd5944a750d98386) already calls `SetShouldDoFullPaintInvalidationWithoutLayoutChange(kImage)` for any image change when attached, so a mask-layer-specific invalidation would be redundant.
So I think its marginally better to shift this down to LayoutBoxModelObject, SetShouldDoFullPaintInvalidationWithoutLayoutChange is more or less "free", and if someone decides to optimize LayoutInline later they'll be less confused.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/61484.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
24 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Hide masked content until all mask-image layers settle
Hide content with CSS masks while any mask-image layer is still loading,
and reveal it once every layer settles, treating failed loads as
transparent black
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/61484
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |