[css-lists] Override reversed attribute of <ol> by counter-reset's value [chromium/src : main]

0 views
Skip to first unread message

Minseong Kim (Gerrit)

unread,
Dec 21, 2025, 11:17:57 PM (11 days ago) 12/21/25
to AyeAye, Rune Lillesveen, Daniil Sakhapov, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Daniil Sakhapov and Rune Lillesveen

Minseong Kim added 1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Minseong Kim . resolved

I updated this CL by adding `IsOrderedListReversed` extra field in ComputedStyle. Would you review this, please?

Open in Gerrit

Related details

Attention is currently required from:
  • Daniil Sakhapov
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic2dc0661b9c57dfbd021c0f52b6e7ec0a2070c9d
Gerrit-Change-Number: 7233512
Gerrit-PatchSet: 8
Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Dec 2025 04:17:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Minseong Kim (Gerrit)

unread,
Dec 22, 2025, 8:18:55 AM (11 days ago) 12/22/25
to AyeAye, Rune Lillesveen, Daniil Sakhapov, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Daniil Sakhapov and Rune Lillesveen

Minseong Kim added 1 comment

File third_party/blink/renderer/core/style/computed_style_extra_fields.json5
Line 1245, Patchset 8 (Latest): name: "IsOrderedListReversed",
field_template: "primitive",
type_name: "bool",
field_group: "*",
default_value: "false",
Minseong Kim . unresolved

I checked Firefox's devtools with below HTML file, it converts `reversed` attribute to `counter-reset: reversed(list-item)` style.

```
<!doctype html>
<title>Overriding reversed attribute of ol by counter-reset: reversed(counter)</title>
<ol reversed>
 <li>One
 <li>Two
 <li>Three
</ol>
```

I think I need to use CounterDirectives rather than the extra field?

Gerrit-Comment-Date: Mon, 22 Dec 2025 13:18:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniil Sakhapov (Gerrit)

unread,
Dec 22, 2025, 8:25:42 AM (11 days ago) 12/22/25
to Minseong Kim, AyeAye, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Minseong Kim and Rune Lillesveen

Daniil Sakhapov added 1 comment

File third_party/blink/renderer/core/style/computed_style_extra_fields.json5
Line 1245, Patchset 8 (Latest): name: "IsOrderedListReversed",
field_template: "primitive",
type_name: "bool",
field_group: "*",
default_value: "false",
Minseong Kim . unresolved

I checked Firefox's devtools with below HTML file, it converts `reversed` attribute to `counter-reset: reversed(list-item)` style.

```
<!doctype html>
<title>Overriding reversed attribute of ol by counter-reset: reversed(counter)</title>
<ol reversed>
 <li>One
 <li>Two
 <li>Three
</ol>
```

I think I need to use CounterDirectives rather than the extra field?

Daniil Sakhapov

I think so, yes.
But, please, note that most people are out for holdiays (at least this week), so there won't be much review (this week)

Open in Gerrit

Related details

Attention is currently required from:
  • Minseong Kim
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic2dc0661b9c57dfbd021c0f52b6e7ec0a2070c9d
Gerrit-Change-Number: 7233512
Gerrit-PatchSet: 8
Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Attention: Minseong Kim <jja0...@gmail.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 13:25:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Minseong Kim <jja0...@gmail.com>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages