[SVG] Support path-length as a CSS property. [chromium/src : main]

8 views
Skip to first unread message

Virali Purbey (Gerrit)

unread,
Feb 25, 2026, 7:06:22 AMFeb 25
to Chromium LUCI CQ, chromium...@chromium.org, Fredrik Söderquist, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org

Virali Purbey voted and added 2 comments

Votes added by Virali Purbey

Commit-Queue+1

2 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Virali Purbey . unresolved

Apologies @f...@opera.com and @dma...@microsoft.com. I accidentally deleted the last CL, but I have safely incorporated all the comments on my local machine.

I am submitting a new CL for this change. Really sorry once again.

File third_party/blink/renderer/core/layout/svg/layout_svg_shape.cc
Line 110, Patchset 2 (Latest): base::ValuesEquivalent(old_style->StrokeDashArray(),
Virali Purbey . unresolved

Regarding this, adding `!base::ValuesEquivalent` is out of scope of this bug.

Hence, raised a new CL https://chromium-review.googlesource.com/c/chromium/src/+/7607439 for it (more details mentioned on the CL)

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I24f79c4b0323fcfd7e61d16cff0aaa0b97fe7818
Gerrit-Change-Number: 7607639
Gerrit-PatchSet: 2
Gerrit-Owner: Virali Purbey <virali...@microsoft.com>
Gerrit-Reviewer: Virali Purbey <virali...@microsoft.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Comment-Date: Wed, 25 Feb 2026 12:05:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Virali Purbey (Gerrit)

unread,
Feb 25, 2026, 7:06:53 AMFeb 25
to Chromium LUCI CQ, chromium...@chromium.org, Fredrik Söderquist, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org

Virali Purbey added 1 comment

Patchset-level comments
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Feb 25, 2026, 7:38:57 AMFeb 25
to Virali Purbey, Divyansh Mangal, Vinay Singh, Sejal Anand, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org
Attention needed from Divyansh Mangal, Vinay Singh and Virali Purbey

Fredrik Söderquist added 2 comments

Patchset-level comments
Virali Purbey . unresolved

Apologies @f...@opera.com and @dma...@microsoft.com. I accidentally deleted the last CL, but I have safely incorporated all the comments on my local machine.

I am submitting a new CL for this change. Really sorry once again.

Fredrik Söderquist

Deleted how? As long as it exists here it should be salvageable.

File third_party/blink/renderer/core/layout/svg/layout_svg_shape.cc
Line 110, Patchset 2 (Latest): base::ValuesEquivalent(old_style->StrokeDashArray(),
Virali Purbey . resolved

Regarding this, adding `!base::ValuesEquivalent` is out of scope of this bug.

Hence, raised a new CL https://chromium-review.googlesource.com/c/chromium/src/+/7607439 for it (more details mentioned on the CL)

Fredrik Söderquist

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:
  • Divyansh Mangal
  • Vinay Singh
  • Virali Purbey
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I24f79c4b0323fcfd7e61d16cff0aaa0b97fe7818
Gerrit-Change-Number: 7607639
Gerrit-PatchSet: 2
Gerrit-Owner: Virali Purbey <virali...@microsoft.com>
Gerrit-Reviewer: Divyansh Mangal <dma...@microsoft.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Vinay Singh <vinay...@microsoft.com>
Gerrit-Reviewer: Virali Purbey <virali...@microsoft.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dileep Maurya <dileep...@microsoft.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Gaurav Kumar <gaur...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Ragvesh Sharma <rags...@microsoft.com>
Gerrit-CC: Sejal Anand <sejal...@microsoft.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Vinay Singh <vinay...@microsoft.com>
Gerrit-Attention: Virali Purbey <virali...@microsoft.com>
Gerrit-Attention: Divyansh Mangal <dma...@microsoft.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 12:38:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Virali Purbey <virali...@microsoft.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Virali Purbey (Gerrit)

unread,
Feb 25, 2026, 8:29:41 AMFeb 25
to Divyansh Mangal, Vinay Singh, Fredrik Söderquist, Sejal Anand, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org
Attention needed from Divyansh Mangal, Fredrik Söderquist and Vinay Singh

Virali Purbey added 1 comment

Patchset-level comments
Virali Purbey . unresolved

Apologies @f...@opera.com and @dma...@microsoft.com. I accidentally deleted the last CL, but I have safely incorporated all the comments on my local machine.

I am submitting a new CL for this change. Really sorry once again.

Fredrik Söderquist

Deleted how? As long as it exists here it should be salvageable.

Virali Purbey

I was working on the follow-up to fix the negation error in `layout_svg_shape.cc`, but it also included changes for the path-length CL. I ended up deleting it, which caused the path-length CL to be deleted as well.

I wasn't aware this would happen.

Open in Gerrit

Related details

Attention is currently required from:
  • Divyansh Mangal
  • Fredrik Söderquist
  • Vinay Singh
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Attention: Divyansh Mangal <dma...@microsoft.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 13:29:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Virali Purbey <virali...@microsoft.com>
Comment-In-Reply-To: Fredrik Söderquist <f...@opera.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Feb 25, 2026, 8:53:36 AMFeb 25
to Virali Purbey, Divyansh Mangal, Vinay Singh, Sejal Anand, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org
Attention needed from Divyansh Mangal, Vinay Singh and Virali Purbey

Fredrik Söderquist added 1 comment

Patchset-level comments
Virali Purbey . unresolved

Apologies @f...@opera.com and @dma...@microsoft.com. I accidentally deleted the last CL, but I have safely incorporated all the comments on my local machine.

I am submitting a new CL for this change. Really sorry once again.

Fredrik Söderquist

Deleted how? As long as it exists here it should be salvageable.

Virali Purbey

I was working on the follow-up to fix the negation error in `layout_svg_shape.cc`, but it also included changes for the path-length CL. I ended up deleting it, which caused the path-length CL to be deleted as well.

I wasn't aware this would happen.

Fredrik Söderquist

If you have a "new" branch with this on, you can associate it with this review using `git cl issue <url-to-this-review>`. That should get us back on track (and preserve review history). You may need to "force" the upload, but that should be fine. (The other CL has landed now too, so you could rebase if needed.)

Open in Gerrit

Related details

Attention is currently required from:
  • Divyansh Mangal
  • Vinay Singh
  • Virali Purbey
Gerrit-Attention: Virali Purbey <virali...@microsoft.com>
Gerrit-Attention: Divyansh Mangal <dma...@microsoft.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 13:53:20 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy

Virali Purbey (Gerrit)

unread,
Feb 26, 2026, 1:13:13 AM (13 days ago) Feb 26
to Divyansh Mangal, Vinay Singh, Fredrik Söderquist, Sejal Anand, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org
Attention needed from Divyansh Mangal, Fredrik Söderquist and Vinay Singh

Virali Purbey added 1 comment

Patchset-level comments
Virali Purbey . unresolved

Apologies @f...@opera.com and @dma...@microsoft.com. I accidentally deleted the last CL, but I have safely incorporated all the comments on my local machine.

I am submitting a new CL for this change. Really sorry once again.

Fredrik Söderquist

Deleted how? As long as it exists here it should be salvageable.

Virali Purbey

I was working on the follow-up to fix the negation error in `layout_svg_shape.cc`, but it also included changes for the path-length CL. I ended up deleting it, which caused the path-length CL to be deleted as well.

I wasn't aware this would happen.

Fredrik Söderquist

If you have a "new" branch with this on, you can associate it with this review using `git cl issue <url-to-this-review>`. That should get us back on track (and preserve review history). You may need to "force" the upload, but that should be fine. (The other CL has landed now too, so you could rebase if needed.)

Virali Purbey

The old CL got deleted from Gerrit itself, so there's nothing to associate back to. But my local workspace was intact with all the review feedback incorporated, so I raised this new CL with all the changes applied. The reason why I opened this comment is that the resolved comment threads from the previous review won't carry over here.

Open in Gerrit

Related details

Attention is currently required from:
  • Divyansh Mangal
  • Fredrik Söderquist
  • Vinay Singh
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Attention: Divyansh Mangal <dma...@microsoft.com>
Gerrit-Comment-Date: Thu, 26 Feb 2026 06:12:46 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Feb 26, 2026, 6:56:27 AM (13 days ago) Feb 26
to Virali Purbey, Divyansh Mangal, Vinay Singh, Sejal Anand, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org
Attention needed from Divyansh Mangal, Vinay Singh and Virali Purbey

Fredrik Söderquist added 1 comment

Patchset-level comments
Virali Purbey . unresolved

Apologies @f...@opera.com and @dma...@microsoft.com. I accidentally deleted the last CL, but I have safely incorporated all the comments on my local machine.

I am submitting a new CL for this change. Really sorry once again.

Fredrik Söderquist

Deleted how? As long as it exists here it should be salvageable.

Virali Purbey

I was working on the follow-up to fix the negation error in `layout_svg_shape.cc`, but it also included changes for the path-length CL. I ended up deleting it, which caused the path-length CL to be deleted as well.

I wasn't aware this would happen.

Fredrik Söderquist

If you have a "new" branch with this on, you can associate it with this review using `git cl issue <url-to-this-review>`. That should get us back on track (and preserve review history). You may need to "force" the upload, but that should be fine. (The other CL has landed now too, so you could rebase if needed.)

Virali Purbey

The old CL got deleted from Gerrit itself, so there's nothing to associate back to. But my local workspace was intact with all the review feedback incorporated, so I raised this new CL with all the changes applied. The reason why I opened this comment is that the resolved comment threads from the previous review won't carry over here.

Fredrik Söderquist

The old CL got deleted from Gerrit itself

How can we then be discussing it in the that exact CL?

Open in Gerrit

Related details

Attention is currently required from:
  • Divyansh Mangal
  • Vinay Singh
  • Virali Purbey
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I24f79c4b0323fcfd7e61d16cff0aaa0b97fe7818
Gerrit-Change-Number: 7607639
Gerrit-PatchSet: 3
Gerrit-Owner: Virali Purbey <virali...@microsoft.com>
Gerrit-Reviewer: Divyansh Mangal <dma...@microsoft.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Vinay Singh <vinay...@microsoft.com>
Gerrit-Reviewer: Virali Purbey <virali...@microsoft.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dileep Maurya <dileep...@microsoft.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Gaurav Kumar <gaur...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Ragvesh Sharma <rags...@microsoft.com>
Gerrit-CC: Sejal Anand <sejal...@microsoft.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Vinay Singh <vinay...@microsoft.com>
Gerrit-Attention: Virali Purbey <virali...@microsoft.com>
Gerrit-Attention: Divyansh Mangal <dma...@microsoft.com>
Gerrit-Comment-Date: Thu, 26 Feb 2026 11:56:13 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Feb 27, 2026, 7:22:06 AM (12 days ago) Feb 27
to Virali Purbey, Divyansh Mangal, Vinay Singh, Sejal Anand, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org
Attention needed from Divyansh Mangal, Vinay Singh and Virali Purbey

Fredrik Söderquist voted and added 5 comments

Votes added by Fredrik Söderquist

Code-Review+1

5 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Fredrik Söderquist . resolved

LGTM w/ nits

File third_party/blink/renderer/core/animation/interpolation_types_map.cc
Line 490, Patchset 3 (Latest): case CSSPropertyID::kPathLength:
Fredrik Söderquist . unresolved

This can be merged with the block of other properties that use the same interpolation type.

File third_party/blink/web_tests/external/wpt/svg/geometry/parsing/path-length-computed.tentative.svg
File-level comment, Patchset 3 (Latest):
Fredrik Söderquist . unresolved

Move to `svg/path`.

File third_party/blink/web_tests/external/wpt/svg/geometry/parsing/path-length-invalid.tentative.svg
File-level comment, Patchset 3 (Latest):
Fredrik Söderquist . unresolved

Ditto

File third_party/blink/web_tests/external/wpt/svg/geometry/parsing/path-length-valid.tentative.svg
File-level comment, Patchset 3 (Latest):
Fredrik Söderquist . unresolved

Ditto

Open in Gerrit

Related details

Attention is currently required from:
  • Divyansh Mangal
  • Vinay Singh
  • Virali Purbey
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
Gerrit-Comment-Date: Fri, 27 Feb 2026 12:21:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Divyansh Mangal (Gerrit)

unread,
Mar 1, 2026, 8:07:59 AM (10 days ago) Mar 1
to Virali Purbey, Fredrik Söderquist, Vinay Singh, Sejal Anand, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org
Attention needed from Vinay Singh and Virali Purbey

Divyansh Mangal voted and added 1 comment

Votes added by Divyansh Mangal

Code-Review+1

1 comment

Patchset-level comments
Divyansh Mangal . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Vinay Singh
  • Virali Purbey
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Gerrit-Comment-Date: Sun, 01 Mar 2026 13:07:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Virali Purbey (Gerrit)

    unread,
    Mar 2, 2026, 4:38:07 AM (9 days ago) Mar 2
    to Divyansh Mangal, Fredrik Söderquist, Vinay Singh, Sejal Anand, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org
    Attention needed from Divyansh Mangal, Fredrik Söderquist and Vinay Singh

    Virali Purbey added 5 comments

    Patchset-level comments
    File-level comment, Patchset 2:
    Virali Purbey . resolved

    Apologies @f...@opera.com and @dma...@microsoft.com. I accidentally deleted the last CL, but I have safely incorporated all the comments on my local machine.

    I am submitting a new CL for this change. Really sorry once again.

    Fredrik Söderquist

    Deleted how? As long as it exists here it should be salvageable.

    Virali Purbey

    I was working on the follow-up to fix the negation error in `layout_svg_shape.cc`, but it also included changes for the path-length CL. I ended up deleting it, which caused the path-length CL to be deleted as well.

    I wasn't aware this would happen.

    Fredrik Söderquist

    If you have a "new" branch with this on, you can associate it with this review using `git cl issue <url-to-this-review>`. That should get us back on track (and preserve review history). You may need to "force" the upload, but that should be fine. (The other CL has landed now too, so you could rebase if needed.)

    Virali Purbey

    The old CL got deleted from Gerrit itself, so there's nothing to associate back to. But my local workspace was intact with all the review feedback incorporated, so I raised this new CL with all the changes applied. The reason why I opened this comment is that the resolved comment threads from the previous review won't carry over here.

    Fredrik Söderquist

    The old CL got deleted from Gerrit itself

    How can we then be discussing it in the that exact CL?

    Virali Purbey

    Closing this comment as we discussed this offline.

    File third_party/blink/renderer/core/animation/interpolation_types_map.cc
    Line 490, Patchset 3: case CSSPropertyID::kPathLength:
    Fredrik Söderquist . resolved

    This can be merged with the block of other properties that use the same interpolation type.

    Virali Purbey

    Done

    File third_party/blink/web_tests/external/wpt/svg/geometry/parsing/path-length-computed.tentative.svg
    File-level comment, Patchset 3:
    Fredrik Söderquist . resolved

    Move to `svg/path`.

    Virali Purbey

    Done

    File third_party/blink/web_tests/external/wpt/svg/geometry/parsing/path-length-invalid.tentative.svg
    File-level comment, Patchset 3:
    Fredrik Söderquist . resolved

    Ditto

    Virali Purbey

    Done

    File third_party/blink/web_tests/external/wpt/svg/geometry/parsing/path-length-valid.tentative.svg
    File-level comment, Patchset 3:
    Fredrik Söderquist . resolved

    Ditto

    Virali Purbey

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Divyansh Mangal
    • Fredrik Söderquist
    • Vinay Singh
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I24f79c4b0323fcfd7e61d16cff0aaa0b97fe7818
      Gerrit-Change-Number: 7607639
      Gerrit-PatchSet: 4
      Gerrit-Owner: Virali Purbey <virali...@microsoft.com>
      Gerrit-Reviewer: Divyansh Mangal <dma...@microsoft.com>
      Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
      Gerrit-Reviewer: Vinay Singh <vinay...@microsoft.com>
      Gerrit-Reviewer: Virali Purbey <virali...@microsoft.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Dileep Maurya <dileep...@microsoft.com>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Gaurav Kumar <gaur...@microsoft.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Ragvesh Sharma <rags...@microsoft.com>
      Gerrit-CC: Sejal Anand <sejal...@microsoft.com>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Attention: Vinay Singh <vinay...@microsoft.com>
      Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
      Gerrit-Attention: Divyansh Mangal <dma...@microsoft.com>
      Gerrit-Comment-Date: Mon, 02 Mar 2026 09:37:42 +0000
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Divyansh Mangal (Gerrit)

      unread,
      Mar 2, 2026, 4:53:10 AM (9 days ago) Mar 2
      to Virali Purbey, Fredrik Söderquist, Vinay Singh, Sejal Anand, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org
      Attention needed from Fredrik Söderquist, Vinay Singh and Virali Purbey

      Divyansh Mangal voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Fredrik Söderquist
      • Vinay Singh
      • Virali Purbey
      Gerrit-Attention: Virali Purbey <virali...@microsoft.com>
      Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
      Gerrit-Comment-Date: Mon, 02 Mar 2026 09:52:36 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Divyansh Mangal (Gerrit)

      unread,
      Mar 3, 2026, 11:31:39 AM (8 days ago) Mar 3
      to Virali Purbey, Fredrik Söderquist, Vinay Singh, Sejal Anand, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org
      Attention needed from Fredrik Söderquist, Vinay Singh and Virali Purbey

      Divyansh Mangal voted Commit-Queue+1

      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Fredrik Söderquist
      • Vinay Singh
      • Virali Purbey
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I24f79c4b0323fcfd7e61d16cff0aaa0b97fe7818
      Gerrit-Change-Number: 7607639
      Gerrit-PatchSet: 5
      Gerrit-Owner: Virali Purbey <virali...@microsoft.com>
      Gerrit-Reviewer: Divyansh Mangal <dma...@microsoft.com>
      Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
      Gerrit-Reviewer: Vinay Singh <vinay...@microsoft.com>
      Gerrit-Reviewer: Virali Purbey <virali...@microsoft.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Dileep Maurya <dileep...@microsoft.com>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Gaurav Kumar <gaur...@microsoft.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Ragvesh Sharma <rags...@microsoft.com>
      Gerrit-CC: Sejal Anand <sejal...@microsoft.com>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Attention: Vinay Singh <vinay...@microsoft.com>
      Gerrit-Attention: Virali Purbey <virali...@microsoft.com>
      Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
      Gerrit-Comment-Date: Tue, 03 Mar 2026 16:31:06 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Divyansh Mangal (Gerrit)

      unread,
      Mar 3, 2026, 11:31:58 AM (8 days ago) Mar 3
      to Virali Purbey, Fredrik Söderquist, Vinay Singh, Sejal Anand, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org
      Attention needed from Fredrik Söderquist, Vinay Singh and Virali Purbey

      Divyansh Mangal voted Code-Review+1

      Code-Review+1
      Gerrit-Comment-Date: Tue, 03 Mar 2026 16:31:36 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Divyansh Mangal (Gerrit)

      unread,
      Mar 5, 2026, 1:03:21 AM (6 days ago) Mar 5
      to Virali Purbey, Fredrik Söderquist, Vinay Singh, Sejal Anand, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org
      Attention needed from Fredrik Söderquist, Vinay Singh and Virali Purbey

      Divyansh Mangal voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Fredrik Söderquist
      • Vinay Singh
      • Virali Purbey
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I24f79c4b0323fcfd7e61d16cff0aaa0b97fe7818
      Gerrit-Change-Number: 7607639
      Gerrit-PatchSet: 6
      Gerrit-Owner: Virali Purbey <virali...@microsoft.com>
      Gerrit-Reviewer: Divyansh Mangal <dma...@microsoft.com>
      Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
      Gerrit-Reviewer: Vinay Singh <vinay...@microsoft.com>
      Gerrit-Reviewer: Virali Purbey <virali...@microsoft.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Dileep Maurya <dileep...@microsoft.com>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Gaurav Kumar <gaur...@microsoft.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Ragvesh Sharma <rags...@microsoft.com>
      Gerrit-CC: Sejal Anand <sejal...@microsoft.com>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Attention: Vinay Singh <vinay...@microsoft.com>
      Gerrit-Attention: Virali Purbey <virali...@microsoft.com>
      Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
      Gerrit-Comment-Date: Thu, 05 Mar 2026 06:02:51 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Sejal Anand (Gerrit)

      unread,
      Mar 5, 2026, 1:05:10 AM (6 days ago) Mar 5
      to Virali Purbey, Divyansh Mangal, Fredrik Söderquist, Vinay Singh, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org
      Attention needed from Fredrik Söderquist, Vinay Singh and Virali Purbey

      Sejal Anand voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Fredrik Söderquist
      • Vinay Singh
      • Virali Purbey
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I24f79c4b0323fcfd7e61d16cff0aaa0b97fe7818
        Gerrit-Change-Number: 7607639
        Gerrit-PatchSet: 6
        Gerrit-Owner: Virali Purbey <virali...@microsoft.com>
        Gerrit-Reviewer: Divyansh Mangal <dma...@microsoft.com>
        Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
        Gerrit-Reviewer: Sejal Anand <sejal...@microsoft.com>
        Gerrit-Reviewer: Vinay Singh <vinay...@microsoft.com>
        Gerrit-Reviewer: Virali Purbey <virali...@microsoft.com>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Dileep Maurya <dileep...@microsoft.com>
        Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
        Gerrit-CC: Gaurav Kumar <gaur...@microsoft.com>
        Gerrit-CC: Menard, Alexis <alexis...@intel.com>
        Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
        Gerrit-CC: Ragvesh Sharma <rags...@microsoft.com>
        Gerrit-CC: Stephen Chenney <sche...@chromium.org>
        Gerrit-Attention: Vinay Singh <vinay...@microsoft.com>
        Gerrit-Attention: Virali Purbey <virali...@microsoft.com>
        Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
        Gerrit-Comment-Date: Thu, 05 Mar 2026 06:04:40 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Virali Purbey (Gerrit)

        unread,
        Mar 5, 2026, 1:05:31 AM (6 days ago) Mar 5
        to Sejal Anand, Divyansh Mangal, Fredrik Söderquist, Vinay Singh, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org
        Attention needed from Fredrik Söderquist and Vinay Singh

        Virali Purbey voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Fredrik Söderquist
        • Vinay Singh
        Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
        Gerrit-Comment-Date: Thu, 05 Mar 2026 06:05:08 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Mar 5, 2026, 1:55:35 AM (6 days ago) Mar 5
        to Virali Purbey, Sejal Anand, Divyansh Mangal, Fredrik Söderquist, Vinay Singh, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        [SVG] Support path-length as a CSS property.

        This change adds the `path-length` CSS property with the syntax
        `none | <number [0,∞]>` and initial value `none`, and maps the SVG
        `pathLength` presentation attribute to it.

        The CL includes parsing, computed style serialization, interpolation,
        style equality, and presentation attribute mapping, plus WPT coverage
        for the property, including a `textPath display:none` case as
        mentioned here [1].

        [1] https://github.com/w3c/svgwg/issues/773
        Bug: 1045430
        Change-Id: I24f79c4b0323fcfd7e61d16cff0aaa0b97fe7818
        Reviewed-by: Sejal Anand <sejal...@microsoft.com>
        Reviewed-by: Divyansh Mangal <dma...@microsoft.com>
        Commit-Queue: Virali Purbey <virali...@microsoft.com>
        Cr-Commit-Position: refs/heads/main@{#1594485}
        Files:
        • M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
        • M third_party/blink/renderer/core/animation/interpolation_types_map.cc
        • M third_party/blink/renderer/core/animation/number_property_functions.cc
        • M third_party/blink/renderer/core/css/css_properties.json5
        • M third_party/blink/renderer/core/css/css_property_equality.cc
        • M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
        • M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
        • M third_party/blink/renderer/core/css/resolver/style_builder_converter.h
        • M third_party/blink/renderer/core/layout/svg/layout_svg_shape.cc
        • M third_party/blink/renderer/core/svg/svg_animated_number.h
        • M third_party/blink/renderer/core/svg/svg_geometry_element.cc
        • M third_party/blink/renderer/core/svg/svg_geometry_element.h
        • M third_party/blink/renderer/platform/runtime_enabled_features.json5
        • M third_party/blink/web_tests/external/wpt/css/cssom/getComputedStyle-pseudo-expected.txt
        • M third_party/blink/web_tests/external/wpt/css/cssom/getComputedStyle-pseudo-picker-expected.txt
        • A third_party/blink/web_tests/external/wpt/svg/animations/animate-pathLength.tentative.html
        • A third_party/blink/web_tests/external/wpt/svg/path/animations/path-length-interpolation.tentative.html
        • A third_party/blink/web_tests/external/wpt/svg/path/distance/path-length-css-overrides-presentation-attribute.tentative.svg
        • A third_party/blink/web_tests/external/wpt/svg/path/distance/path-length-css-property-ref.tentative.svg
        • A third_party/blink/web_tests/external/wpt/svg/path/distance/path-length-css-property.tentative.svg
        • A third_party/blink/web_tests/external/wpt/svg/path/distance/path-length-css-zero-ref.tentative.svg
        • A third_party/blink/web_tests/external/wpt/svg/path/distance/path-length-css-zero.tentative.svg
        • A third_party/blink/web_tests/external/wpt/svg/path/parsing/path-length-computed.tentative.svg
        • A third_party/blink/web_tests/external/wpt/svg/path/parsing/path-length-invalid.tentative.svg
        • A third_party/blink/web_tests/external/wpt/svg/path/parsing/path-length-valid.tentative.svg
        • A third_party/blink/web_tests/external/wpt/svg/path/property/inheritance.tentative.svg
        • A third_party/blink/web_tests/external/wpt/svg/text/reftests/textpath-pathlength-css-display-none-ref.tentative.svg
        • A third_party/blink/web_tests/external/wpt/svg/text/reftests/textpath-pathlength-css-display-none.tentative.svg
        • M third_party/blink/web_tests/external/wpt/web-animations/animation-model/animation-types/property-list.js
        • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
        • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
        • M third_party/blink/web_tests/platform/linux/virtual/cssom-getcomputedstyle-pseudo-no-colon-disabled/external/wpt/css/cssom/getComputedStyle-pseudo-expected.txt
        • M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
        • M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
        • M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
        • M tools/metrics/histograms/metadata/blink/enums.xml
        Change size: L
        Delta: 36 files changed, 386 insertions(+), 14 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Divyansh Mangal, +1 by Sejal Anand
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I24f79c4b0323fcfd7e61d16cff0aaa0b97fe7818
        Gerrit-Change-Number: 7607639
        Gerrit-PatchSet: 7
        Gerrit-Owner: Virali Purbey <virali...@microsoft.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Divyansh Mangal <dma...@microsoft.com>
        Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
        Gerrit-Reviewer: Sejal Anand <sejal...@microsoft.com>
        Gerrit-Reviewer: Vinay Singh <vinay...@microsoft.com>
        Gerrit-Reviewer: Virali Purbey <virali...@microsoft.com>
        open
        diffy
        satisfied_requirement

        Blink W3C Test Autoroller (Gerrit)

        unread,
        Mar 5, 2026, 2:39:35 AM (6 days ago) Mar 5
        to Chromium LUCI CQ, Virali Purbey, Sejal Anand, Divyansh Mangal, Fredrik Söderquist, Vinay Singh, Gaurav Kumar, Dileep Maurya, Ragvesh Sharma, chromium...@chromium.org, Chromium Metrics Reviews, Menard, Alexis, Olga Gerchikov, Stephen Chenney, Dirk Schulze, AyeAye, apavlo...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, pdr+svgw...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, jmedle...@chromium.org, kouhe...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org

        Message from Blink W3C Test Autoroller

        The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/58280

        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I24f79c4b0323fcfd7e61d16cff0aaa0b97fe7818
        Gerrit-Change-Number: 7607639
        Gerrit-PatchSet: 7
        Gerrit-Owner: Virali Purbey <virali...@microsoft.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Divyansh Mangal <dma...@microsoft.com>
        Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
        Gerrit-Reviewer: Sejal Anand <sejal...@microsoft.com>
        Gerrit-Reviewer: Vinay Singh <vinay...@microsoft.com>
        Gerrit-Reviewer: Virali Purbey <virali...@microsoft.com>
        Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Dileep Maurya <dileep...@microsoft.com>
        Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
        Gerrit-CC: Gaurav Kumar <gaur...@microsoft.com>
        Gerrit-CC: Menard, Alexis <alexis...@intel.com>
        Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
        Gerrit-CC: Ragvesh Sharma <rags...@microsoft.com>
        Gerrit-CC: Stephen Chenney <sche...@chromium.org>
        Gerrit-Comment-Date: Thu, 05 Mar 2026 07:39:29 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: No
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages