Explicitly instantiate the MemoryPressureListenerRegistry [chromium/src : main]

0 views
Skip to first unread message

Patrick Monette (Gerrit)

unread,
Dec 11, 2025, 1:28:20 PM (9 days ago) Dec 11
to Francois Pierre Doray, Zijie He, Stephen Chenney, Dirk Schulze, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, fuchsia...@chromium.org, ios-revie...@chromium.org, performance-m...@chromium.org, drott+bl...@chromium.org, storage...@chromium.org, gavin...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, fmalit...@chromium.org, blink-reviews-p...@chromium.org, net-r...@chromium.org, thiabaud+watch-d...@google.com, fserb...@chromium.org, jdonnel...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, oshima...@chromium.org, chikamu...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org
Attention needed from Francois Pierre Doray

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I37df95d21cadd3ef2ccbb6a51716481920e48cd7
Gerrit-Change-Number: 7243590
Gerrit-PatchSet: 13
Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 18:28:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Francois Pierre Doray (Gerrit)

unread,
Dec 12, 2025, 11:04:26 AM (8 days ago) Dec 12
to Patrick Monette, Zijie He, Stephen Chenney, Dirk Schulze, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, fuchsia...@chromium.org, ios-revie...@chromium.org, performance-m...@chromium.org, drott+bl...@chromium.org, storage...@chromium.org, gavin...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, fmalit...@chromium.org, blink-reviews-p...@chromium.org, net-r...@chromium.org, thiabaud+watch-d...@google.com, fserb...@chromium.org, jdonnel...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, oshima...@chromium.org, chikamu...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org
Attention needed from Patrick Monette

Francois Pierre Doray added 5 comments

File base/memory/memory_pressure_listener.cc
Line 65, Patchset 17 (Latest): if (!registry_) {
Francois Pierre Doray . unresolved

Add `DLOG(WARNING)` might be appropriate here, to make developers aware that the registration silently failed. In particular, we would want to know this if a MemoryPressureListenerRegistrations are created in a new process type which doesn't instantiate the registry.

File base/memory/memory_pressure_listener_registry.h
Line 69, Patchset 17 (Latest): ObserverList<MemoryPressureListenerRegistryDestructionObserver>::Unchecked
Francois Pierre Doray . unresolved

Why is there a separate observer interface to observe destruction? Could OnBeforeMemoryPressureListenerRegistryDestroyed be a normal method on MemoryPressureListenerRegistration, invoked the same was as Notify?

File content/app/content_main_runner_impl.h
Line 58, Patchset 17 (Latest):
Francois Pierre Doray . unresolved

Document that this is the registry used if this is a browser (i.e. not used with RunOtherNamedProcessTypeMain).

File content/app/content_main_runner_impl.cc
Line 728, Patchset 17 (Latest):
Francois Pierre Doray . unresolved

This is invoked by ContentMainRunnerImpl::Run(). Any reason not to emplace() the registry in ContentMainRunnerImpl::Run() before calling RunBrowser or RunOtherNamedProcessTypeMain, to avoid duplication of logic for the browser and non-browser cases?

File content/browser/cache_storage/cache_storage_manager_unittest.cc
Line 861, Patchset 17 (Latest): base::MemoryPressureListenerRegistry memory_perssure_listener_registry_;
Francois Pierre Doray . unresolved
```suggestion
base::MemoryPressureListenerRegistry memory_pressure_listener_registry_;
```
Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Monette
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I37df95d21cadd3ef2ccbb6a51716481920e48cd7
    Gerrit-Change-Number: 7243590
    Gerrit-PatchSet: 17
    Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-Attention: Patrick Monette <pmon...@chromium.org>
    Gerrit-Comment-Date: Fri, 12 Dec 2025 16:04:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Patrick Monette (Gerrit)

    unread,
    Dec 15, 2025, 4:08:05 PM (5 days ago) Dec 15
    to Francois Pierre Doray, Zijie He, Stephen Chenney, Dirk Schulze, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, fuchsia...@chromium.org, ios-revie...@chromium.org, performance-m...@chromium.org, drott+bl...@chromium.org, storage...@chromium.org, gavin...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, fmalit...@chromium.org, blink-reviews-p...@chromium.org, net-r...@chromium.org, thiabaud+watch-d...@google.com, fserb...@chromium.org, jdonnel...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, oshima...@chromium.org, chikamu...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org
    Attention needed from Francois Pierre Doray

    Patrick Monette added 5 comments

    File base/memory/memory_pressure_listener.cc
    Line 65, Patchset 17: if (!registry_) {
    Francois Pierre Doray . resolved

    Add `DLOG(WARNING)` might be appropriate here, to make developers aware that the registration silently failed. In particular, we would want to know this if a MemoryPressureListenerRegistrations are created in a new process type which doesn't instantiate the registry.

    Patrick Monette

    Good suggestion. The "there is an unsupported process type" case should not happen unless we create child process that doesn't go through chrome.exe, but it's definitely useful for debugging why a unit test wouldn't work, or if a MemoryPressureListenerRegistration is created too early or too late in the process' lifetime.

    File base/memory/memory_pressure_listener_registry.h
    Line 69, Patchset 17: ObserverList<MemoryPressureListenerRegistryDestructionObserver>::Unchecked
    Francois Pierre Doray . resolved

    Why is there a separate observer interface to observe destruction? Could OnBeforeMemoryPressureListenerRegistryDestroyed be a normal method on MemoryPressureListenerRegistration, invoked the same was as Notify?

    Patrick Monette

    Hmmm yeah your suggestion is obviously better. Thanks!

    File content/app/content_main_runner_impl.h
    Line 58, Patchset 17:
    Francois Pierre Doray . resolved

    Document that this is the registry used if this is a browser (i.e. not used with RunOtherNamedProcessTypeMain).

    Patrick Monette

    Done

    File content/app/content_main_runner_impl.cc
    Line 728, Patchset 17:
    Francois Pierre Doray . resolved

    This is invoked by ContentMainRunnerImpl::Run(). Any reason not to emplace() the registry in ContentMainRunnerImpl::Run() before calling RunBrowser or RunOtherNamedProcessTypeMain, to avoid duplication of logic for the browser and non-browser cases?

    Patrick Monette

    Yeah it's a bit weird but ultimately, MemoryPressureListener will be deleted in favor of base::MemoryConsumer so I figured I'd create both registries side-by-side to ensure the behavior is exactly the same.

    I added a TODO to clean this up in the future.

    File content/browser/cache_storage/cache_storage_manager_unittest.cc
    Line 861, Patchset 17: base::MemoryPressureListenerRegistry memory_perssure_listener_registry_;
    Francois Pierre Doray . resolved
    ```suggestion
    base::MemoryPressureListenerRegistry memory_pressure_listener_registry_;
    ```
    Patrick Monette

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Francois Pierre Doray
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I37df95d21cadd3ef2ccbb6a51716481920e48cd7
      Gerrit-Change-Number: 7243590
      Gerrit-PatchSet: 22
      Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
      Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
      Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-CC: Zijie He <zij...@google.com>
      Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
      Gerrit-Comment-Date: Mon, 15 Dec 2025 21:08:00 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Francois Pierre Doray <fdo...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Francois Pierre Doray (Gerrit)

      unread,
      Dec 16, 2025, 12:09:40 PM (4 days ago) Dec 16
      to Patrick Monette, Zijie He, Stephen Chenney, Dirk Schulze, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, fuchsia...@chromium.org, ios-revie...@chromium.org, performance-m...@chromium.org, drott+bl...@chromium.org, storage...@chromium.org, gavin...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, fmalit...@chromium.org, blink-reviews-p...@chromium.org, net-r...@chromium.org, thiabaud+watch-d...@google.com, fserb...@chromium.org, jdonnel...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, oshima...@chromium.org, chikamu...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org
      Attention needed from Patrick Monette

      Francois Pierre Doray voted and added 1 comment

      Votes added by Francois Pierre Doray

      Code-Review+1
      Owners-Override+1

      1 comment

      Patchset-level comments
      Francois Pierre Doray . resolved

      LGTM
      OO+1 for mechanical changes outside of //base

      But let's ask for an owners review for //content/app

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Patrick Monette
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I37df95d21cadd3ef2ccbb6a51716481920e48cd7
      Gerrit-Change-Number: 7243590
      Gerrit-PatchSet: 22
      Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
      Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
      Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-CC: Zijie He <zij...@google.com>
      Gerrit-Attention: Patrick Monette <pmon...@chromium.org>
      Gerrit-Comment-Date: Tue, 16 Dec 2025 17:09:31 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Patrick Monette (Gerrit)

      unread,
      Dec 16, 2025, 12:12:24 PM (4 days ago) Dec 16
      to Avi Drissman, Francois Pierre Doray, Zijie He, Stephen Chenney, Dirk Schulze, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, fuchsia...@chromium.org, ios-revie...@chromium.org, performance-m...@chromium.org, drott+bl...@chromium.org, storage...@chromium.org, gavin...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, fmalit...@chromium.org, blink-reviews-p...@chromium.org, net-r...@chromium.org, thiabaud+watch-d...@google.com, fserb...@chromium.org, jdonnel...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, oshima...@chromium.org, chikamu...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org
      Attention needed from Avi Drissman

      Patrick Monette added 1 comment

      Patchset-level comments
      Patrick Monette . resolved

      +a...@chromium.org for content/app/

      The CL is mostly cleanup but the initialization stuff happens in content/app/content_main_runner_impl.

      The initialization of MemoryPressureListenerRegistry intentionally mirrors the initialization of MemoryConsumerRegistry, which is why there is some repeat code that could technically be simplified, but MemoryPressureListenerRegistry will be deleted in the future anyways in favor of MemoryConsumerRegistry

      PTAL

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Avi Drissman
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I37df95d21cadd3ef2ccbb6a51716481920e48cd7
      Gerrit-Change-Number: 7243590
      Gerrit-PatchSet: 22
      Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
      Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-CC: Zijie He <zij...@google.com>
      Gerrit-Attention: Avi Drissman <a...@chromium.org>
      Gerrit-Comment-Date: Tue, 16 Dec 2025 17:12:16 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy

      Francois Pierre Doray (Gerrit)

      unread,
      Dec 16, 2025, 12:45:44 PM (4 days ago) Dec 16
      to Patrick Monette, Avi Drissman, Zijie He, Stephen Chenney, Dirk Schulze, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, fuchsia...@chromium.org, ios-revie...@chromium.org, performance-m...@chromium.org, drott+bl...@chromium.org, storage...@chromium.org, gavin...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, fmalit...@chromium.org, blink-reviews-p...@chromium.org, net-r...@chromium.org, thiabaud+watch-d...@google.com, fserb...@chromium.org, jdonnel...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, oshima...@chromium.org, chikamu...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org
      Attention needed from Avi Drissman

      Francois Pierre Doray added 1 comment

      File base/memory/memory_pressure_listener_registry.cc
      Line 36, Patchset 22 (Latest):MemoryPressureListenerRegistry::MemoryPressureListenerRegistry() {
      Francois Pierre Doray . unresolved

      Construction/destruction/NotifyMemoryPressure require external synchronization. Worth adding a THREAD_CHECKER?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Avi Drissman
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I37df95d21cadd3ef2ccbb6a51716481920e48cd7
        Gerrit-Change-Number: 7243590
        Gerrit-PatchSet: 22
        Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
        Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
        Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
        Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
        Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
        Gerrit-CC: Stephen Chenney <sche...@chromium.org>
        Gerrit-CC: Zijie He <zij...@google.com>
        Gerrit-Attention: Avi Drissman <a...@chromium.org>
        Gerrit-Comment-Date: Tue, 16 Dec 2025 17:45:36 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Patrick Monette (Gerrit)

        unread,
        Dec 17, 2025, 9:18:28 AM (3 days ago) Dec 17
        to Avi Drissman, Francois Pierre Doray, Zijie He, Stephen Chenney, Dirk Schulze, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, fuchsia...@chromium.org, ios-revie...@chromium.org, performance-m...@chromium.org, drott+bl...@chromium.org, storage...@chromium.org, gavin...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, fmalit...@chromium.org, blink-reviews-p...@chromium.org, net-r...@chromium.org, thiabaud+watch-d...@google.com, fserb...@chromium.org, jdonnel...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, oshima...@chromium.org, chikamu...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org
        Attention needed from Avi Drissman and Francois Pierre Doray

        Patrick Monette added 3 comments

        Patchset-level comments
        File-level comment, Patchset 25 (Latest):
        Patrick Monette . resolved

        PTAnL

        Commit Message
        Line 7, Patchset 23:Try it with threadchecker

        Avi Drissman . resolved

        Your latest patchset accidentally overwrote your commit message; please restore it.

        Patrick Monette

        Oops sorry about that. Now it's fixed.

        File base/memory/memory_pressure_listener_registry.cc
        Line 36, Patchset 22:MemoryPressureListenerRegistry::MemoryPressureListenerRegistry() {
        Francois Pierre Doray . resolved

        Construction/destruction/NotifyMemoryPressure require external synchronization. Worth adding a THREAD_CHECKER?

        Patrick Monette

        Done

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Avi Drissman
        • Francois Pierre Doray
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I37df95d21cadd3ef2ccbb6a51716481920e48cd7
        Gerrit-Change-Number: 7243590
        Gerrit-PatchSet: 25
        Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
        Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
        Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
        Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
        Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
        Gerrit-CC: Stephen Chenney <sche...@chromium.org>
        Gerrit-CC: Zijie He <zij...@google.com>
        Gerrit-Attention: Avi Drissman <a...@chromium.org>
        Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
        Gerrit-Comment-Date: Wed, 17 Dec 2025 14:18:23 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Avi Drissman <a...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Francois Pierre Doray (Gerrit)

        unread,
        Dec 17, 2025, 10:22:50 AM (3 days ago) Dec 17
        to Patrick Monette, Avi Drissman, Zijie He, Stephen Chenney, Dirk Schulze, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, fuchsia...@chromium.org, ios-revie...@chromium.org, performance-m...@chromium.org, drott+bl...@chromium.org, storage...@chromium.org, gavin...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, fmalit...@chromium.org, blink-reviews-p...@chromium.org, net-r...@chromium.org, thiabaud+watch-d...@google.com, fserb...@chromium.org, jdonnel...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, oshima...@chromium.org, chikamu...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org
        Attention needed from Avi Drissman

        Francois Pierre Doray voted and added 1 comment

        Votes added by Francois Pierre Doray

        Code-Review+1
        Owners-Override+1

        1 comment

        Patchset-level comments
        Francois Pierre Doray . resolved

        still LGTM / OO+1
        But let's get an owners review for //content/app

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Avi Drissman
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I37df95d21cadd3ef2ccbb6a51716481920e48cd7
        Gerrit-Change-Number: 7243590
        Gerrit-PatchSet: 25
        Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
        Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
        Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
        Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
        Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
        Gerrit-CC: Stephen Chenney <sche...@chromium.org>
        Gerrit-CC: Zijie He <zij...@google.com>
        Gerrit-Attention: Avi Drissman <a...@chromium.org>
        Gerrit-Comment-Date: Wed, 17 Dec 2025 15:22:30 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Avi Drissman (Gerrit)

        unread,
        Dec 17, 2025, 11:09:30 AM (3 days ago) Dec 17
        to Patrick Monette, Avi Drissman, Francois Pierre Doray, Zijie He, Stephen Chenney, Dirk Schulze, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, fuchsia...@chromium.org, ios-revie...@chromium.org, performance-m...@chromium.org, drott+bl...@chromium.org, storage...@chromium.org, gavin...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, fmalit...@chromium.org, blink-reviews-p...@chromium.org, net-r...@chromium.org, thiabaud+watch-d...@google.com, fserb...@chromium.org, jdonnel...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, oshima...@chromium.org, chikamu...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org
        Attention needed from Patrick Monette

        Avi Drissman voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Patrick Monette
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I37df95d21cadd3ef2ccbb6a51716481920e48cd7
        Gerrit-Change-Number: 7243590
        Gerrit-PatchSet: 25
        Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
        Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
        Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
        Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
        Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
        Gerrit-CC: Stephen Chenney <sche...@chromium.org>
        Gerrit-CC: Zijie He <zij...@google.com>
        Gerrit-Attention: Patrick Monette <pmon...@chromium.org>
        Gerrit-Comment-Date: Wed, 17 Dec 2025 16:09:20 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Francois Pierre Doray (Gerrit)

        unread,
        Dec 17, 2025, 12:33:19 PM (3 days ago) Dec 17
        to Patrick Monette, Avi Drissman, Zijie He, Stephen Chenney, Dirk Schulze, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, fuchsia...@chromium.org, ios-revie...@chromium.org, performance-m...@chromium.org, drott+bl...@chromium.org, storage...@chromium.org, gavin...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, fmalit...@chromium.org, blink-reviews-p...@chromium.org, net-r...@chromium.org, thiabaud+watch-d...@google.com, fserb...@chromium.org, jdonnel...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, oshima...@chromium.org, chikamu...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org
        Attention needed from Patrick Monette

        Francois Pierre Doray voted

        Code-Review+1
        Owners-Override+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Patrick Monette
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I37df95d21cadd3ef2ccbb6a51716481920e48cd7
        Gerrit-Change-Number: 7243590
        Gerrit-PatchSet: 26
        Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
        Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
        Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
        Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
        Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
        Gerrit-CC: Stephen Chenney <sche...@chromium.org>
        Gerrit-CC: Zijie He <zij...@google.com>
        Gerrit-Attention: Patrick Monette <pmon...@chromium.org>
        Gerrit-Comment-Date: Wed, 17 Dec 2025 17:33:12 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Patrick Monette (Gerrit)

        unread,
        Dec 17, 2025, 12:38:44 PM (3 days ago) Dec 17
        to Francois Pierre Doray, Avi Drissman, Zijie He, Stephen Chenney, Dirk Schulze, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, fuchsia...@chromium.org, ios-revie...@chromium.org, performance-m...@chromium.org, drott+bl...@chromium.org, storage...@chromium.org, gavin...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, fmalit...@chromium.org, blink-reviews-p...@chromium.org, net-r...@chromium.org, thiabaud+watch-d...@google.com, fserb...@chromium.org, jdonnel...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, oshima...@chromium.org, chikamu...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org

        Patrick Monette voted and added 1 comment

        Votes added by Patrick Monette

        Commit-Queue+2

        1 comment

        Patchset-level comments
        File-level comment, Patchset 26 (Latest):
        Patrick Monette . resolved

        Thanks!

        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I37df95d21cadd3ef2ccbb6a51716481920e48cd7
        Gerrit-Change-Number: 7243590
        Gerrit-PatchSet: 26
        Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
        Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
        Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
        Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
        Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
        Gerrit-CC: Stephen Chenney <sche...@chromium.org>
        Gerrit-CC: Zijie He <zij...@google.com>
        Gerrit-Comment-Date: Wed, 17 Dec 2025 17:38:38 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Dec 17, 2025, 1:03:48 PM (3 days ago) Dec 17
        to Patrick Monette, Francois Pierre Doray, Avi Drissman, Zijie He, Stephen Chenney, Dirk Schulze, AyeAye, chromium...@chromium.org, chromotin...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, fuchsia...@chromium.org, ios-revie...@chromium.org, performance-m...@chromium.org, drott+bl...@chromium.org, storage...@chromium.org, gavin...@chromium.org, christia...@chromium.org, omnibox-...@chromium.org, fmalit...@chromium.org, blink-reviews-p...@chromium.org, net-r...@chromium.org, thiabaud+watch-d...@google.com, fserb...@chromium.org, jdonnel...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, oshima...@chromium.org, chikamu...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        Explicitly instantiate the MemoryPressureListenerRegistry

        A future change will add state to the MemoryPressureListenerRegistry,
        allowing the notification of the current memory pressure level upon
        registration of a listener.

        If the registry is a static global that is never destroyed, then that
        state leaks to other unit tests.

        This CL changes the registry to require explicit instantiation. This
        way, unit tests that actually need a registry can instantiate it
        themselves, and the state does not leak to other unit tests.
        Bug: 462288601
        Change-Id: I37df95d21cadd3ef2ccbb6a51716481920e48cd7
        Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
        Owners-Override: Francois Pierre Doray <fdo...@chromium.org>
        Commit-Queue: Patrick Monette <pmon...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1560019}
        Files:
        • M base/memory/memory_pressure_listener.cc
        • M base/memory/memory_pressure_listener.h
        • M base/memory/memory_pressure_listener_registry.cc
        • M base/memory/memory_pressure_listener_registry.h
        • M base/memory/memory_pressure_listener_unittest.cc
        • M cc/layers/texture_layer_unittest.cc
        • M cc/trees/layer_tree_host_impl_unittest.cc
        • M chrome/browser/performance_manager/policies/background_tab_loading_policy_unittest.cc
        • M chrome/browser/performance_manager/policies/urgent_page_discarding_policy_unittest.cc
        • M chrome/browser/performance_manager/policies/working_set_trimmer_policy_chromeos_unittest.cc
        • M chrome/browser/predictors/perform_network_context_prefetch_unittest.cc
        • M chrome/browser/ui/views/tabs/tab_hover_card_controller_unittest.cc
        • M chrome/browser/ui/webui/top_chrome/webui_contents_preload_manager_unittest.cc
        • M chromeos/ash/components/memory/pressure/system_memory_pressure_evaluator_unittest.cc
        • M components/breadcrumbs/core/application_breadcrumbs_logger_unittest.cc
        • M components/discardable_memory/service/discardable_shared_memory_manager_unittest.cc
        • M components/memory_pressure/system_memory_pressure_evaluator_fuchsia_unittest.cc
        • M components/memory_pressure/system_memory_pressure_evaluator_win_unittest.cc
        • M components/omnibox/browser/on_device_tail_model_service_unittest.cc
        • M components/paint_preview/player/player_compositor_delegate_unittest.cc
        • M components/performance_manager/graph/policies/bfcache_policy_unittest.cc
        • M content/app/content_main_runner_impl.cc
        • M content/app/content_main_runner_impl.h
        • M content/browser/cache_storage/cache_storage_manager_unittest.cc
        • M content/public/test/browser_test_base.cc
        • M ios/chrome/app/application_delegate/memory_warning_helper_unittest.mm
        • M net/disk_cache/backend_unittest.cc
        • M net/http/http_network_transaction_unittest.cc
        • M net/http/http_stream_pool_group_unittest.cc
        • M net/ssl/ssl_client_session_cache_unittest.cc
        • M remoting/host/it2me/it2me_native_messaging_host_unittest.cc
        • M services/network/shared_dictionary/shared_dictionary_manager_on_disk_unittest.cc
        • M services/network/shared_dictionary/shared_dictionary_manager_unittest.cc
        • M third_party/blink/renderer/controller/user_level_memory_pressure_signal_generator_test.cc
        • M third_party/blink/renderer/platform/graphics/image_decoding_store_test.cc
        • M third_party/blink/renderer/platform/scheduler/main_thread/memory_purge_manager_unittest.cc
        Change size: M
        Delta: 36 files changed, 163 insertions(+), 13 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Francois Pierre Doray
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I37df95d21cadd3ef2ccbb6a51716481920e48cd7
        Gerrit-Change-Number: 7243590
        Gerrit-PatchSet: 27
        Gerrit-Owner: Patrick Monette <pmon...@chromium.org>
        Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
        Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages