Remove unneeded copy in WebFontDecoder [chromium/src : main]
0 views
Skip to first unread message
Ben Wagner (Gerrit)
Dec 15, 2025, 12:53:42 PM (5 days ago) Dec 15
to Florin Malita, Dominik Röttsches, Stephen Chenney, Dirk Schulze, AyeAye, Chromium LUCI CQ, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Attention needed from Dominik Röttsches and Florin Malita
Ben Wagner voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Dominik Röttsches
- Florin Malita
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Florin Malita (Gerrit)
Dec 15, 2025, 1:12:53 PM (5 days ago) Dec 15
to Ben Wagner, Dominik Röttsches, Stephen Chenney, Dirk Schulze, AyeAye, Chromium LUCI CQ, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Attention needed from Ben Wagner and Dominik Röttsches
Florin Malita voted![]( "Open in Gerrit")
Attention is currently required from:
- Ben Wagner
- Dominik Röttsches
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Wagner (Gerrit)
Dec 15, 2025, 1:29:05 PM (5 days ago) Dec 15
to Florin Malita, Dominik Röttsches, Stephen Chenney, Dirk Schulze, AyeAye, Chromium LUCI CQ, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Attention needed from Ben Wagner, Dominik Röttsches and Florin Malita
Ben Wagner voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Ben Wagner
- Dominik Röttsches
- Florin Malita
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 15, 2025, 1:32:10 PM (5 days ago) Dec 15
to Ben Wagner, Florin Malita, Dominik Röttsches, Stephen Chenney, Dirk Schulze, AyeAye, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove unneeded copy in WebFontDecoder
Use SkData::MakeWithProc to wrap the existing font data allocation
instead of calling SkData::MakeWithCopy to make a copy.
Bug: 468570189
Change-Id: I8e7332fa4cff96eb18cb1a58b415297565c38d7c
Auto-Submit: Ben Wagner <bung...@google.com>
Reviewed-by: Ben Wagner <bung...@google.com>
Reviewed-by: Florin Malita <fma...@chromium.org>
Commit-Queue: Ben Wagner <bung...@google.com>
Cr-Commit-Position: refs/heads/main@{#1558831}
Files:
- M third_party/blink/renderer/platform/fonts/web_font_decoder.cc
Change size: S
Delta: 1 file changed, 12 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ben Wagner, +1 by Florin Malita
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Röttsches (Gerrit)
Dec 17, 2025, 6:41:39 AM (3 days ago) Dec 17
to Chromium LUCI CQ, Ben Wagner, Florin Malita, Stephen Chenney, Dirk Schulze, AyeAye, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Dominik Röttsches voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Röttsches
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Dominik Röttsches . resolved
Very nice! Thank you! I think we should try and measure this on pinpoint even.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Röttsches (Gerrit)
Dec 17, 2025, 6:44:56 AM (3 days ago) Dec 17
to Chromium LUCI CQ, Ben Wagner, Florin Malita, Stephen Chenney, Dirk Schulze, AyeAye, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Dominik Röttsches added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Dominik Röttsches . resolved
Pinpoint run posted in: https://pinpoint-dot-chromeperf.appspot.com/job/10d311e4b10000
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages