Use std::array in webgl_image_conversion_test [chromium/src : main]

0 views
Skip to first unread message

Andy Phan (Gerrit)

unread,
Dec 16, 2025, 7:12:28 PM (4 days ago) Dec 16
to Arthur Sonzogni, Kai Ninomiya, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Kai Ninomiya

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Kai Ninomiya
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5d2e3117a5ff656a203d29eb8cb538fdbc992406
Gerrit-Change-Number: 7105970
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Kai Ninomiya <kai...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Dec 2025 00:12:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kai Ninomiya (Gerrit)

unread,
Dec 16, 2025, 8:38:12 PM (4 days ago) Dec 16
to Andy Phan, Arthur Sonzogni, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Andy Phan and Arthur Sonzogni

Kai Ninomiya voted and added 1 comment

Votes added by Kai Ninomiya

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Kai Ninomiya . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
  • Arthur Sonzogni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5d2e3117a5ff656a203d29eb8cb538fdbc992406
Gerrit-Change-Number: 7105970
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Dec 2025 01:38:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andy Phan (Gerrit)

unread,
Dec 17, 2025, 12:54:10 PM (3 days ago) Dec 17
to Arthur Sonzogni, Kai Ninomiya, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Arthur Sonzogni

Andy Phan voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Sonzogni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5d2e3117a5ff656a203d29eb8cb538fdbc992406
Gerrit-Change-Number: 7105970
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Dec 2025 17:53:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 17, 2025, 12:57:15 PM (3 days ago) Dec 17
to Andy Phan, Arthur Sonzogni, Kai Ninomiya, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Use std::array in webgl_image_conversion_test

Fix unsafe buffer usage in webgl_image_conversion_test by using
std::arrays and comparing them instead of C-style arrays.
Fixed: 457306654
Change-Id: I5d2e3117a5ff656a203d29eb8cb538fdbc992406
Reviewed-by: Kai Ninomiya <kai...@chromium.org>
Commit-Queue: Andy Phan <andy...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1560014}
Files:
  • M third_party/blink/renderer/platform/graphics/gpu/webgl_image_conversion_test.cc
Change size: M
Delta: 1 file changed, 102 insertions(+), 106 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kai Ninomiya
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5d2e3117a5ff656a203d29eb8cb538fdbc992406
Gerrit-Change-Number: 7105970
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages