Remove MemoryPressureListener in ImageDecodingStore [chromium/src : main]
0 views
Skip to first unread message
Patrick Monette (Gerrit)
Dec 16, 2025, 11:53:08 AM (4 days ago) Dec 16
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Colin Blundell
Patrick Monette added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Dec 16, 2025, 12:05:24 PM (4 days ago) Dec 16
to Patrick Monette, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Patrick Monette
Colin Blundell voted and added 2 comments![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
2 comments
Patchset-level comments
Colin Blundell . resolved
Thanks!
Commit Message
Line 9, Patchset 2 (Latest):
After experimentation (with the SuppressMemoryListeners feature), thisColin Blundell . unresolved
Is there any documentation to link to for anyone looking back in the future?
Related details
Attention is currently required from:
- Patrick Monette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Monette (Gerrit)
Dec 16, 2025, 12:09:40 PM (4 days ago) Dec 16
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Patrick Monette voted and added 2 comments![]( "Open in Gerrit")
Votes added by Patrick Monette
| Commit-Queue | +2 |
2 comments
Patchset-level comments
Patrick Monette . resolved
Thanks!
Commit Message
Line 9, Patchset 2 (Latest):
After experimentation (with the SuppressMemoryListeners feature), thisColin Blundell . resolved
Is there any documentation to link to for anyone looking back in the future?
Patrick Monette
There is an internal link to results.
go/suppress-mpl-results
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 16, 2025, 12:12:53 PM (4 days ago) Dec 16
to Patrick Monette, Colin Blundell, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove MemoryPressureListener in ImageDecodingStore
After experimentation (with the SuppressMemoryListeners feature), this
MemoryPressureListener implementation did not have any discernible
effect on memory-related metrics, while also having no effect on
performance.
Bug: 465068849
Change-Id: I56a663892f06ea59aeb0aafda349d4ab8e205a30
Commit-Queue: Patrick Monette <pmon...@chromium.org>
Reviewed-by: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1559390}
Files:
- M third_party/blink/renderer/platform/graphics/image_decoding_store.cc
- M third_party/blink/renderer/platform/graphics/image_decoding_store.h
- M third_party/blink/renderer/platform/graphics/image_decoding_store_test.cc
Change size: M
Delta: 3 files changed, 3 insertions(+), 52 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages