[Blink] Eliminate CSPExternalBitmap::info_ [chromium/src : main]

0 views
Skip to first unread message

Corentin Wallez (Gerrit)

unread,
Dec 15, 2025, 11:23:11 AM (5 days ago) Dec 15
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Colin Blundell

Corentin Wallez voted and added 1 comment

Votes added by Corentin Wallez

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Corentin Wallez . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I65863949d9919656a1be4b5431c23b89b9c15a17
Gerrit-Change-Number: 7260519
Gerrit-PatchSet: 2
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Corentin Wallez <cwa...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 16:22:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Dec 16, 2025, 2:22:50 AM (4 days ago) Dec 16
to Colin Blundell, Corentin Wallez, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Commit-Queue+2

1 comment

Patchset-level comments
Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I65863949d9919656a1be4b5431c23b89b9c15a17
Gerrit-Change-Number: 7260519
Gerrit-PatchSet: 2
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Corentin Wallez <cwa...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Dec 2025 07:22:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 16, 2025, 2:29:33 AM (4 days ago) Dec 16
to Colin Blundell, Corentin Wallez, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[Blink] Eliminate CSPExternalBitmap::info_

This ivar is now used only in the constructor and hence not necessary as
an ivar.
Bug: 352263194
Change-Id: I65863949d9919656a1be4b5431c23b89b9c15a17
Reviewed-by: Corentin Wallez <cwa...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1559163}
Files:
  • M third_party/blink/renderer/platform/graphics/canvas_snapshot_provider_external_bitmap.cc
  • M third_party/blink/renderer/platform/graphics/canvas_snapshot_provider_external_bitmap.h
Change size: S
Delta: 2 files changed, 5 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Corentin Wallez
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I65863949d9919656a1be4b5431c23b89b9c15a17
Gerrit-Change-Number: 7260519
Gerrit-PatchSet: 3
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Corentin Wallez <cwa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages