[webgpu] Prototypes MapSync in Blink. [chromium/src : main]

0 views
Skip to first unread message

Loko Kung (Gerrit)

unread,
Nov 12, 2025, 5:33:54 PMNov 12
to Stephen Chenney, chromium...@chromium.org, Dirk Schulze, kinuko...@chromium.org, jmedle...@chromium.org, drott+bl...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, cwalle...@chromium.org, kainin...@chromium.org, blink-reviews-p...@chromium.org

Loko Kung has uploaded the change for review

Commit message

[webgpu] Prototypes MapSync in Blink.
Change-Id: I4971efa927e45c375ac1c3a319d36138d92dab4c

Change diff


Change information

Files:
  • M gpu/command_buffer/client/webgpu_implementation.cc
  • M third_party/blink/renderer/modules/webgpu/gpu_buffer.cc
  • M third_party/blink/renderer/modules/webgpu/gpu_buffer.h
  • M third_party/blink/renderer/modules/webgpu/gpu_buffer.idl
Change size: M
Delta: 4 files changed, 94 insertions(+), 2 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4971efa927e45c375ac1c3a319d36138d92dab4c
Gerrit-Change-Number: 7148766
Gerrit-PatchSet: 1
Gerrit-Owner: Loko Kung <loko...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Corentin Wallez (Gerrit)

unread,
Dec 5, 2025, 6:40:09 AMDec 5
to Loko Kung, Code Review Nudger, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, gavinp...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org
Attention needed from Loko Kung

Corentin Wallez voted and added 1 comment

Votes added by Corentin Wallez

Code-Review+1

1 comment

File third_party/blink/renderer/modules/webgpu/gpu_buffer.cc
Line 359, Patchset 13 (Latest): }
Corentin Wallez . unresolved

Could we DHECK or CHECK that the callback fired after the wait any?

Open in Gerrit

Related details

Attention is currently required from:
  • Loko Kung
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4971efa927e45c375ac1c3a319d36138d92dab4c
Gerrit-Change-Number: 7148766
Gerrit-PatchSet: 13
Gerrit-Owner: Loko Kung <loko...@google.com>
Gerrit-Reviewer: Corentin Wallez <cwa...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Loko Kung <loko...@google.com>
Gerrit-Comment-Date: Fri, 05 Dec 2025 11:39:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Loko Kung (Gerrit)

unread,
Dec 18, 2025, 12:57:58 PM (2 days ago) Dec 18
to Corentin Wallez, Code Review Nudger, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, gavinp...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org

Loko Kung added 1 comment

File third_party/blink/renderer/modules/webgpu/gpu_buffer.cc
Line 359, Patchset 13: }
Corentin Wallez . resolved

Could we DHECK or CHECK that the callback fired after the wait any?

Loko Kung

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4971efa927e45c375ac1c3a319d36138d92dab4c
    Gerrit-Change-Number: 7148766
    Gerrit-PatchSet: 16
    Gerrit-Owner: Loko Kung <loko...@google.com>
    Gerrit-Reviewer: Corentin Wallez <cwa...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Dec 2025 17:57:50 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Corentin Wallez <cwa...@chromium.org>
    satisfied_requirement
    open
    diffy

    Kai Ninomiya (Gerrit)

    unread,
    Dec 18, 2025, 2:43:41 PM (2 days ago) Dec 18
    to Loko Kung, Corentin Wallez, Code Review Nudger, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, gavinp...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org
    Attention needed from Loko Kung

    Kai Ninomiya voted and added 1 comment

    Votes added by Kai Ninomiya

    Code-Review+1

    1 comment

    File third_party/blink/renderer/modules/webgpu/gpu_buffer.cc
    Line 360, Patchset 16 (Latest): "mapSync failed");
    Kai Ninomiya . unresolved

    nit: If this fails wouldn't we expect to also fail the CHECK? So could just CHECK here too.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Loko Kung
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4971efa927e45c375ac1c3a319d36138d92dab4c
      Gerrit-Change-Number: 7148766
      Gerrit-PatchSet: 16
      Gerrit-Owner: Loko Kung <loko...@google.com>
      Gerrit-Reviewer: Corentin Wallez <cwa...@chromium.org>
      Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Attention: Loko Kung <loko...@google.com>
      Gerrit-Comment-Date: Thu, 18 Dec 2025 19:43:32 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Loko Kung (Gerrit)

      unread,
      Dec 18, 2025, 3:04:15 PM (2 days ago) Dec 18
      to Kai Ninomiya, Corentin Wallez, Code Review Nudger, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, gavinp...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org

      Loko Kung added 1 comment

      File third_party/blink/renderer/modules/webgpu/gpu_buffer.cc
      Line 360, Patchset 16: "mapSync failed");
      Kai Ninomiya . resolved

      nit: If this fails wouldn't we expect to also fail the CHECK? So could just CHECK here too.

      Loko Kung

      True, done.

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I4971efa927e45c375ac1c3a319d36138d92dab4c
        Gerrit-Change-Number: 7148766
        Gerrit-PatchSet: 17
        Gerrit-Owner: Loko Kung <loko...@google.com>
        Gerrit-Reviewer: Corentin Wallez <cwa...@chromium.org>
        Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
        Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
        Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
        Gerrit-CC: Stephen Chenney <sche...@chromium.org>
        Gerrit-Comment-Date: Thu, 18 Dec 2025 20:04:03 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Kai Ninomiya <kai...@chromium.org>
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages